Skip to contentSkip to conversation

extcon: palmas: Make of_device_id array const

PATCH In review Jingoo Han 2 participants 2 messages Jun 18, 2014 – Jun 20, 2014 External connector subsystem (extcon)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 extcon: palmas: Make of_device_id array const

Make of_device_id array const, because all OF functions handle it as const.

---
 drivers/extcon/extcon-palmas.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-palmas.c +1 -1
index 7417ce8..5efa96c 100644
@@ -278,7 +278,7 @@ static int palmas_usb_resume(struct device *dev)
 
 static SIMPLE_DEV_PM_OPS(palmas_pm_ops, palmas_usb_suspend, palmas_usb_resume);
 
-static struct of_device_id of_palmas_match_tbl[] = {
+static const struct of_device_id of_palmas_match_tbl[] = {
 	{ .compatible = "ti,palmas-usb", },
 	{ .compatible = "ti,palmas-usb-vid", },
 	{ .compatible = "ti,twl6035-usb", },
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw

Hi Jingoo,

Quoted 14 lines · Jingoo Han

Make of_device_id array const, because all OF functions handle it as const.

---
 drivers/extcon/extcon-palmas.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-palmas.c +0 -0
index 7417ce8..5efa96c 100644

drivers/extcon/extcon-palmas.c static int palmas_usb_resume(struct device *dev) · line 284

Quoted 8 lines
drivers/extcon/extcon-palmas.c +1 -1
@@ -278,7 +278,7 @@ static int palmas_usb_resume(struct device *dev)
 
 static SIMPLE_DEV_PM_OPS(palmas_pm_ops, palmas_usb_suspend, palmas_usb_resume);
 
-static struct of_device_id of_palmas_match_tbl[] = {
+static const struct of_device_id of_palmas_match_tbl[] = {
 	{ .compatible = "ti,palmas-usb", },
 	{ .compatible = "ti,palmas-usb-vid", },
 	{ .compatible = "ti,twl6035-usb", },

The same patch was applied by Krzysztof Kozlowski on extcon-next branch.

Thanks,
Chanwoo Choi