Skip to contentSkip to conversation

Drivers: Fixes coding style warning

PATCH In review Ramesh Basukala 2 participants 2 messages Jun 20, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Drivers: Fixes coding style warning

*

From: Ramesh Basukala <[email protected]>

Attached is a patch which fixes coding style warning message while running checkpatch script.

This patch is currently against a linux 3.15.0-rc15-next kernel. I am submitting this patch as a part of Eudyptula Challenge task.

*---

xlr_net.c 2014-06-20 15:35:06.841105038 -0400 renamed from xlr_net.c.original 2014-06-20 15:32:10.069732488 -0400 +0 -0
@@ -1105,6 +1105,7 @@ err_gmac:

static int xlr_net_remove(struct platform_device *pdev) {
struct xlr_net_priv *priv = platform_get_drvdata(pdev); +
unregister_netdev(priv->ndev); mdiobus_unregister(priv->mii_bus); mdiobus_free(priv->mii_bus);
**

#1 lore raw
Quoted 1 line · Ramesh Basukala

*

What is that for?

Quoted 9 lines

From: Ramesh Basukala <[email protected]>

Attached is a patch which fixes coding style warning message while running checkpatch script.

This patch is currently against a linux 3.15.0-rc15-next kernel. I am

There is no 3.15-rc15 kernel release :(

Quoted 1 line

submitting this patch as a part of Eudyptula Challenge task.

Not needed here.

Quoted 15 lines

*---

xlr_net.c 2014-06-20 15:35:06.841105038 -0400 renamed from xlr_net.c.original 2014-06-20 15:32:10.069732488 -0400 +1 -0
@@ -1105,6 +1105,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
 struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
 unregister_netdev(priv->ndev);
 mdiobus_unregister(priv->mii_bus);
 mdiobus_free(priv->mii_bus);
Quoted 1 line

**

This doesn't apply at all, please always test your patches yourself before resending them.

Also, be explicit as to what you are fixing (what part of the kernel), and use the scripts/get_maintainers.pl tool to send the patches to the correct people and mailing list.

Care to try again?

greg k-h