Skip to contentSkip to conversation

block.c: Remove useless 'buf' variable

PATCH Applied Chen Gang 3 participants 4 messages Jun 21, 2014 – Jun 23, 2014

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 block.c: Remove useless 'buf' variable

'buf' is not used actually, so remove it and related snprintf() statement.

Signed-off-by Chen Gang <[email protected]>
---
 block.c | 2 --
 dtc     | 1 -
 2 files changed, 3 deletions(-)
 delete mode 160000 dtc
block.c +0 -2
index 43abe96..74af8d7 100644
@@ -5595,7 +5595,6 @@ void bdrv_img_create(const char *filename, const char *fmt,
         if (backing_file) {
             BlockDriverState *bs;
             uint64_t size;
-            char buf[32];
             int back_flags;
 
             /* backing files always opened read-only */

@@ -5616,7 +5615,6 @@ void bdrv_img_create(const char *filename, const char *fmt,
             bdrv_get_geometry(bs, &size);
             size *= 512;
 
-            snprintf(buf, sizeof(buf), "%" PRId64, size);
             qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size);
 
             bdrv_unref(bs);
dtc deleted +0 -1
deleted file mode 160000
index bc895d6..0000000
@@ -1 +0,0 @@
-Subproject commit bc895d6d09695d05ceb8b52486ffe861d6cfbdde
Signature · 1 line
1.7.11.7
Applied
#1 lore raw
Quoted 1 line · Chen Gang

'buf' is not used actually, so remove it and related snprintf() statement.

Applied to -trivial, after removing wrong reference to dtc submodule removal. Please don't include these in diffs.

Thanks,

/mjt

author
#2 lore raw
Quoted 6 lines · Michael Tokarev
Quoted 1 line · Chen Gang

'buf' is not used actually, so remove it and related snprintf() statement.

Applied to -trivial, after removing wrong reference to dtc submodule removal. Please don't include these in diffs.

OK, thanks, I shall notice about it, next time.

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed