Skip to contentSkip to conversation

3 fixes for dora

PATCH In review Robert Yang 1 participant 5 messages May 27, 2014 – Jun 22, 2014

lore
Share & tools
lore
#0 lore raw

cover 3 fixes for dora

The following changes since commit 4c58fe468790822fe48e0a570779979c831d0f10:

openssl: fix CVE-2014-0198 (2014-05-21 09:32:38 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib robert/dora-next
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=robert/dora-next

Chen Qi (1):
populate-extfs.sh: keep file timestamps

Jonathan Liu (1):
consolekit: fix console-kit-log-system-start.service startup

Mark Hatle (1):
rpm: Fix rpm -V usage

 .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |   10 ++++++++-
 .../rpm/rpm/rpm-verify-files.patch                 |   22 ++++++++++++++++++++
 meta/recipes-devtools/rpm/rpm_5.4.9.bb             |    1 +
 .../recipes-support/consolekit/consolekit_0.4.6.bb |    6 ++++++
 4 files changed, 38 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/rpm/rpm/rpm-verify-files.patch
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/3 consolekit: fix console-kit-log-system-start.service startup

From: Jonathan Liu <[email protected]>

console-kit-log-system-start.service fails to to start if the /var/log/ConsoleKit directory does not exist. Normally it is created automatically but as we mount a tmpfs at /var/log, we need to add a tmpfiles.d entry to create it.

(From OE-Core master rev: 2a9a14bf400fe0c263c58aa85b02aba7311b1328)

---
 meta/recipes-support/consolekit/consolekit_0.4.6.bb |    6 ++++++
 1 file changed, 6 insertions(+)
meta/recipes-support/consolekit/consolekit_0.4.6.bb +6 -0
index 63da028..ac5c37f 100644
@@ -37,6 +37,12 @@ FILES_pam-plugin-ck-connector += "${base_libdir}/security/*.so"
 RDEPENDS_pam-plugin-ck-connector += "${PN}"
 
 do_install_append() {
+	if ${@base_contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}; then
+		install -d ${D}${sysconfdir}/tmpfiles.d
+		echo "d ${localstatedir}/log/ConsoleKit - - - -" \
+			> ${D}${sysconfdir}/tmpfiles.d/consolekit.conf
+	fi
+
 	# Remove /var/run from package as console-kit-daemon will populate it on startup
 	rm -fr "${D}${localstatedir}/run"
 }
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/3 rpm: Fix rpm -V usage

In reply to Robert Yang

From: Mark Hatle <[email protected]>

[YOCTO #6309]

It appears a logic issue has caused rpm -V to no longer verify the files on the filesystem match what was installed.

(From OE-Core master rev: 117862cd0eebf6887c2ea6cc353432caee2653aa)

---
 .../rpm/rpm/rpm-verify-files.patch                 |   22 ++++++++++++++++++++
 meta/recipes-devtools/rpm/rpm_5.4.9.bb             |    1 +
 2 files changed, 23 insertions(+)
 create mode 100644 meta/recipes-devtools/rpm/rpm/rpm-verify-files.patch
meta/recipes-devtools/rpm/rpm/rpm-verify-files.patch new file +22 -0
new file mode 100644
index 0000000..fddac7a
@@ -0,0 +1,22 @@
+lib/verify.c: Fix rpm -V file processing
+
+rpm -V should verify the md5sum and other values on individual files.
+A logic error in the query for GHOST files prevented this from working.
+
+[ Upstream-Status: Submitted ]
+
+Signed-off-by: Mark Hatle <[email protected]>
+
+Index: rpm-5.4.9/lib/verify.c
+===================================================================
+--- rpm-5.4.9.orig/lib/verify.c
++++ rpm-5.4.9/lib/verify.c
+@@ -587,7 +587,7 @@ uint32_t fc = rpmfiFC(fi);
+ 
+ 	/* If not verifying %ghost, skip ghost files. */
+ 	/* XXX the broken!!! logic disables %ghost queries always. */
+-	if (!(FF_ISSET(qva->qva_fflags, GHOST) && FF_ISSET(fflags, GHOST)))
++	if (!(FF_ISSET(qva->qva_fflags, GHOST)) && FF_ISSET(fflags, GHOST))
+ 	    continue;
+ 
+ 	/* Gather per-file data into a carrier. */
meta/recipes-devtools/rpm/rpm_5.4.9.bb +1 -0
index c2f2279..702a142 100644
@@ -89,6 +89,7 @@ SRC_URI = "http://www.rpm5.org/files/rpm/rpm-5.4/rpm-5.4.9-0.20120508.src.rpm;ex
 	   file://debugedit-valid-file-to-fix-segment-fault.patch \
 	   file://rpm-platform-file-fix.patch \
 	   file://rpm-lsb-compatibility.patch \
+	   file://rpm-verify-files.patch \
 	  "
 
 # Uncomment the following line to enable platform score debugging
Signature · 1 line
1.7.10.4
#3 lore raw

PATCH 3/3 populate-extfs.sh: keep file timestamps

In reply to Robert Yang

From: Chen Qi <[email protected]>

Fix populate-extfs.sh to keep file timestamps while generating the ext file systems.

[YOCTO #6348]

---
 .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh             |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh +9 -1
index 7de720b..76c4d6f 100644
@@ -35,7 +35,7 @@ DEBUGFS="debugfs"
 		fi
 
 		# Only stat once since stat is a time consuming command
-		STAT=$(stat -c "TYPE=\"%F\";DEVNO=\"0x%t 0x%T\";MODE=\"%f\";U=\"%u\";G=\"%g\"" "$FILE")
+		STAT=$(stat -c "TYPE=\"%F\";DEVNO=\"0x%t 0x%T\";MODE=\"%f\";U=\"%u\";G=\"%g\";AT=\"%x\";MT=\"%y\";CT=\"%z\"" "$FILE")
 		eval $STAT
 
 		case $TYPE in
@@ -69,6 +69,14 @@ DEBUGFS="debugfs"
 		# Set uid and gid
 		echo "sif \"$TGT\" uid $U"
 		echo "sif \"$TGT\" gid $G"
+
+		# Set atime, mtime and ctime
+		AT=`echo $AT | cut -d'.' -f1 | sed -e 's#[- :]##g'`
+		MT=`echo $MT | cut -d'.' -f1 | sed -e 's#[- :]##g'`
+		CT=`echo $CT | cut -d'.' -f1 | sed -e 's#[- :]##g'`
+		echo "sif \"$TGT\" atime $AT"
+		echo "sif \"$TGT\" mtime $MT"
+		echo "sif \"$TGT\" ctime $CT"
 	done
 
 	# Handle the hard links.
Signature · 1 line
1.7.10.4
#4 lore raw
In reply to Robert Yang

Ping.

// Robert

Quoted 25 lines · Robert Yang

The following changes since commit 4c58fe468790822fe48e0a570779979c831d0f10:

   openssl: fix CVE-2014-0198 (2014-05-21 09:32:38 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib robert/dora-next
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=robert/dora-next

Chen Qi (1):
populate-extfs.sh: keep file timestamps

Jonathan Liu (1):
consolekit: fix console-kit-log-system-start.service startup

Mark Hatle (1):
rpm: Fix rpm -V usage

  .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |   10 ++++++++-
  .../rpm/rpm/rpm-verify-files.patch                 |   22 ++++++++++++++++++++
  meta/recipes-devtools/rpm/rpm_5.4.9.bb             |    1 +
  .../recipes-support/consolekit/consolekit_0.4.6.bb |    6 ++++++
  4 files changed, 38 insertions(+), 1 deletion(-)

create mode 100644 meta/recipes-devtools/rpm/rpm/rpm-verify-files.patch