Skip to contentSkip to conversation

68328fb: remove check for CONFIG_FB_68328_INVERT

PATCH In review Paul Bolle 2 participants 2 messages May 27, 2014 – Jun 23, 2014 Framebuffer layer

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 68328fb: remove check for CONFIG_FB_68328_INVERT

Since v2.6.7 the 68328 frame buffer driver contains a check for CONFIG_FB_68328_INVERT. But the Kconfig symbol FB_68328_INVERT was never added to the tree. Remove this check and do some related cleaning up.

Signed-off-by Paul Bolle <[email protected]>

---
Untested.

 drivers/video/fbdev/68328fb.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/video/fbdev/68328fb.c +1 -7
index 552258c8f99d..17f21cedff9b 100644
@@ -49,12 +49,6 @@
 #error wrong architecture for the MC68x328 frame buffer device
 #endif
 
-#if defined(CONFIG_FB_68328_INVERT)
-#define MC68X328FB_MONO_VISUAL FB_VISUAL_MONO01
-#else
-#define MC68X328FB_MONO_VISUAL FB_VISUAL_MONO10
-#endif
-
 static u_long videomemory;
 static u_long videomemorysize;
 

@@ -462,7 +456,7 @@ int __init mc68x328fb_init(void)
 	fb_info.fix.line_length  		get_line_length(mc68x328fb_default.xres_virtual, mc68x328fb_default.bits_per_pixel);
 	fb_info.fix.visual = (mc68x328fb_default.bits_per_pixel) = 1 ?
-		MC68X328FB_MONO_VISUAL : FB_VISUAL_PSEUDOCOLOR;
+		FB_VISUAL_MONO10 : FB_VISUAL_PSEUDOCOLOR;
 	if (fb_info.var.bits_per_pixel = 1) {
 		fb_info.var.red.length = fb_info.var.green.length = fb_info.var.blue.length = 1;
 		fb_info.var.red.offset = fb_info.var.green.offset = fb_info.var.blue.offset = 0;
Signature · 1 line
1.9.3
#1 lore raw
Quoted 5 lines · Paul Bolle

Since v2.6.7 the 68328 frame buffer driver contains a check for CONFIG_FB_68328_INVERT. But the Kconfig symbol FB_68328_INVERT was never added to the tree. Remove this check and do some related cleaning up.

Signed-off-by Paul Bolle <[email protected]>

That sounds like something which should be configured per board/panel in any case, not something configured via kernel config.

Queued for 3.17.

Tomi