Skip to contentSkip to conversation

spapr: improve RTAS get_system_parameter

PATCH In review Sam Bobroff 2 participants 3 messages Jun 24, 2014 – Jun 25, 2014

lore
Share & tools
lore
#0 lore raw

cover spapr: improve RTAS get_system_parameter

This series of patches improves QEMU's emulation of the RTAS call "ibm,get-system-parameter" by adding support for the "UUID" and "SPLPAR Characteristics" parameters as well as fixing a problem in the the implementation of the "Platform Processor Diagnostics Run Mode" parameter.

It also improves the surrounding code a little to support the addition of additional system parameters.

Sam Bobroff (4):
spapr: Add rtas_st_buffer utility function
spapr: Add RTAS sysparm UUID
spapr: Fix RTAS sysparm DIAGNOSTICS_RUN_MODE
spapr: Add RTAS sysparm SPLPAR Characteristics

 hw/ppc/spapr_rtas.c    | 28 +++++++++++++++++++++++-----
 include/hw/ppc/spapr.h | 17 +++++++++++++++++
 2 files changed, 40 insertions(+), 5 deletions(-)
Signature · 1 line
1.9.0
#1 lore raw
Quoted 7 lines · Sam Bobroff

This series of patches improves QEMU's emulation of the RTAS call "ibm,get-system-parameter" by adding support for the "UUID" and "SPLPAR Characteristics" parameters as well as fixing a problem in the the implementation of the "Platform Processor Diagnostics Run Mode" parameter.

It also improves the surrounding code a little to support the addition of additional system parameters.

Very nice patch set. Please address the few minor nits I had on it, send a v2 and it's ready to go in I think ;)

Alex

#2 lore raw
Quoted 7 lines · Alexander Graf
Quoted 5 lines · Sam Bobroff

This series of patches improves QEMU's emulation of the RTAS call "ibm,get-system-parameter" by adding support for the "UUID" and "SPLPAR Characteristics" parameters as well as fixing a problem in the the implementation of the "Platform Processor Diagnostics Run Mode" parameter.

Quoted 7 lines
Quoted 2 lines

It also improves the surrounding code a little to support the addition of additional system parameters.

Very nice patch set. Please address the few minor nits I had on it, send a v2 and it's ready to go in I think ;)

Alex

Great, thanks for the review :-)

I think I've addressed all the issues and I'll post a v2 shortly.

Cheers,
Sam B.