Skip to contentSkip to conversation

whois: new package

PATCH New Gustavo Zacarias 3 participants 3 messages Jun 24, 2014 – Jun 25, 2014

lore
Share & tools
lore

Gustavo Zacarias

author
#0 lore raw

PATCH 1/1 whois: new package

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/Config.in       |  1 +
 package/whois/Config.in |  7 +++++++
 package/whois/whois.mk  | 40 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 100644 package/whois/Config.in
 create mode 100644 package/whois/whois.mk
package/Config.in +1 -0
index b839512..838e822 100644
@@ -1047,6 +1047,7 @@ endif
 	source "package/vtun/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/wget/Config.in"
+	source "package/whois/Config.in"
 endif
 	source "package/wireless-regdb/Config.in"
 	source "package/wireless_tools/Config.in"
package/whois/Config.in new file +7 -0
new file mode 100644
index 0000000..40b6590
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_WHOIS
+	bool "whois"
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+	help
+	  Improved whois client.
+
+	  http://www.linux.it/~md/software/
package/whois/whois.mk new file +40 -0
new file mode 100644
index 0000000..24f5167
@@ -0,0 +1,40 @@
+################################################################################
+#
+# whois
+#
+################################################################################
+
+WHOIS_VERSION = 5.1.3
+WHOIS_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/w/whois
+WHOIS_SOURCE = whois_$(WHOIS_VERSION).tar.xz
+# busybox whois is very bad so step on it
+WHOIS_DEPENDENCIES = host-gettext $(if $(BR2_PACKAGE_BUSYBOX),busybox)
+WHOIS_MAKE_ENV = $(TARGET_MAKE_ENV)
+WHOIS_MAKE_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)"
+WHOIS_LICENSE = GPLv2+
+WHOIS_LICENSE_FILES = COPYING
+
+ifeq ($(BR2_NEEDS_GETTEXT),y)
+WHOIS_DEPENDENCIES += gettext
+WHOIS_MAKE_OPT += LIBS="-lintl"
+endif
+
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+WHOIS_DEPENDENCIES += libiconv
+WHOIS_MAKE_ENV += HAVE_ICONV=1
+endif
+
+ifeq ($(BR2_PACKAGE_LIBIDN),y)
+WHOIS_DEPENDENCIES += libidn
+WHOIS_MAKE_ENV += HAVE_LIBIDN=1
+endif
+
+define WHOIS_BUILD_CMDS
+	$(WHOIS_MAKE_ENV) $(MAKE) $(WHOIS_MAKE_OPT) -C $(@D)
+endef
+
+define WHOIS_INSTALL_TARGET_CMDS
+	$(WHOIS_MAKE_ENV) $(MAKE) BASEDIR="$(TARGET_DIR)" install -C $(@D)
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.8.5.5
#1 lore raw

PATCH 1/1 whois: new package

Quoted 1 line · Gustavo Zacarias
Signed-off-by Gustavo Zacarias <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Still, two small remarks...

Quoted 39 lines
---
 package/Config.in       |  1 +
 package/whois/Config.in |  7 +++++++
 package/whois/whois.mk  | 40 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 100644 package/whois/Config.in
 create mode 100644 package/whois/whois.mk
package/Config.in +1 -0
index b839512..838e822 100644
@@ -1047,6 +1047,7 @@ endif
 	source "package/vtun/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/wget/Config.in"
+	source "package/whois/Config.in"
 endif
 	source "package/wireless-regdb/Config.in"
 	source "package/wireless_tools/Config.in"
package/whois/Config.in new file +7 -0
new file mode 100644
index 0000000..40b6590
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_WHOIS
+	bool "whois"
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+	help
+	  Improved whois client.
+
+	  http://www.linux.it/~md/software/
package/whois/whois.mk new file +0 -0
new file mode 100644
index 0000000..24f5167

package/whois/whois.mk line 10

Quoted 10 lines
package/whois/whois.mk new file +10 -0
@@ -0,0 +1,40 @@
+################################################################################
+#
+# whois
+#
+################################################################################
+
+WHOIS_VERSION = 5.1.3
+WHOIS_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/w/whois
+WHOIS_SOURCE = whois_$(WHOIS_VERSION).tar.xz
+# busybox whois is very bad so step on it

I don't think there's a need for such emotional comments :-)

Quoted 17 lines
package/whois/whois.mk new file +17 -0
+WHOIS_DEPENDENCIES = host-gettext $(if $(BR2_PACKAGE_BUSYBOX),busybox)
+WHOIS_MAKE_ENV = $(TARGET_MAKE_ENV)
+WHOIS_MAKE_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)"
+WHOIS_LICENSE = GPLv2+
+WHOIS_LICENSE_FILES = COPYING
+
+ifeq ($(BR2_NEEDS_GETTEXT),y)
+WHOIS_DEPENDENCIES += gettext
+WHOIS_MAKE_OPT += LIBS="-lintl"
+endif
+
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+WHOIS_DEPENDENCIES += libiconv
+WHOIS_MAKE_ENV += HAVE_ICONV=1
+endif
+
+ifeq ($(BR2_PACKAGE_LIBIDN),y)

package/whois/whois.mk line 37

Quoted 10 lines
package/whois/whois.mk new file +10 -0
+WHOIS_DEPENDENCIES += libidn
+WHOIS_MAKE_ENV += HAVE_LIBIDN=1
+endif
+
+define WHOIS_BUILD_CMDS
+	$(WHOIS_MAKE_ENV) $(MAKE) $(WHOIS_MAKE_OPT) -C $(@D)
+endef
+
+define WHOIS_INSTALL_TARGET_CMDS
+	$(WHOIS_MAKE_ENV) $(MAKE) BASEDIR="$(TARGET_DIR)" install -C $(@D)

Isn't it better to include $(WHOIS_MAKE_OPT) here as well? Just in case the
package decides to recompile something during installation...

Regards,
Arnout

Quoted 4 lines
package/whois/whois.mk new file +3 -0
+endef
+
+$(eval $(generic-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 whois: new package

In reply to Gustavo Zacarias
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/Config.in       |  1 +
 package/whois/Config.in |  7 +++++++
 package/whois/whois.mk  | 40 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 100644 package/whois/Config.in
 create mode 100644 package/whois/whois.mk
package/Config.in +0 -0
index b839512..838e822 100644

package/Config.in endif · line 1050

Quoted 4 lines
package/Config.in +1 -0
@@ -1047,6 +1047,7 @@ endif
 	source "package/vtun/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/wget/Config.in"
+	source "package/whois/Config.in"

Committed with Arnout's feedback taken into consideration, thanks.

Signature · 1 line
Bye, Peter Korsgaard