Skip to contentSkip to conversation

arm: zynq: fix a bug in Zynq linker script

PATCH New Masahiro Yamada 3 participants 4 messages Jun 5, 2014 – Jun 25, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: zynq: fix a bug in Zynq linker script

Commit 41623c91 moved exception handlers to ".vectores" section but it missed to adjust Zynq linker script.

Zynq boards hang up after relocation because "_start" symbol does not point to the correct address and gd->relocaddr gets insane.

---
 arch/arm/cpu/armv7/zynq/u-boot.lds | 1 +
 1 file changed, 1 insertion(+)
arch/arm/cpu/armv7/zynq/u-boot.lds +1 -0
index 69500a6..4dc9bb0 100644
@@ -18,6 +18,7 @@ SECTIONS
 	.text :
 	{
 		*(.__image_copy_start)
+		*(.vectors)
 		CPUDIR/start.o (.text*)
 		*(.text*)
 	}
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 arm: zynq: fix a bug in Zynq linker script

Hi Michal,

Quoted 19 lines · On Thu, 5 Jun 2014 19:47:45 +0900 Masahiro Yamada <[email protected]>…

Commit 41623c91 moved exception handlers to ".vectores" section but it missed to adjust Zynq linker script.

Zynq boards hang up after relocation because "_start" symbol does not point to the correct address and gd->relocaddr gets insane.

---
 arch/arm/cpu/armv7/zynq/u-boot.lds | 1 +
 1 file changed, 1 insertion(+)
arch/arm/cpu/armv7/zynq/u-boot.lds +0 -0
index 69500a6..4dc9bb0 100644

arch/arm/cpu/armv7/zynq/u-boot.lds SECTIONS · line 24

Quoted 7 lines
arch/arm/cpu/armv7/zynq/u-boot.lds +1 -0
@@ -18,6 +18,7 @@ SECTIONS
 	.text :
 	{
 		*(.__image_copy_start)
+		*(.vectors)
 		CPUDIR/start.o (.text*)
 		*(.text*)
 	}

This bug should be fixed asap.

Because this patch is assigned to you, could you apply it and send a pull-request, please?

Best Regards
Masahiro Yamada

#2 lore raw

PATCH 1/1 arm: zynq: fix a bug in Zynq linker script

Quoted 35 lines · Masahiro Yamada

Hi Michal,

Quoted 19 lines · On Thu, 5 Jun 2014 19:47:45 +0900 Masahiro Yamada <[email protected]>…

Commit 41623c91 moved exception handlers to ".vectores" section but it missed to adjust Zynq linker script.

Zynq boards hang up after relocation because "_start" symbol does not point to the correct address and gd->relocaddr gets insane.

---
 arch/arm/cpu/armv7/zynq/u-boot.lds | 1 +
 1 file changed, 1 insertion(+)
arch/arm/cpu/armv7/zynq/u-boot.lds +0 -0
index 69500a6..4dc9bb0 100644

arch/arm/cpu/armv7/zynq/u-boot.lds SECTIONS · line 24

Quoted 7 lines
arch/arm/cpu/armv7/zynq/u-boot.lds +1 -0
@@ -18,6 +18,7 @@ SECTIONS
 	.text :
 	{
 		*(.__image_copy_start)
+		*(.vectors)
 		CPUDIR/start.o (.text*)
 		*(.text*)
 	}

This bug should be fixed asap.

Quoted 2 lines

Because this patch is assigned to you, could you apply it and send a pull-request, please?

Applied and pull request sent.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140617/47309fd7/attachment.pgp>
#3 lore raw

PATCH 1/1 arm: zynq: fix a bug in Zynq linker script

Quoted 12 lines · Michal Simek
Quoted 6 lines · Masahiro Yamada

....

This bug should be fixed asap.

Because this patch is assigned to you, could you apply it and send a pull-request, please?

Applied and pull request sent.

Thanks,
Michal

This very same commit breaks the SPL on TT-01. Note, the SPL is not contributed yet (I'm about to).
Has anyone tested a current u-boot on one of the mx31 boards lately? Simply pulling in the vectors section in the linker script does not do the trick.

I'm a bit tight with my time currently, so I'd very much appreciate if someone could test and possibly offer a suggestion on what to change to get that working again, if necessary.

Helmut

--
Scanned by MailScanner.