hwmon: ntc_thermistor: prepose vendor prefix change
Subsystems (5)
v2 cover hwmon: ntc_thermistor: prepose vendor prefix change
As Murata is the manufacturer of the NTC (Negative Temperature coefficient) based Thermistors. ntc_thermistor driver extensively used the prefix "ntc". But, vendor-prefix should be "murata" instead of "ntc".
This patchset
1. Updates the vendor-prefix, DT bindings and Documentation, where ever necessary.
2. Adds thermistor nodes to Exynos5420 based Peach PIT board.
Patches:
1/4. devicetree: bindings: Document murata vendor prefix
Adds the vendor prefix "murata" to vendor-prefixes.txt.
2/4. hwmon: ntc_thermistor: Use the manufacturer name properly
Updates the driver, Kconfig, device tree bindings and Documentation with the Manufacturer/vendor information.
Keeps the old bindings marked as <DEPRECATED> in code and Documentation
3/4. ARM: DTS: use new compatible string as per the documentation
Updates the device node in Exynos4412 based Trats2 board with the new device tree bindings.
4/4. ARM: DTS: Add NTC thermistor nodes as child nodes to ADC
Adds Thermistor nodes to Exynos5420 based Peach PIT board.
This patchset
Naveen Krishna Chatradhi (4):
devicetree: bindings: Document murata vendor prefix
hwmon: ntc_thermistor: Use the manufacturer name properly
ARM: DTS: use new compatible string as per the documentation
ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
.../devicetree/bindings/arm/samsung/exynos-adc.txt | 2 +- .../devicetree/bindings/hwmon/ntc_thermistor.txt | 20 ++++++++---- .../devicetree/bindings/vendor-prefixes.txt | 1 + Documentation/hwmon/ntc_thermistor | 8 ++--- arch/arm/boot/dts/exynos4412-trats2.dts | 4 +-- arch/arm/boot/dts/exynos5420-peach-pit.dts | 34 ++++++++++++++++++++ drivers/hwmon/Kconfig | 5 +-- drivers/hwmon/ntc_thermistor.c | 14 +++++++- 8 files changed, 72 insertions(+), 16 deletions(-)
Signature · 1 line
1.7.9.5
PATCH v2 1/4 devicetree: bindings: Document murata vendor prefix
Add Murata Manufacturing Co., Ltd. to the list of device tree vendor prefixes.
Murata manufactures NTC (Negative Temperature Coefficient) based Thermistors for small scale applications like Mobiles and PDAs.
---
Changes since v1:
1. Rearranged vendor-prefix alphabetically
2. Added Acked-by from Mark Rutland
.../devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -83,6 +83,7 @@ mosaixtech Mosaix Technologies, Inc. moxa Moxa mpl MPL AG mundoreader Mundo Reader S.L. +murata Murata Manufacturing Co., Ltd. mxicy Macronix International Co., Ltd. national National Semiconductor neonode Neonode Inc.
Signature · 1 line
1.7.9.5
PATCH v2 1/4 devicetree: bindings: Document murata vendor prefix
Quoted 9 lines · Naveen Krishna Chatradhi
Add Murata Manufacturing Co., Ltd. to the list of device tree vendor prefixes.
Murata manufactures NTC (Negative Temperature Coefficient) based Thermistors for small scale applications like Mobiles and PDAs.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Acked-by Mark Rutland <[email protected]>Cc Guenter Roeck <[email protected]>
Applied.
Thanks,
Guenter
PATCH v2 2/4 hwmon: ntc_thermistor: Use the manufacturer name properly
In reply to Naveen Krishna ChatradhiMurata Manufacturing Co., Ltd is the vendor for NTC (Negative Temperature coefficient) based Thermistors. But, the driver extensively uses "NTC" as the vendor name.
This patch corrects the vendor name also updates the compatibility strings according to the vendor-prefix.txt
Note: Drivers continue to support the previous compatible strings but further addition of these compatible strings in device tree is deprecated.
---
Changes since v1:
1. Kept the old compatible string marked as <DEPRECATED> in code and in the Documentation.
.../devicetree/bindings/arm/samsung/exynos-adc.txt | 2 +- .../devicetree/bindings/hwmon/ntc_thermistor.txt | 20 ++++++++++++++------ Documentation/hwmon/ntc_thermistor | 8 ++++---- drivers/hwmon/Kconfig | 5 +++-- drivers/hwmon/ntc_thermistor.c | 14 +++++++++++++- 5 files changed, 35 insertions(+), 14 deletions(-)
Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt +1 -1
@@ -48,7 +48,7 @@ adc at 12D10000 { /* NTC thermistor is a hwmon device */ ncp15wb473 at 0 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; pullup-ohm = <47000>; pulldown-ohm = <0>;
Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt +14 -6
@@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors Requires node properties: - "compatible" value : one of - "ntc,ncp15wb473" - "ntc,ncp18wb473" - "ntc,ncp21wb473" - "ntc,ncp03wb473" - "ntc,ncp15wl333" + "murata,ncp15wb473" + "murata,ncp18wb473" + "murata,ncp21wb473" + "murata,ncp03wb473" + "murata,ncp15wl333" + +/* Usage of vendor name "ntc" is deprecated */ +<DEPRECATED> "ntc,ncp15wb473" +<DEPRECATED> "ntc,ncp18wb473" +<DEPRECATED> "ntc,ncp21wb473" +<DEPRECATED> "ntc,ncp03wb473" +<DEPRECATED> "ntc,ncp15wl333" + - "pullup-uv" Pull up voltage in micro volts - "pullup-ohm" Pull up resistor value in ohms - "pulldown-ohm" Pull down resistor value in ohms
@@ -21,7 +29,7 @@ Read more about iio bindings at Example: ncp15wb473 at 0 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; pullup-ohm = <47000>; pulldown-ohm = <0>;
Documentation/hwmon/ntc_thermistor +4 -4
@@ -1,7 +1,7 @@ Kernel driver ntc_thermistor ================= -Supported thermistors: +Supported thermistors from Murata: * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333 Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333' Datasheet: Publicly available at Murata
@@ -15,9 +15,9 @@ Authors: Description ----------- -The NTC thermistor is a simple thermistor that requires users to provide the -resistance and lookup the corresponding compensation table to get the -temperature input. +The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor +that requires users to provide the resistance and lookup the corresponding +compensation table to get the temperature input. The NTC driver provides lookup tables with a linear approximation function and four circuit models with an option not to use any of the four models.
drivers/hwmon/Kconfig +3 -2
@@ -1052,7 +1052,7 @@ config SENSORS_PC87427 will be called pc87427. config SENSORS_NTC_THERMISTOR - tristate "NTC thermistor support" + tristate "NTC thermistor support from Murata" depends on !OF || IIO=n || IIO help This driver supports NTC thermistors sensor reading and its
@@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR send notifications about the temperature. Currently, this driver supports - NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333. + NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333 + from Murata. This driver can also be built as a module. If so, the module will be called ntc-thermistor.
drivers/hwmon/ntc_thermistor.c +13 -1
@@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata) }static const struct of_device_id ntc_match[] = { + { .compatible ="murata,ncp15wb473" , + .data = &ntc_thermistor_id[0 ] }, + { .compatible ="murata,ncp18wb473" , + .data = &ntc_thermistor_id[1 ] }, + { .compatible ="murata,ncp21wb473" , + .data = &ntc_thermistor_id[2 ] }, + { .compatible ="murata,ncp03wb473" , + .data = &ntc_thermistor_id[3 ] }, + { .compatible ="murata,ncp15wl333" , + .data = &ntc_thermistor_id[4 ] }, + +/* Usage of vendor name "ntc" is deprecated */ { .compatible ="ntc,ncp15wb473" , .data = &ntc_thermistor_id[0 ] }, { .compatible ="ntc,ncp18wb473" ,
@@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {module_platform_driver (ntc_thermistor_driver); -MODULE_DESCRIPTION ("NTC Thermistor Driver" ); +MODULE_DESCRIPTION ("NTC Thermistor Driver from Murata" );MODULE_AUTHOR ("MyungJoo Ham <[email protected]>" );MODULE_LICENSE ("GPL" );MODULE_ALIAS ("platform:ntc-thermistor" );
Signature · 1 line
1.7.9.5
PATCH v2 2/4 hwmon: ntc_thermistor: Use the manufacturer name properly
Hello Naveen,
Quoted 18 lines · Naveen Krishna Chatradhi
Murata Manufacturing Co., Ltd is the vendor for NTC (Negative Temperature coefficient) based Thermistors. But, the driver extensively uses "NTC" as the vendor name.
This patch corrects the vendor name also updates the compatibility strings according to the vendor-prefix.txt
Note: Drivers continue to support the previous compatible strings but further addition of these compatible strings in device tree is deprecated.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Guenter Roeck <[email protected]>---
Changes since v1:
1. Kept the old compatible string marked as <DEPRECATED> in code and in the Documentation.
Quoted 7 lines
.../devicetree/bindings/arm/samsung/exynos-adc.txt | 2 +- .../devicetree/bindings/hwmon/ntc_thermistor.txt | 20 ++++++++++++++------ Documentation/hwmon/ntc_thermistor | 8 ++++---- drivers/hwmon/Kconfig | 5 +++-- drivers/hwmon/ntc_thermistor.c | 14 +++++++++++++- 5 files changed, 35 insertions(+), 14 deletions(-)
Looks good to me.
Quoted 139 lines
Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt +1
-1@@ -48,7 +48,7 @@ adc at 12D10000 { /* NTC thermistor is a hwmon device */ ncp15wb473 at 0 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; pullup-ohm = <47000>; pulldown-ohm = <0>;Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt +14
-6@@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors Requires node properties: - "compatible" value : one of - "ntc,ncp15wb473" - "ntc,ncp18wb473" - "ntc,ncp21wb473" - "ntc,ncp03wb473" - "ntc,ncp15wl333" + "murata,ncp15wb473" + "murata,ncp18wb473" + "murata,ncp21wb473" + "murata,ncp03wb473" + "murata,ncp15wl333" + +/* Usage of vendor name "ntc" is deprecated */ +<DEPRECATED> "ntc,ncp15wb473" +<DEPRECATED> "ntc,ncp18wb473" +<DEPRECATED> "ntc,ncp21wb473" +<DEPRECATED> "ntc,ncp03wb473" +<DEPRECATED> "ntc,ncp15wl333" + - "pullup-uv" Pull up voltage in micro volts - "pullup-ohm" Pull up resistor value in ohms - "pulldown-ohm" Pull down resistor value in ohms@@ -21,7 +29,7 @@ Read more about iio bindings at Example: ncp15wb473 at 0 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; pullup-ohm = <47000>; pulldown-ohm = <0>;Documentation/hwmon/ntc_thermistor +4
-4@@ -1,7 +1,7 @@ Kernel driver ntc_thermistor ================= -Supported thermistors: +Supported thermistors from Murata: * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333 Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333' Datasheet: Publicly available at Murata@@ -15,9 +15,9 @@ Authors: Description ----------- -The NTC thermistor is a simple thermistor that requires users to provide the -resistance and lookup the corresponding compensation table to get the -temperature input. +The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor +that requires users to provide the resistance and lookup the corresponding +compensation table to get the temperature input. The NTC driver provides lookup tables with a linear approximation function and four circuit models with an option not to use any of the four models.drivers/hwmon/Kconfig +3
-2@@ -1052,7 +1052,7 @@ config SENSORS_PC87427 will be called pc87427. config SENSORS_NTC_THERMISTOR - tristate "NTC thermistor support" + tristate "NTC thermistor support from Murata" depends on !OF || IIO=n || IIO help This driver supports NTC thermistors sensor reading and its@@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR send notifications about the temperature. Currently, this driver supports - NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333. + NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333 + from Murata. This driver can also be built as a module. If so, the module will be called ntc-thermistor.drivers/hwmon/ntc_thermistor.c +13
-2@@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata) }static const struct of_device_id ntc_match[] = { + { .compatible ="murata,ncp15wb473" , + .data = &ntc_thermistor_id[0 ] }, + { .compatible ="murata,ncp18wb473" , + .data = &ntc_thermistor_id[1 ] }, + { .compatible ="murata,ncp21wb473" , + .data = &ntc_thermistor_id[2 ] }, + { .compatible ="murata,ncp03wb473" , + .data = &ntc_thermistor_id[3 ] }, + { .compatible ="murata,ncp15wl333" , + .data = &ntc_thermistor_id[4 ] }, + +/* Usage of vendor name "ntc" is deprecated */ { .compatible ="ntc,ncp15wb473" , .data = &ntc_thermistor_id[0 ] }, { .compatible ="ntc,ncp18wb473" ,@@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {module_platform_driver (ntc_thermistor_driver); -MODULE_DESCRIPTION ("NTC Thermistor Driver" ); +MODULE_DESCRIPTION ("NTC Thermistor Driver from Murata" );MODULE_AUTHOR ("MyungJoo Ham <[email protected]>" );MODULE_LICENSE ("GPL" );MODULE_ALIAS ("platform:ntc-thermistor" ); --1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v2 2/4 hwmon: ntc_thermistor: Use the manufacturer name properly
Hello Javier,
Quoted 30 lines · Javier Martinez Canillas
Hello Naveen,
Quoted 18 lines · Naveen Krishna Chatradhi
Murata Manufacturing Co., Ltd is the vendor for NTC (Negative Temperature coefficient) based Thermistors. But, the driver extensively uses "NTC" as the vendor name.
This patch corrects the vendor name also updates the compatibility strings according to the vendor-prefix.txt
Note: Drivers continue to support the previous compatible strings but further addition of these compatible strings in device tree is deprecated.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Guenter Roeck <[email protected]>---
Changes since v1:
1. Kept the old compatible string marked as <DEPRECATED> in code and in the Documentation.Quoted 7 lines
.../devicetree/bindings/arm/samsung/exynos-adc.txt | 2 +- .../devicetree/bindings/hwmon/ntc_thermistor.txt | 20 ++++++++++++++------ Documentation/hwmon/ntc_thermistor | 8 ++++---- drivers/hwmon/Kconfig | 5 +++-- drivers/hwmon/ntc_thermistor.c | 14 +++++++++++++- 5 files changed, 35 insertions(+), 14 deletions(-)
Quoted 3 lines
Looks good to me.
Reviewed-by Javier Martinez Canillas <[email protected]>
Thanks for the review.
Quoted 140 lines
Quoted 140 lines
Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt +1
-1@@ -48,7 +48,7 @@ adc at 12D10000 { /* NTC thermistor is a hwmon device */ ncp15wb473 at 0 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; pullup-ohm = <47000>; pulldown-ohm = <0>;Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt +14
-6@@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors Requires node properties: - "compatible" value : one of - "ntc,ncp15wb473" - "ntc,ncp18wb473" - "ntc,ncp21wb473" - "ntc,ncp03wb473" - "ntc,ncp15wl333" + "murata,ncp15wb473" + "murata,ncp18wb473" + "murata,ncp21wb473" + "murata,ncp03wb473" + "murata,ncp15wl333" + +/* Usage of vendor name "ntc" is deprecated */ +<DEPRECATED> "ntc,ncp15wb473" +<DEPRECATED> "ntc,ncp18wb473" +<DEPRECATED> "ntc,ncp21wb473" +<DEPRECATED> "ntc,ncp03wb473" +<DEPRECATED> "ntc,ncp15wl333" + - "pullup-uv" Pull up voltage in micro volts - "pullup-ohm" Pull up resistor value in ohms - "pulldown-ohm" Pull down resistor value in ohms@@ -21,7 +29,7 @@ Read more about iio bindings at Example: ncp15wb473 at 0 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; pullup-ohm = <47000>; pulldown-ohm = <0>;Documentation/hwmon/ntc_thermistor +4
-4@@ -1,7 +1,7 @@ Kernel driver ntc_thermistor ================= -Supported thermistors: +Supported thermistors from Murata: * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333 Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333' Datasheet: Publicly available at Murata@@ -15,9 +15,9 @@ Authors: Description ----------- -The NTC thermistor is a simple thermistor that requires users to provide the -resistance and lookup the corresponding compensation table to get the -temperature input. +The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor +that requires users to provide the resistance and lookup the corresponding +compensation table to get the temperature input. The NTC driver provides lookup tables with a linear approximation function and four circuit models with an option not to use any of the four models.drivers/hwmon/Kconfig +3
-2@@ -1052,7 +1052,7 @@ config SENSORS_PC87427 will be called pc87427. config SENSORS_NTC_THERMISTOR - tristate "NTC thermistor support" + tristate "NTC thermistor support from Murata" depends on !OF || IIO=n || IIO help This driver supports NTC thermistors sensor reading and its@@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR send notifications about the temperature. Currently, this driver supports - NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333. + NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333 + from Murata. This driver can also be built as a module. If so, the module will be called ntc-thermistor.drivers/hwmon/ntc_thermistor.c +13
-2@@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata) }static const struct of_device_id ntc_match[] = { + { .compatible ="murata,ncp15wb473" , + .data = &ntc_thermistor_id[0 ] }, + { .compatible ="murata,ncp18wb473" , + .data = &ntc_thermistor_id[1 ] }, + { .compatible ="murata,ncp21wb473" , + .data = &ntc_thermistor_id[2 ] }, + { .compatible ="murata,ncp03wb473" , + .data = &ntc_thermistor_id[3 ] }, + { .compatible ="murata,ncp15wl333" , + .data = &ntc_thermistor_id[4 ] }, + +/* Usage of vendor name "ntc" is deprecated */ { .compatible ="ntc,ncp15wb473" , .data = &ntc_thermistor_id[0 ] }, { .compatible ="ntc,ncp18wb473" ,@@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {module_platform_driver (ntc_thermistor_driver); -MODULE_DESCRIPTION ("NTC Thermistor Driver" ); +MODULE_DESCRIPTION ("NTC Thermistor Driver from Murata" );MODULE_AUTHOR ("MyungJoo Ham <[email protected]>" );MODULE_LICENSE ("GPL" );MODULE_ALIAS ("platform:ntc-thermistor" ); --1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Shine bright, (: Nav :)
PATCH v2 2/4 hwmon: ntc_thermistor: Use the manufacturer name properly
In reply to Naveen Krishna ChatradhiQuoted 7 lines · Naveen Krishna Chatradhi
Murata Manufacturing Co., Ltd is the vendor for NTC (Negative Temperature coefficient) based Thermistors. But, the driver extensively uses "NTC" as the vendor name.
This patch corrects the vendor name also updates the compatibility strings according to the vendor-prefix.txt
Quoted 6 lines
Note: Drivers continue to support the previous compatible strings but further addition of these compatible strings in device tree is deprecated.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Guenter Roeck <[email protected]>
Applied.
Guenter
PATCH v2 3/4 ARM: DTS: use new compatible string for thermistors in trats2
In reply to Naveen Krishna ChatradhiAs Murata Manufactures the NTC based thermistors. The vendor name in the compatibility is preposed to change to "murata"
This patch uses the new compatibility string in exynos4412 based Trats2 board.
---
Changes since v1:
None
arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos4412-trats2.dts +2 -2
@@ -771,7 +771,7 @@ }; thermistor-ap at 0 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; /* VCC_1.8V_AP */ pullup-ohm = <100000>; /* 100K */ pulldown-ohm = <100000>; /* 100K */
@@ -779,7 +779,7 @@ }; thermistor-battery at 1 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; /* VCC_1.8V_AP */ pullup-ohm = <100000>; /* 100K */ pulldown-ohm = <100000>; /* 100K */
Signature · 1 line
1.7.9.5
PATCH v2 3/4 ARM: DTS: use new compatible string for thermistors in trats2
Quoted 30 lines · Naveen Krishna Chatradhi
As Murata Manufactures the NTC based thermistors. The vendor name in the compatibility is preposed to change to "murata"
This patch uses the new compatibility string in exynos4412 based Trats2 board.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Chanwoo Choi <[email protected]>---
Changes since v1:
Nonearch/arm/boot/dts/exynos4412-trats2.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/exynos4412-trats2.dts +1
-1@@ -771,7 +771,7 @@ }; thermistor-ap at 0 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; /* VCC_1.8V_AP */ pullup-ohm = <100000>; /* 100K */ pulldown-ohm = <100000>; /* 100K */
arch/arm/boot/dts/exynos4412-trats2.dts line 785
Quoted 8 lines
arch/arm/boot/dts/exynos4412-trats2.dts +1
-1@@ -779,7 +779,7 @@ }; thermistor-battery at 1 { - compatible = "ntc,ncp15wb473"; + compatible = "murata,ncp15wb473"; pullup-uv = <1800000>; /* VCC_1.8V_AP */ pullup-ohm = <100000>; /* 100K */ pulldown-ohm = <100000>; /* 100K */
Looks good to me.
Thanks,
Chanwoo Choi
PATCH v2 4/4 ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
In reply to Naveen Krishna ChatradhiExynos5420 based Peach PIT board has 4 NTC thermistors to measure temperatures at various points on the board.
IIO based ADC becomes the parent and NTC thermistors are the childs, via the HWMON interface.
---
Changes since v1:
1. Arranged the ADC node alphabetical
2. Added "status = "okay"" to the ADC node
This patch needs
1. MAX77802 PMIC device tree nodes (for ldo9)
https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
This patch set is tested
1. On Peach PIT board via sysfs entry exposed by hwmon localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input 37436
36449
38560
38059
2. Backward compatibility is tested by replacing "murata" with "ntc" in the dts nodes and running the above test.
arch/arm/boot/dts/exynos5420-peach-pit.dts | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
arch/arm/boot/dts/exynos5420-peach-pit.dts +34 -0
@@ -101,6 +101,40 @@ }; }; +&adc { + status = "okay"; + vdd-supply = <&ldo9_reg>; + + ncp15wb473 at 3 { + compatible = "murata,ncp15wb473"; + pullup-uv = <1800000>; + pullup-ohm = <47000>; + pulldown-ohm = <0>; + io-channels = <&adc 3>; + }; + ncp15wb473 at 4 { + compatible = "murata,ncp15wb473"; + pullup-uv = <1800000>; + pullup-ohm = <47000>; + pulldown-ohm = <0>; + io-channels = <&adc 4>; + }; + ncp15wb473 at 5 { + compatible = "murata,ncp15wb473"; + pullup-uv = <1800000>; + pullup-ohm = <47000>; + pulldown-ohm = <0>; + io-channels = <&adc 5>; + }; + ncp15wb473 at 6 { + compatible = "murata,ncp15wb473"; + pullup-uv = <1800000>; + pullup-ohm = <47000>; + pulldown-ohm = <0>; + io-channels = <&adc 6>; + }; +}; + &dp { status = "okay"; pinctrl-names = "default";
Signature · 1 line
1.7.9.5
PATCH v2 4/4 ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
Hello Naveen,
Quoted 78 lines · Naveen Krishna Chatradhi
Exynos5420 based Peach PIT board has 4 NTC thermistors to measure temperatures at various points on the board.
IIO based ADC becomes the parent and NTC thermistors are the childs, via the HWMON interface.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Doug Anderson <[email protected]>---
Changes since v1:
1. Arranged the ADC node alphabetical
2. Added "status = "okay"" to the ADC nodeThis patch needs
1. MAX77802 PMIC device tree nodes (for ldo9)
https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
2. Uses the DT documentation for NTC thermistors updated with vendor-prefixThis patch set is tested
1. On Peach PIT board via sysfs entry exposed by hwmon localhost ~ # cat/sys/class/hwmon/hwmon*/device/temp1_input37436
36449
38560
380592. Backward compatibility is tested by replacing "murata" with "ntc" in the dts nodes and running the above test.
arch/arm/boot/dts/exynos5420-peach-pit.dts | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)arch/arm/boot/dts/exynos5420-peach-pit.dts +34
-1@@ -101,6 +101,40 @@ }; }; +&adc { + status = "okay"; + vdd-supply = <&ldo9_reg>; + + ncp15wb473 at 3 { + compatible = "murata,ncp15wb473"; + pullup-uv = <1800000>; + pullup-ohm = <47000>; + pulldown-ohm = <0>; + io-channels = <&adc 3>; + }; + ncp15wb473 at 4 { + compatible = "murata,ncp15wb473"; + pullup-uv = <1800000>; + pullup-ohm = <47000>; + pulldown-ohm = <0>; + io-channels = <&adc 4>; + }; + ncp15wb473 at 5 { + compatible = "murata,ncp15wb473"; + pullup-uv = <1800000>; + pullup-ohm = <47000>; + pulldown-ohm = <0>; + io-channels = <&adc 5>; + }; + ncp15wb473 at 6 { + compatible = "murata,ncp15wb473"; + pullup-uv = <1800000>; + pullup-ohm = <47000>; + pulldown-ohm = <0>; + io-channels = <&adc 6>; + }; +}; + &dp { status = "okay"; pinctrl-names = "default"; --
Quoted 2 lines
1.7.9.5
PATCH v2 4/4 ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
In reply to Naveen Krishna ChatradhiNaveen,
Quoted 26 lines · Naveen Krishna Chatradhi
Exynos5420 based Peach PIT board has 4 NTC thermistors to measure temperatures at various points on the board.
IIO based ADC becomes the parent and NTC thermistors are the childs, via the HWMON interface.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Doug Anderson <[email protected]>---
Changes since v1:
1. Arranged the ADC node alphabetical
2. Added "status = "okay"" to the ADC nodeThis patch needs
1. MAX77802 PMIC device tree nodes (for ldo9)
https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
2. Uses the DT documentation for NTC thermistors updated with vendor-prefixThis patch set is tested
1. On Peach PIT board via sysfs entry exposed by hwmon localhost ~ # cat/sys/class/hwmon/hwmon*/device/temp1_input37436
36449
38560
38059
Quoted 5 lines
2. Backward compatibility is tested by replacing "murata" with "ntc" in the dts nodes and running the above test.
arch/arm/boot/dts/exynos5420-peach-pit.dts | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
Now that Javier has spun his patch, perhaps you can fold the "pi" version in here too?
PATCH v2 4/4 ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
Doug,
Quoted 30 lines · Doug Anderson
Naveen,
Quoted 26 lines · Naveen Krishna Chatradhi
Exynos5420 based Peach PIT board has 4 NTC thermistors to measure temperatures at various points on the board.
IIO based ADC becomes the parent and NTC thermistors are the childs, via the HWMON interface.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Doug Anderson <[email protected]>---
Changes since v1:
1. Arranged the ADC node alphabetical
2. Added "status = "okay"" to the ADC nodeThis patch needs
1. MAX77802 PMIC device tree nodes (for ldo9)
https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
2. Uses the DT documentation for NTC thermistors updated with vendor-prefixThis patch set is tested
1. On Peach PIT board via sysfs entry exposed by hwmon localhost ~ # cat/sys/class/hwmon/hwmon*/device/temp1_input37436
36449
38560
38059
Quoted 8 lines
Quoted 5 lines
2. Backward compatibility is tested by replacing "murata" with "ntc" in the dts nodes and running the above test.
arch/arm/boot/dts/exynos5420-peach-pit.dts | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)Now that Javier has spun his patch, perhaps you can fold the "pi" version in here too?
Sure, thanks for the information.
Snow also needs the adc nodes.
Will try to implement an adc fragment for PIT, PI and Snow.
Quoted 3 lines
Reviewed-by Doug Anderson <[email protected]>Tested-by Doug Anderson <[email protected]>
Signature · 2 lines
Shine bright, (: Nav :)
PATCH v2 4/4 ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
Hello Doug, Kukjin,
Quoted 39 lines · Naveen Krishna Ch
Doug,
Quoted 36 lines · Doug Anderson
Naveen,
Quoted 31 lines · Naveen Krishna Chatradhi
Exynos5420 based Peach PIT board has 4 NTC thermistors to measure temperatures at various points on the board.
IIO based ADC becomes the parent and NTC thermistors are the childs, via the HWMON interface.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Doug Anderson <[email protected]>---
Changes since v1:
1. Arranged the ADC node alphabetical
2. Added "status = "okay"" to the ADC nodeThis patch needs
1. MAX77802 PMIC device tree nodes (for ldo9)
https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
2. Uses the DT documentation for NTC thermistors updated with vendor-prefixThis patch set is tested
1. On Peach PIT board via sysfs entry exposed by hwmon localhost ~ # cat/sys/class/hwmon/hwmon*/device/temp1_input37436
36449
38560
380592. Backward compatibility is tested by replacing "murata" with "ntc" in the dts nodes and running the above test.
arch/arm/boot/dts/exynos5420-peach-pit.dts | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
Quoted 7 lines
Quoted 2 lines
Now that Javier has spun his patch, perhaps you can fold the "pi" version in here too?
Sure, thanks for the information.
Snow also needs the adc nodes.
Will try to implement an adc fragment for PIT, PI and Snow.
I just found out https://lkml.org/lkml/2013/3/27/453
Adding ADC based Thermistor nodes to Exynos5250-snow.dts din't make it in.
Quoted 10 lines
Quoted 4 lines
Reviewed-by Doug Anderson <[email protected]>Tested-by Doug Anderson <[email protected]>--
Shine bright,
(: Nav :)
Signature · 2 lines
Shine bright, (: Nav :)
PATCH v2 4/4 ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
In reply to Naveen Krishna ChHello Kukjin,
Quoted 39 lines · Naveen Krishna Ch
Doug,
Quoted 36 lines · Doug Anderson
Naveen,
Quoted 31 lines · Naveen Krishna Chatradhi
Exynos5420 based Peach PIT board has 4 NTC thermistors to measure temperatures at various points on the board.
IIO based ADC becomes the parent and NTC thermistors are the childs, via the HWMON interface.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>Cc Doug Anderson <[email protected]>---
Changes since v1:
1. Arranged the ADC node alphabetical
2. Added "status = "okay"" to the ADC nodeThis patch needs
1. MAX77802 PMIC device tree nodes (for ldo9)
https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
2. Uses the DT documentation for NTC thermistors updated with vendor-prefixThis patch set is tested
1. On Peach PIT board via sysfs entry exposed by hwmon localhost ~ # cat/sys/class/hwmon/hwmon*/device/temp1_input37436
36449
38560
380592. Backward compatibility is tested by replacing "murata" with "ntc" in the dts nodes and running the above test.
arch/arm/boot/dts/exynos5420-peach-pit.dts | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
Quoted 7 lines
Quoted 2 lines
Now that Javier has spun his patch, perhaps you can fold the "pi" version in here too?
Sure, thanks for the information.
Snow also needs the adc nodes.
Will try to implement an adc fragment for PIT, PI and Snow.
I've a plan to create a common file (cros-exynos-peach.dts) for exynos5420-peach-pit.dts and exynos5800-peach-pi.dts And add the ADC nodes directly into that.
In favor of the above, can you abandon the following patches
1. [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
http://www.spinics.net/lists/linux-samsung-soc/msg33037.html
2. [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
http://www.spinics.net/lists/linux-samsung-soc/msg33038.html
Quoted 10 lines
Quoted 4 lines
Reviewed-by Doug Anderson <[email protected]>Tested-by Doug Anderson <[email protected]>--
Shine bright,
(: Nav :)
Signature · 2 lines
Thanks, (: Nav :)
v2 cover hwmon: ntc_thermistor: prepose vendor prefix change
In reply to Naveen Krishna ChatradhiQuoted 1 line · Naveen Krishna Chatradhi
+ Jean Delvare, Guenter Roeck
I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.
Hi,
This series looks good to me. I will take 3/4 and 4/4 for exynos DT changes once hwmon/ntc maintainer pick the others.
Thanks,
Kukjin
Quoted 29 lines
As Murata is the manufacturer of the NTC (Negative Temperature coefficient) based Thermistors.
ntc_thermistordriver extensively used the prefix "ntc". But, vendor-prefix should be "murata" instead of "ntc".This patchset
1. Updates the vendor-prefix, DT bindings and Documentation, where ever necessary.
2. Adds thermistor nodes to Exynos5420 based Peach PIT board.Patches:
1/4. devicetree: bindings: Document murata vendor prefix
Adds the vendor prefix "murata" to vendor-prefixes.txt.
2/4. hwmon:ntc_thermistor: Use the manufacturer name properly
Updates the driver,Kconfig, device tree bindings and Documentation with the Manufacturer/vendor information.
Keeps the old bindings marked as <DEPRECATED> in code and Documentation
3/4. ARM: DTS: use new compatible string as per the documentation
Updates the device node in Exynos4412 based Trats2 board with the new device tree bindings.
4/4. ARM: DTS: Add NTC thermistor nodes as child nodes to ADC
Adds Thermistor nodes to Exynos5420 based Peach PIT board.This patchset
Naveen Krishna Chatradhi (4):
devicetree: bindings: Document murata vendor prefix
hwmon:ntc_thermistor: Use the manufacturer name properly
ARM: DTS: use new compatible string as per the documentation
ARM: DTS: Add NTC thermistor nodes to Exynos5420 basedPeach_PIT
Quoted 6 lines
.../devicetree/bindings/arm/samsung/exynos-adc.txt | 2 +- .../devicetree/bindings/hwmon/ntc_thermistor.txt | 20 ++++++++---- .../devicetree/bindings/vendor-prefixes.txt | 1 + Documentation/hwmon/ntc_thermistor | 8 ++--- arch/arm/boot/dts/exynos4412-trats2.dts | 4 +-- arch/arm/boot/dts/exynos5420-peach-pit.dts | 34
++++++++++++++++++++
Quoted 6 lines
drivers/hwmon/Kconfig | 5 +-- drivers/hwmon/ntc_thermistor.c | 14 +++++++- 8 files changed, 72 insertions(+), 16 deletions(-)--
1.7.9.5
Guenter Roeck
maintainerv2 cover hwmon: ntc_thermistor: prepose vendor prefix change
Quoted 11 lines · Kukjin Kim
Quoted 1 line · Naveen Krishna Chatradhi
+ Jean Delvare, Guenter Roeck
I'm adding maintainers for
drivers/hwmon/ntc*but I'm not sure.Hi,
This series looks good to me. I will take 3/4 and 4/4 for exynos DT changes once hwmon/ntc maintainer pick the others.
I applied both patches. Currently going through my test cycle. I'll send them to Linus Thursday or Friday.
Guenter
v2 cover hwmon: ntc_thermistor: prepose vendor prefix change
Hello Kukjin,
Quoted 11 lines · Guenter Roeck
Quoted 10 lines · Kukjin Kim
Quoted 2 lines · Naveen Krishna Chatradhi
+ Jean Delvare, Guenter Roeck
I'm adding maintainers for
drivers/hwmon/ntc*but I'm not sure.Hi,
Quoted 7 lines
Quoted 4 lines
This series looks good to me. I will take 3/4 and 4/4 for exynos DT changes once
hwmon/ntc maintainer pick the others.I applied both patches. Currently going through my test cycle. I'll send them to Linus Thursday or Friday.
I see the 1/4 and 2/4 merged in togreg branch of
http://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
Can you pull the 3/4 and 4/4 patches.
Quoted 3 lines
Guenter
Signature · 2 lines
Regards, (: Naveen :)
v2 cover hwmon: ntc_thermistor: prepose vendor prefix change
Hello Naveen,
Quoted 3 lines · Naveen Krishna Ch
Can you pull the 3/4 and 4/4 patches.
Patch 4/4 depends on the max77802 support series [0] since the ADC uses the max77802 ldo9 regulator as its voltage supply. So that patch can't be merged before the series land in mainline.
Best regards,
Javier