Skip to contentSkip to conversation

Seeking correct git repo

PATCH Applied Derek Simkowiak 4 participants 6 messages Jun 25, 2014 – Jul 8, 2014 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

Hello,
A while ago, Romain wrote a small eMMC 5.0 patch that Ulf ack'd:

http://comments.gmane.org/gmane.linux.kernel.mmc/23795

I need this patch for my hardware. But I don't see this patch in Linux stable (even though there are more recent patches from Seungwon Jeon in there), and I don't see it at the MMC repo either:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git

# Where's the patch? I checked all branches...

$ git branch -a
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
  remotes/origin/mmc-next
  remotes/origin/mmc-updates-for-3.16-rc1-merged

Can you please tell me, what is the repo and branch where this patch was submitted? The only reference I have to this patch is the email archive at the URL above.

Thank You,
Derek

#1 lore raw

I have the same question too.

I think we can't get a patch from Linux stable, which isn't accepted by community.

I used a hard way to get a relative patch which i want by copy source code from URL and recompile...

Best Regards,
Hsinhsiang

2014-06-26 3:28 GMT+08:00 Derek Simkowiak <[email protected]>:

Quoted 33 lines

Hello,
A while ago, Romain wrote a small eMMC 5.0 patch that Ulf ack'd:

http://comments.gmane.org/gmane.linux.kernel.mmc/23795

I need this patch for my hardware. But I don't see this patch in Linux stable (even though there are more recent patches from Seungwon Jeon in there), and I don't see it at the MMC repo either:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git

# Where's the patch? I checked all branches...

$ git branch -a
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
  remotes/origin/mmc-next
  remotes/origin/mmc-updates-for-3.16-rc1-merged

Can you please tell me, what is the repo and branch where this patch was submitted? The only reference I have to this patch is the email archive at the URL above.

Thank You,
Derek

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
In reply to Derek Simkowiak
Quoted 23 lines · Derek Simkowiak

Hello,
A while ago, Romain wrote a small eMMC 5.0 patch that Ulf ack'd:

http://comments.gmane.org/gmane.linux.kernel.mmc/23795

I need this patch for my hardware. But I don't see this patch in Linux

stable (even though there are more recent patches from Seungwon Jeon in

there), and I don't see it at the MMC repo either:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git

# Where's the patch? I checked all branches...

$ git branch -a
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
  remotes/origin/mmc-next
  remotes/origin/mmc-updates-for-3.16-rc1-merged
Quoted 5 lines

Can you please tell me, what is the repo and branch where this patch was
submitted? The only reference I have to this patch is the email archive
at the URL above.

Seems like it was missed. That could happen, then you should either send a ping or resend the patch.

Kind regards
Uffe

Quoted 9 lines

Thank You,
Derek

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

Uffe,
Thank you for your prompt response.

Quoted 1 line

///you should either send a ping or resend the patch./

I am happy to copy'n'paste the patch from the URL (below) and resend it to this list.

However, my understanding is that the email header "from " or "From:" lines are used to track authorship in the CONTRIBUTORS file. I don't want to receive credit for Romain's work by re-sending his patch. Is there a way for me to re-submit the patch on Romain's behalf? (I have also CC:'d Romain, so he can resubmit it directly.)

I can verify that this patch is necessary to make Jedec 5.0 hardware work. It should get into linux-stable as soon as possible, so that Linux can support newer eMMC hardware.

Thank You,
Derek

Quoted 40 lines · Ulf Hansson
Quoted 23 lines · Derek Simkowiak

Hello,
A while ago, Romain wrote a small eMMC 5.0 patch that Ulf ack'd:

http://comments.gmane.org/gmane.linux.kernel.mmc/23795

I need this patch for my hardware. But I don't see this patch in Linux

stable (even though there are more recent patches from Seungwon Jeon in

there), and I don't see it at the MMC repo either:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git

# Where's the patch? I checked all branches...

$ git branch -a
* master
   remotes/origin/HEAD -> origin/master
   remotes/origin/master
   remotes/origin/mmc-next
   remotes/origin/mmc-updates-for-3.16-rc1-merged
Quoted 5 lines

Can you please tell me, what is the repo and branch where this patch was
submitted? The only reference I have to this patch is the email archive
at the URL above.

Seems like it was missed. That could happen, then you should either send a ping or resend the patch.

Kind regards
Uffe

Quoted 7 lines

Thank You,
Derek

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message [email protected]
More majordomo info athttp://vger.kernel.org/majordomo-info.html

#4 lore raw

PATCH v2 1/1 mmc: Allow forward compatibility for e⋅MMC

As stated by the e⋅MMC 5.0 specification, a chip should not be rejected only because of the revision stated in the EXT_CSD_REV field of the EXT_CSD register.

Remove the control on this value, the control of the CSD_STRUCTURE field should be sufficient to reject future incompatible changes.

---
 drivers/mmc/core/mmc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/mmc/core/mmc.c +5 -6
index 1ab5f3a0af5b..ac9b8232133c 100644
@@ -293,13 +293,12 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
 		}
 	}
 
+	/*
+	 * The EXT_CSD format is meant to be forward compatible. As long
+	 * as CSD_STRUCTURE does not change, all values for EXT_CSD_REV
+	 * are authorized, see JEDEC JESD84-B50 section B.8.
+	 */
 	card->ext_csd.rev = ext_csd[EXT_CSD_REV];
-	if (card->ext_csd.rev > 7) {
-		pr_err("%s: unrecognised EXT_CSD revision %d\n",
-			mmc_hostname(card->host), card->ext_csd.rev);
-		err = -EINVAL;
-		goto out;
-	}
 
 	card->ext_csd.raw_sectors[0] = ext_csd[EXT_CSD_SEC_CNT + 0];
 	card->ext_csd.raw_sectors[1] = ext_csd[EXT_CSD_SEC_CNT + 1];
Signature · 1 line
1.9.1
Applied
#5 lore raw

Re: [PATCH v2] mmc: Allow forward compatibility for e⋅MMC

Quoted 9 lines · Romain Izard

As stated by the e⋅MMC 5.0 specification, a chip should not be rejected only because of the revision stated in the EXT_CSD_REV field of the EXT_CSD register.

Remove the control on this value, the control of the CSD_STRUCTURE field should be sufficient to reject future incompatible changes.

Thanks! Applied for next.

Kind regards
Uffe

Quoted 30 lines
---
 drivers/mmc/core/mmc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/mmc/core/mmc.c +5 -7
index 1ab5f3a0af5b..ac9b8232133c 100644
@@ -293,13 +293,12 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
                }
        }
 
+       /*
+        * The EXT_CSD format is meant to be forward compatible. As long
+        * as CSD_STRUCTURE does not change, all values for EXT_CSD_REV
+        * are authorized, see JEDEC JESD84-B50 section B.8.
+        */
        card->ext_csd.rev = ext_csd[EXT_CSD_REV];
-       if (card->ext_csd.rev > 7) {
-               pr_err("%s: unrecognised EXT_CSD revision %d\n",
-                       mmc_hostname(card->host), card->ext_csd.rev);
-               err = -EINVAL;
-               goto out;
-       }
 
        card->ext_csd.raw_sectors[0] = ext_csd[EXT_CSD_SEC_CNT + 0];
        card->ext_csd.raw_sectors[1] = ext_csd[EXT_CSD_SEC_CNT + 1];
--

1.9.1