Skip to contentSkip to conversation

b43: treat LCNXN-PHY as extra N-PHY devices

PATCH New Rafał Miłecki 2 participants 4 messages Jun 29, 2014 – Jul 1, 2014 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: treat LCNXN-PHY as extra N-PHY devices

LCNXN is simply a continuation of N, e.g. code handling LCNXN revs 0 and 1 is mostly the same as for N-PHY revs 7+.

---
 drivers/net/wireless/b43/main.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/wireless/b43/main.c +7 -0
index 3e4333c..0b1aac4 100644
@@ -4331,6 +4331,13 @@ static int b43_phy_versioning(struct b43_wldev *dev)
 	analog_type = (tmp & B43_PHYVER_ANALOG) >> B43_PHYVER_ANALOG_SHIFT;
 	phy_type = (tmp & B43_PHYVER_TYPE) >> B43_PHYVER_TYPE_SHIFT;
 	phy_rev = (tmp & B43_PHYVER_VERSION);
+
+	/* LCNXN is continuation of N which run out of revisions */
+	if (phy_type == B43_PHYTYPE_LCNXN) {
+		phy_type = B43_PHYTYPE_N;
+		phy_rev += 16;
+	}
+
 	switch (phy_type) {
 #ifdef CONFIG_B43_PHY_G
 	case B43_PHYTYPE_G:
Signature · 1 line
1.8.4.5
#1 lore raw

PATCH 1/1 b43: treat LCNXN-PHY as extra N-PHY devices

Quoted 2 lines · Rafa? Mi?ecki

LCNXN is simply a continuation of N, e.g. code handling LCNXN revs 0 and 1 is mostly the same as for N-PHY revs 7+.

Hi Rafa?,

LCNXN is actually a LCN phy with 2 streams (mimo).

Regards,
Arend

Quoted 24 lines
---
 drivers/net/wireless/b43/main.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/wireless/b43/main.c +7 -0
index 3e4333c..0b1aac4 100644
@@ -4331,6 +4331,13 @@ static int b43_phy_versioning(struct b43_wldev *dev)
 	analog_type = (tmp & B43_PHYVER_ANALOG) >> B43_PHYVER_ANALOG_SHIFT;
 	phy_type = (tmp & B43_PHYVER_TYPE) >> B43_PHYVER_TYPE_SHIFT;
 	phy_rev = (tmp & B43_PHYVER_VERSION);
+
+	/* LCNXN is continuation of N which run out of revisions */
+	if (phy_type == B43_PHYTYPE_LCNXN) {
+		phy_type = B43_PHYTYPE_N;
+		phy_rev += 16;
+	}
+
 	switch (phy_type) {
 #ifdef CONFIG_B43_PHY_G
 	case B43_PHYTYPE_G:
#2 lore raw

PATCH 1/1 b43: treat LCNXN-PHY as extra N-PHY devices

Quoted 7 lines · Arend van Spriel
Quoted 2 lines · Rafa? Mi?ecki

LCNXN is simply a continuation of N, e.g. code handling LCNXN revs 0 and 1 is mostly the same as for N-PHY revs 7+.

Hi Rafa?,

LCNXN is actually a LCN phy with 2 streams (mimo).

Err, I don't think so. Could you take a closer look at this? I'm pretty sure LCNXN is continuation of N.

Maybe you were thinking about LCN40? I don't know much about LCN40, maybe it's a variation of LCN?

#3 lore raw

PATCH 1/1 b43: treat LCNXN-PHY as extra N-PHY devices

Quoted 11 lines · Rafa? Mi?ecki
Quoted 7 lines · Arend van Spriel
Quoted 2 lines · Rafa? Mi?ecki

LCNXN is simply a continuation of N, e.g. code handling LCNXN revs 0 and 1 is mostly the same as for N-PHY revs 7+.

Hi Rafa?,

LCNXN is actually a LCN phy with 2 streams (mimo).

Err, I don't think so. Could you take a closer look at this? I'm pretty sure LCNXN is continuation of N.

You got me. I taken a closer look. It seems to stand for e'x'tended n. There was separate phy code for it, but in recent code it seems to be handled by n phy code. So you are right.

Quoted 2 lines

Maybe you were thinking about LCN40? I don't know much about LCN40, maybe it's a variation of LCN?

Probably.

Gr. AvS