Skip to contentSkip to conversation

binutils: Use the default version by default

PATCH Superseded Vicente Olivert Riera 3 participants 4 messages Jul 2, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 binutils: Use the default version by default

---
 package/binutils/Config.in.host |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
package/binutils/Config.in.host +1 -1
index 08540a3..bc21f5e 100644
@@ -3,7 +3,7 @@ comment "Binutils Options"
 choice
 	prompt "Binutils Version"
 	depends on !BR2_arc
-	default BR2_BINUTILS_VERSION_2_21 if (BR2_mips || BR2_mipsel || BR2_sh)
+	default BR2_BINUTILS_VERSION_2_21 if BR2_sh
 	default BR2_BINUTILS_VERSION_2_24 if BR2_microblaze || BR2_powerpc64le
 	default BR2_BINUTILS_VERSION_2_22
 	help
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 binutils: Use the default version by default

Hi Vicente,

Quoted 2 lines · Vicente Olivert Riera

Subject should mention that this commit only affects MIPS.

baruch

Quoted 17 lines
---
 package/binutils/Config.in.host |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
package/binutils/Config.in.host +1 -1
index 08540a3..bc21f5e 100644
@@ -3,7 +3,7 @@ comment "Binutils Options"
 choice
 	prompt "Binutils Version"
 	depends on !BR2_arc
-	default BR2_BINUTILS_VERSION_2_21 if (BR2_mips || BR2_mipsel || BR2_sh)
+	default BR2_BINUTILS_VERSION_2_21 if BR2_sh
 	default BR2_BINUTILS_VERSION_2_24 if BR2_microblaze || BR2_powerpc64le
 	default BR2_BINUTILS_VERSION_2_22
 	help
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 binutils: Use the default version by default

In reply to Vicente Olivert Riera
Quoted 3 lines · Vicente Olivert Riera

---

Hi Vincent,

The title (or the commit message) could have been a little more accurate now that I read it again. Your change changes the default version for MIPS so the commit message should have been clearer. Perhaps

"Use the default version on MIPS"

Signature · 1 line
markos
#3 lore raw

PATCH 1/1 binutils: Use the default version by default

On 07/02/2014 10:36 AM, Baruch Siach wrote:> Hi Vicente,

Quoted 8 lines · Vicente Olivert Riera
Quoted 2 lines
Quoted 2 lines

Subject should mention that this commit only affects MIPS.

baruch

Quoted 5 lines · Markos Chandras
Quoted 3 lines · Vicente Olivert Riera

---

Quoted 8 lines

Hi Vincent,

The title (or the commit message) could have been a little more accurate now that I read it again. Your change changes the default version for MIPS so the commit message should have been clearer. Perhaps

"Use the default version on MIPS"

Yeah, I realized about that few seconds after sending the patch. The v2 patch has been already sent.

Signature · 1 line
Vincent