Skip to contentSkip to conversation

kirkwood: define empty CONFIG_MVGBE_PORTS by default

PATCH New Luka Perkov 4 participants 4 messages Jul 2, 2014 – Jul 14, 2014 Network drivers

lore
Share & tools
lore

Luka Perkov

author
#0 lore raw

PATCH 1/1 kirkwood: define empty CONFIG_MVGBE_PORTS by default

Each board with defines it's own set of values. If we do not define CONFIG_MVGBE_PORTS we will hit following error:

mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:700:34: error: 'CONFIG_MVGBE_PORTS' undeclared (first use in this function)
u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS;

This patch fixes above described problem.

Signed-off-by Luka Perkov <[email protected]>
CC Prafulla Wadaskar <[email protected]>
CC Stefan Roese <[email protected]>
---
 drivers/net/mvgbe.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/mvgbe.c +4 -0
index 0cd06b6..d558f59 100644
@@ -35,6 +35,10 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#ifndef CONFIG_MVGBE_PORTS
+# define CONFIG_MVGBE_PORTS {0, 0}
+#endif
+
 #define MV_PHY_ADR_REQUEST 0xee
 #define MVGBE_SMI_REG (((struct mvgbe_registers *)MVGBE0_BASE)->smi)
Signature · 1 line
2.0.1
#1 lore raw

PATCH 1/1 kirkwood: define empty CONFIG_MVGBE_PORTS by default

Quoted 7 lines · Luka Perkov

Each board with defines it's own set of values. If we do not define CONFIG_MVGBE_PORTS we will hit following error:

mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:700:34: error: 'CONFIG_MVGBE_PORTS' undeclared (first use in this function)
u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS;

Quoted 5 lines

This patch fixes above described problem.

Signed-off-by Luka Perkov <[email protected]>
CC Prafulla Wadaskar <[email protected]>
CC Stefan Roese <[email protected]>
Acked-by Stefan Roese <[email protected]>

Thanks,
Stefan

#2 lore raw

PATCH 1/1 kirkwood: define empty CONFIG_MVGBE_PORTS by default

In reply to Luka Perkov
Quoted 34 lines

-----Original Message-----
From: Luka Perkov [mailto:luka at openwrt.org]
Sent: 02 July 2014 05:48
To: u-boot at lists.denx.de
Cc: luka at openwrt.org; Prafulla Wadaskar; Stefan Roese
Subject: [PATCH] kirkwood: define empty CONFIG_MVGBE_PORTS by default

Each board with defines it's own set of values. If we do not define
CONFIG_MVGBE_PORTS we will hit following error:

mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:700:34: error: 'CONFIG_MVGBE_PORTS' undeclared (first use in this function)
u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS;

This patch fixes above described problem.

Signed-off-by Luka Perkov <[email protected]>
CC Prafulla Wadaskar <[email protected]>
CC Stefan Roese <[email protected]>
---
 drivers/net/mvgbe.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/mvgbe.c +0 -0
index 0cd06b6..d558f59 100644

drivers/net/mvgbe.c line 44

Quoted 10 lines
drivers/net/mvgbe.c +4 -0
@@ -35,6 +35,10 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#ifndef CONFIG_MVGBE_PORTS
+# define CONFIG_MVGBE_PORTS {0, 0}
+#endif
+
 #define MV_PHY_ADR_REQUEST 0xee
 #define MVGBE_SMI_REG (((struct mvgbe_registers
 *)MVGBE0_BASE)->smi)

This is generic to network driver, to be picked up by net custodian..

+Joe

Acked-by Prafulla Wadaskar <[email protected]>

Regards...
Prafulla . . .

#3 lore raw

PATCH 1/1 kirkwood: define empty CONFIG_MVGBE_PORTS by default

Quoted 47 lines · Prafulla Wadaskar
Quoted 34 lines

-----Original Message-----
From: Luka Perkov [mailto:luka at openwrt.org]
Sent: 02 July 2014 05:48
To: u-boot at lists.denx.de
Cc: luka at openwrt.org; Prafulla Wadaskar; Stefan Roese
Subject: [PATCH] kirkwood: define empty CONFIG_MVGBE_PORTS by default

Each board with defines it's own set of values. If we do not define
CONFIG_MVGBE_PORTS we will hit following error:

mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:700:34: error: 'CONFIG_MVGBE_PORTS' undeclared (first use in this function)
u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS;

This patch fixes above described problem.

Signed-off-by Luka Perkov <[email protected]>
CC Prafulla Wadaskar <[email protected]>
CC Stefan Roese <[email protected]>
---
 drivers/net/mvgbe.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/mvgbe.c +0 -0
index 0cd06b6..d558f59 100644

drivers/net/mvgbe.c line 44

Quoted 10 lines
drivers/net/mvgbe.c +4 -0
@@ -35,6 +35,10 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#ifndef CONFIG_MVGBE_PORTS
+# define CONFIG_MVGBE_PORTS {0, 0}
+#endif
+
 #define MV_PHY_ADR_REQUEST 0xee
 #define MVGBE_SMI_REG (((struct mvgbe_registers
 *)MVGBE0_BASE)->smi)

This is generic to network driver, to be picked up by net custodian..

Quoted 4 lines

+Joe

Acked-by Prafulla Wadaskar <[email protected]>

It's in the marvell driver so please just pick it up, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140714/c8fe8ee0/attachment.pgp>