Skip to contentSkip to conversation

ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig

PATCH New Simon Horman 4 participants 5 messages Jul 7, 2014 – Jul 9, 2014

Subsystems (3)
Arm (32-bit) SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Simon Horman

author
#0 lore raw

PATCH 1/1 ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig

The R-Car Gen 2 PCIe driver provides PCIe host support for Renesas R-Car Gen2 platforms. To increase hardware support enable the driver in the shmobile_defconfig multiplatform configuration.

Cc Phil Edworthy <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/shmobile_defconfig +1 -0
index 5f05e98..6bc85a5 100644
@@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
 CONFIG_ARM_ERRATA_754322=y
 CONFIG_PCI=y
 CONFIG_PCI_RCAR_GEN2=y
+CONFIG_PCI_RCAR_GEN2_PCIE=y
 CONFIG_SMP=y
 CONFIG_SCHED_MC=y
 CONFIG_HAVE_ARM_ARCH_TIMER=y
Signature · 1 line
2.0.0.rc2
#1 lore raw

PATCH 1/1 ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig

Hello.

Quoted 15 lines · Simon Horman

The R-Car Gen 2 PCIe driver provides PCIe host support for Renesas R-Car Gen2 platforms. To increase hardware support enable the driver in the shmobile_defconfig multiplatform configuration.

Cc Phil Edworthy <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
  arch/arm/configs/shmobile_defconfig | 1 +
  1 file changed, 1 insertion(+)
arch/arm/configs/shmobile_defconfig +0 -0
index 5f05e98..6bc85a5 100644

arch/arm/configs/shmobile_defconfig CONFIG_PL310_ERRATA_588369=y · line 27

Quoted 4 lines
arch/arm/configs/shmobile_defconfig +1 -0
@@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
  CONFIG_ARM_ERRATA_754322=y
  CONFIG_PCI=y
  CONFIG_PCI_RCAR_GEN2=y
+CONFIG_PCI_RCAR_GEN2_PCIE=y

Hmm, I'm not sure why the option has GEN2 -- the driver claims support for
R8A7779 as well as R8A779x. Probably the option should be renamed.

WBR, Sergei

#2 lore raw

PATCH 1/1 ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig

Hi Sergei

Quoted 14 lines · Sergei

Review

Quoted 11 lines · Simon Horman

The R-Car Gen 2 PCIe driver provides PCIe host support for Renesas R-Car Gen2 platforms. To increase hardware support enable the driver in the shmobile_defconfig multiplatform configuration.

Cc Phil Edworthy <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
  arch/arm/configs/shmobile_defconfig | 1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/arch/arm/configs/shmobile_defconfig

Quoted 11 lines

arch/arm/configs/shmobile_defconfig CONFIG_PL310_ERRATA_588369=y · line 27

Quoted 8 lines

index 5f05e98..6bc85a5 100644

arch/arm/configs/shmobile_defconfig +1 -0
@@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
  CONFIG_ARM_ERRATA_754322=y
  CONFIG_PCI=y
  CONFIG_PCI_RCAR_GEN2=y
+CONFIG_PCI_RCAR_GEN2_PCIE=y

Hmm, I'm not sure why the option has GEN2 -- the driver claims support for
R8A7779 as well as R8A779x. Probably the option should be renamed.

Technically, you are correct. However, whilst the driver does support R8A7779, that device only supports 32-bit accesses over the PCIe bus so it's only useful for custom cards, not off-the-shelf PCIe cards.

Phil

#3 lore raw

PATCH 1/1 ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig

Quoted 28 lines · Phil Edworthy

Hi Sergei

Quoted 14 lines · Sergei

Review

Quoted 11 lines · Simon Horman

The R-Car Gen 2 PCIe driver provides PCIe host support for Renesas R-Car Gen2 platforms. To increase hardware support enable the driver in the shmobile_defconfig multiplatform configuration.

Cc Phil Edworthy <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
  arch/arm/configs/shmobile_defconfig | 1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/arch/arm/configs/shmobile_defconfig

Quoted 11 lines

arch/arm/configs/shmobile_defconfig CONFIG_PL310_ERRATA_588369=y · line 27

Quoted 8 lines

index 5f05e98..6bc85a5 100644

arch/arm/configs/shmobile_defconfig +1 -0
@@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
  CONFIG_ARM_ERRATA_754322=y
  CONFIG_PCI=y
  CONFIG_PCI_RCAR_GEN2=y
+CONFIG_PCI_RCAR_GEN2_PCIE=y

Hmm, I'm not sure why the option has GEN2 -- the driver claims support for
R8A7779 as well as R8A779x. Probably the option should be renamed.

Quoted 2 lines

Technically, you are correct. However, whilst the driver does support R8A7779, that device only supports 32-bit accesses over the PCIe bus so it's only useful for custom cards, not off-the-shelf PCIe cards.

It seems to me that dropping GEN2 from the config option may be a good idea. But I believe that conversation is orthogonal to enabling the driver in the defconfig. At this stage I plan to apply this patch.

#4 lore raw

PATCH 1/1 ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig

Quoted 29 lines · Simon Horman
Quoted 28 lines · Phil Edworthy

Hi Sergei

Quoted 25 lines · Sergei

Review

Quoted 11 lines · Simon Horman

The R-Car Gen 2 PCIe driver provides PCIe host support for Renesas R-Car Gen2 platforms. To increase hardware support enable the driver in the shmobile_defconfig multiplatform configuration.

Cc Phil Edworthy <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
  arch/arm/configs/shmobile_defconfig | 1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/arch/arm/configs/shmobile_defconfig

arch/arm/configs/shmobile_defconfig CONFIG_PL310_ERRATA_588369=y · line 27

Quoted 8 lines

index 5f05e98..6bc85a5 100644

arch/arm/configs/shmobile_defconfig +1 -0
@@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
  CONFIG_ARM_ERRATA_754322=y
  CONFIG_PCI=y
  CONFIG_PCI_RCAR_GEN2=y
+CONFIG_PCI_RCAR_GEN2_PCIE=y

Hmm, I'm not sure why the option has GEN2 -- the driver claims support for
R8A7779 as well as R8A779x. Probably the option should be renamed.

Quoted 6 lines
Quoted 2 lines

Technically, you are correct. However, whilst the driver does support R8A7779, that device only supports 32-bit accesses over the PCIe bus so it's only useful for custom cards, not off-the-shelf PCIe cards.

It seems to me that dropping GEN2 from the config option may be a good idea. But I believe that conversation is orthogonal to enabling the driver in the defconfig. At this stage I plan to apply this patch.

I have queued up this change.