Skip to contentSkip to conversation

lxc: disable lua and python

PATCH New Gustavo Zacarias 2 participants 5 messages Jul 5, 2014 – Jul 7, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lxc: disable lua and python

Also conditionally disable bash if bash isn't built. Fixes:
http://autobuild.buildroot.net/results/8ea/8ea1d682706ba5fee27a64008bb7237d53120e9b/

---
 package/lxc/lxc.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/lxc/lxc.mk +3 -1
index b251b14..abb0a1b 100644
@@ -11,6 +11,8 @@ LXC_LICENSE_FILES = COPYING
 LXC_DEPENDENCIES = libcap host-pkgconf
 # configure not shipped
 LXC_AUTORECONF = YES
-LXC_CONF_OPT = --disable-apparmor --with-distro=buildroot
+LXC_CONF_OPT = --disable-apparmor --with-distro=buildroot \
+	--disable-lua --disable-python \
+	$(if $(BR2_PACKAGE_BASH),,--disable-bash)
 
 $(eval $(autotools-package))
Signature · 1 line
1.8.5.5
#1 lore raw

PATCH 1/1 lxc: disable lua and python

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Also conditionally disable bash if bash isn't built. Fixes:
http://autobuild.buildroot.net/results/8ea/8ea1d682706ba5fee27a64008bb7237d53120e9b/

Committed, thanks.

Any reason to not enable this support if lua/python is enabled?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 lxc: disable lua and python

Quoted 3 lines · Peter Korsgaard

Committed, thanks.

Any reason to not enable this support if lua/python is enabled?

Well, it breaks :)
Being an autotools package and sharing that with python infra is not straightforward, it would require patching to not build/install the python bits in the main build and doing so in separate steps with python workarounds/love - it's probably better to just make it an option in the python extensions menu as python-lxc.
And it didn't have that feature before, the bump being related to not building on a gentoo distro/chroot, the autobuilders just didn't pick it up because they're based on debian.
Regards.

#3 lore raw

PATCH 1/1 lxc: disable lua and python

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Quoted 3 lines · Peter Korsgaard

Committed, thanks.

Any reason to not enable this support if lua/python is enabled?

Quoted 9 lines

Well, it breaks :)
Being an autotools package and sharing that with python infra is not straightforward, it would require patching to not build/install the python bits in the main build and doing so in separate steps with python workarounds/love - it's probably better to just make it an option in the python extensions menu as python-lxc.
And it didn't have that feature before, the bump being related to not building on a gentoo distro/chroot, the autobuilders just didn't pick it up because they're based on debian.

Ok, thanks. It would be good to have that kind of info in the commit message.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 lxc: disable lua and python

Quoted 2 lines · Peter Korsgaard

Ok, thanks. It would be good to have that kind of info in the commit message.

There are other packages that do the same as well for the same reason, what would be interesting to know is how to handle it in general (examples: alsa-lib, avahi, libxml2, libxslt, cups, newt and a few more). One notable split package for this is thrift but it's a special case in that it bundles python-thrift but is really a separate package upstream. Regards.