Skip to contentSkip to conversation

mx6: soc: Update the comments of set_ldo_voltage()

PATCH New Fabio Estevam 2 participants 2 messages Jun 13, 2014 – Jul 9, 2014 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx6: soc: Update the comments of set_ldo_voltage()

From: Fabio Estevam <[email protected]>

Commit 3d622b78 (mx6: soc: Introduce set_ldo_voltage()) introduces set_ldo_voltage() function that can be used to set the voltages of any of the three LDO regulators controlled by the PMU_REG_CORE register.

Prior to this commit there was a single set_vddsoc() which only configured the VDDSOC regulator.

Update the comments to align with the new set_ldo_voltage() implementation.

---
 arch/arm/cpu/armv7/mx6/soc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm/cpu/armv7/mx6/soc.c +2 -3
index 1725279..f20bdeb 100644
@@ -124,10 +124,9 @@ static void clear_ldo_ramp(void)
 }
 
 /*
- * Set the VDDSOC
+ * Set the PMU_REG_CORE register
  *
- * Mask out the REG_CORE[22:18] bits (REG2_TRIG) and set
- * them to the specified millivolt level.
+ * Set LDO_SOC/PU/ARM regulators to the specified millivolt level.
  * Possible values are from 0.725V to 1.450V in steps of
  * 0.025V (25mV).
  */
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 mx6: soc: Update the comments of set_ldo_voltage()

Hi Fabio,

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Commit 3d622b78 (mx6: soc: Introduce set_ldo_voltage()) introduces set_ldo_voltage() function that can be used to set the voltages of any of the three LDO regulators controlled by the PMU_REG_CORE register.

Quoted 7 lines

Prior to this commit there was a single set_vddsoc() which only configured the VDDSOC regulator.

Update the comments to align with the new set_ldo_voltage() implementation.

---

Applied to u-boot-imx (fix), thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================