osm_subnet.c: Change default for perfmgr_query_cpi option

PATCH In review Hal Rosenstock 2 participants 2 messages Jul 11, 2014 – Jul 12, 2014 1 message not in the archive InfiniBand

lore

Share & tools

lore

Hal Rosenstock

author

2014-07-11 14:03 UTC #0 lore raw

PATCH 1/1 osm_subnet.c: Change default for perfmgr_query_cpi option

New default for PerfMgr query CPI is TRUE rather than FALSE. More admins need to use this and this was too often being missed during configuration so make admins turn this off rather than on (once enabling perfmgr itself).

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

opensm/osm_subnet.c +2 -2

index 1065408..26fe78c 100644
@@ -1564,7 +1564,7 @@ void osm_subn_set_default_opt(IN osm_subn_opt_t * p_opt)
 	p_opt->event_db_dump_file = NULL; /* use default */
 	p_opt->perfmgr_rm_nodes = TRUE;
 	p_opt->perfmgr_log_errors = TRUE;
-	p_opt->perfmgr_query_cpi = FALSE;
+	p_opt->perfmgr_query_cpi = TRUE;
 	p_opt->perfmgr_xmit_wait_log = FALSE;
 	p_opt->perfmgr_xmit_wait_threshold = OSM_PERFMGR_DEFAULT_XMIT_WAIT_THRESHOLD;
 #endif				/* ENABLE_OSM_PERF_MGR */

@@ -2645,7 +2645,7 @@ int osm_subn_output_conf(FILE *out, IN osm_subn_opt_t * p_opts)
 		"perfmgr_log_errors %s\n\n"
 		"# Query PerfMgt Get(ClassPortInfo) for extended capabilities\n"
 		"# Extended capabilities include 64 bit extended counters\n"
-		"# and transmit wait support (default FALSE)\n"
+		"# and transmit wait support (default TRUE)\n"
 		"perfmgr_query_cpi %s\n\n"
 		"# Log xmit_wait errors (default FALSE)\n"
 		"perfmgr_xmit_wait_log %s\n\n"

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 53BFEEA9.8020107-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Weiny, Ira

2014-07-12 14:54 UTC #2 lore raw

Quoted 8 lines

New default for PerfMgr query CPI is TRUE rather than FALSE. More admins need to use this and this was too often being missed during configuration so make admins turn this off rather than on (once enabling perfmgr itself).
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Signed-off-by Ira Weiny <[email protected]>

Quoted 21 lines

---

opensm/osm_subnet.c index renamed from opensm/osm_subnet.c +0 -0

1065408..26fe78c 100644

opensm/osm_subnet.c +1 -1

@@ -1564,7 +1564,7 @@ void osm_subn_set_default_opt(IN
 osm_subn_opt_t * p_opt)
 	p_opt->event_db_dump_file = NULL; /* use default */
 	p_opt->perfmgr_rm_nodes = TRUE;
 	p_opt->perfmgr_log_errors = TRUE;
-	p_opt->perfmgr_query_cpi = FALSE;
+	p_opt->perfmgr_query_cpi = TRUE;
 	p_opt->perfmgr_xmit_wait_log = FALSE;
 	p_opt->perfmgr_xmit_wait_threshold =

OSM_PERFMGR_DEFAULT_XMIT_WAIT_THRESHOLD;
#endif /* ENABLE_OSM_PERF_MGR */

opensm/osm_subnet.c +0 -0

@@ -2645,7 +2645,7 @@ int osm_subn_output_conf(FILE *out, IN
 osm_subn_opt_t * p_opts)
 		"perfmgr_log_errors %s\n\n"
 		"# Query PerfMgt Get(ClassPortInfo) for extended

capabilities\n"

opensm/osm_subnet.c int osm_subn_output_conf(FILE *out, IN osm_subn_opt_t * p_opts) · line 2651

Quoted 6 lines

opensm/osm_subnet.c +1 -1

 		"# Extended capabilities include 64 bit extended counters\n"
-		"# and transmit wait support (default FALSE)\n"
+		"# and transmit wait support (default TRUE)\n"
 		"perfmgr_query_cpi %s\n\n"
 		"# Log xmit_wait errors (default FALSE)\n"
 		"perfmgr_xmit_wait_log %s\n\n"

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html