Skip to contentSkip to conversation

xfs/291: use xfs_repair -f when repairing a fs image

PATCH New Eric Sandeen 1 participant 1 message Jul 12, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/291: use xfs_repair -f when repairing a fs image

test xfs/291 creates an xfs_metadump image and runs repair on it. Technically, this is supposed to require "-f" to specify that the target of the repair is a file; this allows buffered IO fallback in the case where the image sector size is smaller than the device sector size. And in fact if we create the image on a hard 4k device, the test will fail when repair is unable to operate on the image.

So add that -f!

---

tests/xfs/291 +1 -1
index 0f3f051..fbf9c51 100755
@@ -122,7 +122,7 @@ _xfs_check $SCRATCH_DEV >> $seqres.full 2>&1 || _fail "xfs_check failed"
 # Can xfs_metadump cope with this monster?
 _scratch_metadump $tmp.metadump || _fail "xfs_metadump failed"
 xfs_mdrestore $tmp.metadump $tmp.img || _fail "xfs_mdrestore failed"
-xfs_repair $tmp.img >> $seqres.full 2>&1 || _fail "xfs_repair of metadump failed"
+xfs_repair -f $tmp.img >> $seqres.full 2>&1 || _fail "xfs_repair of metadump failed"
 
 # Yes it can; success, all done
 status=0