perf: split package
cover perf: split package
The following changes since commit 1dcdd877c7946be4c0b1203deb14e2f842f9d0c2:
bitbake: toasterui: fix build - project identification (2014-07-14 14:10:03 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib chonglu/perf
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/perf
Chong Lu (1):
perf: split package
meta/recipes-kernel/perf/perf.bb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
1.9.1
PATCH 1/1 perf: split package
Fix incorrect paths to split perf package.
--- meta/recipes-kernel/perf/perf.bb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
meta/recipes-kernel/perf/perf.bb +4 -4
@@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}" FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent" FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug" -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python" -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" +FILES_${PN}-python = "${libdir}/python*/site-packages ${exec_prefix}/libexec/perf-core/scripts/python" +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl" INHIBIT_PACKAGE_DEBUG_SPLIT="1"
Signature · 1 line
1.9.1
Quoted 1 line · Chong Lu
Fix incorrect paths to split perf package.
Can you elaborate here ? This commit message doesn't really tell us much. Why is the current split incorrect ? What is the symptom and result of the incorrect split ? Are the package contents the same after this change ?
Bruce
Quoted 33 lines
Signed-off-by Chong Lu <[email protected]>--- meta/recipes-kernel/perf/perf.bb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)meta/recipes-kernel/perf/perf.bb +4
-5@@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}" FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent" FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug" -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python" -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" +FILES_${PN}-python = "${libdir}/python*/site-packages ${exec_prefix}/libexec/perf-core/scripts/python" +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl" INHIBIT_PACKAGE_DEBUG_SPLIT="1" --1.9.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Quoted 7 lines · Bruce Ashfield
Quoted 1 line · Chong Lu
Fix incorrect paths to split perf package.
Can you elaborate here ? This commit message doesn't really tell us much. Why is the current split incorrect ? What is the symptom and result of the incorrect split ? Are the package contents the same after this change ?
Bruce
Hi Bruce,
Currently, perf can't split to perf-archive, perf-tests, perf-python and perf-perl.
All files are included in perf package. For example, like perf-tests package:
It generates files in '${exec_prefix}/libexec/perf-core/tests', not in '${libdir}/perf/perf-core/tests'. So I change the files paths to make split successfully.
I will improve commit message and resend a V2.
Best Regards
Chong
Quoted 34 lines
Quoted 32 lines
Signed-off-by Chong Lu <[email protected]>--- meta/recipes-kernel/perf/perf.bb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)meta/recipes-kernel/perf/perf.bb +4
-5@@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}" FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent" FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug" -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python" -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" +FILES_${PN}-python = "${libdir}/python*/site-packages ${exec_prefix}/libexec/perf-core/scripts/python" +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl" INHIBIT_PACKAGE_DEBUG_SPLIT="1" --1.9.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 15 lines · Chong Lu
Quoted 10 lines · Bruce Ashfield
Quoted 2 lines · Chong Lu
Fix incorrect paths to split perf package.
Can you elaborate here ? This commit message doesn't really tell us much. Why is the current split incorrect ? What is the symptom and result of the incorrect split ? Are the package contents the same after this change ?
Bruce
Hi Bruce,
Quoted 7 lines
Currently, perf can't split to perf-archive, perf-tests, perf-python and perf-perl.
All files are included in perf package. For example, like perf-tests package:
It generates files in '${exec_prefix}/libexec/perf-core/tests', not in '${libdir}/perf/perf-core/tests'.
So I change the files paths to make split successfully.
But that means, whether or not we like it, anything using perf has been using those "non splits" and getting everything when perf is installed.
It's also might be in order to make the main perf package RDEPEND on the other three, to keep it consistent. Make it a ?= so it can be overridden, and then we can age it out over time.
Bruce
Quoted 47 lines
I will improve commit message and resend a V2.
Best Regards
ChongQuoted 40 lines
Quoted 37 lines
Signed-off-by Chong Lu <[email protected]>--- meta/recipes-kernel/perf/perf.bb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)meta/recipes-kernel/perf/perf.bb +0
-0@@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests${RSUGGESTS_SCRIPTING}"
FILES_${PN} += "${libexecdir}/perf-core
${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"meta/recipes-kernel/perf/perf.bb +0
-3-FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" -FILES_${PN}-python = "${libdir}/python*/site-packages${libdir}/perf/perf-core/scripts/python"
meta/recipes-kernel/perf/perf.bb +3
-1-FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" +FILES_${PN}-python = "${libdir}/python*/site-packages${exec_prefix}/libexec/perf-core/scripts/python" +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
INHIBIT_PACKAGE_DEBUG_SPLIT="1"
--
1.9.1--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Quoted 18 lines · Bruce Ashfield
Quoted 10 lines · Chong Lu
Quoted 7 lines · Bruce Ashfield
Quoted 1 line · Chong Lu
Fix incorrect paths to split perf package.
Can you elaborate here ? This commit message doesn't really tell us much. Why is the current split incorrect ? What is the symptom and result of the incorrect split ? Are the package contents the same after this change ?
Bruce
Hi Bruce,
Quoted 7 lines
Currently, perf can't split to perf-archive, perf-tests, perf-python and perf-perl.
All files are included in perf package. For example, like perf-tests package:
It generates files in '${exec_prefix}/libexec/perf-core/tests', not in '${libdir}/perf/perf-core/tests'.
So I change the files paths to make split successfully.
Quoted 8 lines
But that means, whether or not we like it, anything using perf has been using those "non splits" and getting everything when perf is installed.
It's also might be in order to make the main perf package RDEPEND on the other three, to keep it consistent. Make it a ?= so it can be overridden, and then we can age it out over time.
Bruce
Do you mean we should set RDEPENDS like:
RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we should use
RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"to keep it consistent. Do you agree?
Or, we can also revert following commit to make all files in perf package.
commit 36c3e923df85e685b707fe6bd84b053a5e366fe4
Author: Henning Heinold <[email protected]>
Date: Mon Jun 9 23:21:29 2014 +0200
perf: split packging
Best Regards
Chong
Quoted 46 lines
Quoted 44 lines
I will improve commit message and resend a V2.
Best Regards
ChongQuoted 39 lines
Quoted 37 lines
Signed-off-by Chong Lu <[email protected]>--- meta/recipes-kernel/perf/perf.bb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)meta/recipes-kernel/perf/perf.bb +0
-0@@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests${RSUGGESTS_SCRIPTING}"
FILES_${PN} += "${libexecdir}/perf-core${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"meta/recipes-kernel/perf/perf.bb +0
-3-FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" -FILES_${PN}-python = "${libdir}/python*/site-packages${libdir}/perf/perf-core/scripts/python"
meta/recipes-kernel/perf/perf.bb +3
-1-FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" +FILES_${PN}-python = "${libdir}/python*/site-packages${exec_prefix}/libexec/perf-core/scripts/python" +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
INHIBIT_PACKAGE_DEBUG_SPLIT="1"
--
1.9.1--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 41 lines · Chong Lu
Quoted 18 lines · Bruce Ashfield
Quoted 10 lines · Chong Lu
Quoted 7 lines · Bruce Ashfield
Quoted 1 line · Chong Lu
Fix incorrect paths to split perf package.
Can you elaborate here ? This commit message doesn't really tell us much. Why is the current split incorrect ? What is the symptom and result of the incorrect split ? Are the package contents the same after this change ?
Bruce
Hi Bruce,
Quoted 7 lines
Currently, perf can't split to perf-archive, perf-tests, perf-python and perf-perl.
All files are included in perf package. For example, like perf-tests package:
It generates files in '${exec_prefix}/libexec/perf-core/tests', not in '${libdir}/perf/perf-core/tests'.
So I change the files paths to make split successfully.Quoted 8 lines
But that means, whether or not we like it, anything using perf has been using those "non splits" and getting everything when perf is installed.
It's also might be in order to make the main perf package RDEPEND on the other three, to keep it consistent. Make it a ?= so it can be overridden, and then we can age it out over time.
Bruce
Do you mean we should set RDEPENDS like:
RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we should use
RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"to keep it consistent. Do you agree?
Or, we can also revert following commit to make all files in perf package.
commit36c3e923df85e685b707fe6bd84b053a5e366fe4
Author: Henning Heinold <[email protected]>
Date: Mon Jun 9 23:21:29 2014 +0200
Quoted 4 lines
perf: split packging
Best Regards
Chong
Please do not destroy the following use case, which is using perf top WIHTOUT installing perl or python.
Bye Henning
Quoted 41 lines · Henning Heinold
Quoted 40 lines · Chong Lu
Quoted 18 lines · Bruce Ashfield
Quoted 10 lines · Chong Lu
Quoted 7 lines · Bruce Ashfield
Quoted 1 line · Chong Lu
Fix incorrect paths to split perf package.
Can you elaborate here ? This commit message doesn't really tell us much. Why is the current split incorrect ? What is the symptom and result of the incorrect split ? Are the package contents the same after this change ?
Bruce
Hi Bruce,
Quoted 7 lines
Currently, perf can't split to perf-archive, perf-tests, perf-python and perf-perl.
All files are included in perf package. For example, like perf-tests package:
It generates files in '${exec_prefix}/libexec/perf-core/tests', not in '${libdir}/perf/perf-core/tests'.
So I change the files paths to make split successfully.Quoted 8 lines
But that means, whether or not we like it, anything using perf has been using those "non splits" and getting everything when perf is installed.
It's also might be in order to make the main perf package RDEPEND on the other three, to keep it consistent. Make it a ?= so it can be overridden, and then we can age it out over time.
Bruce
Do you mean we should set RDEPENDS like:
RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we should use
RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"to keep it consistent. Do you agree?
Or, we can also revert following commit to make all files in perf package.
commit 36c3e923df85e685b707fe6bd84b053a5e366fe4 Author: Henning Heinold <[email protected]> Date: Mon Jun 9 23:21:29 2014 +0200
Quoted 8 lines
Quoted 4 lines
perf: split packging
Best Regards
ChongPlease do not destroy the following use case, which is using perf top WIHTOUT installing perl or python.
Bye Henning
Hi Henning,
perf can't split to perf-archive, perf-tests, perf-python and perf-perl from your patch. Currently, all files are in perf package.
BR
Chong
Quoted 41 lines · Chong Lu
Quoted 32 lines · Bruce Ashfield
Quoted 18 lines · Chong Lu
Quoted 6 lines · Bruce Ashfield
Quoted 2 lines · Chong Lu
Fix incorrect paths to split perf package.
Quoted 7 lines
Can you elaborate here ? This commit message doesn't really tell us much.
Why is the current split incorrect ? What is the symptom and result of the
incorrect split ? Are the package contents the same after this change ?Bruce
Hi Bruce,
Quoted 7 lines
Currently, perf can't split to perf-archive, perf-tests, perf-python and perf-perl.
All files are included in perf package. For example, like perf-tests package:
It generates files in '${exec_prefix}/libexec/perf-core/tests', not in '${libdir}/perf/perf-core/tests'.
So I change the files paths to make split successfully.But that means, whether or not we like it, anything using perf has been using
those "non splits" and getting everything when perf is installed.Quoted 6 lines
It's also might be in order to make the main perf package RDEPEND on the other three, to keep it consistent. Make it a ?= so it can be overridden,
and then we can age it out over time.Bruce
Quoted 7 lines
Do you mean we should set RDEPENDS like:
RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we should use
RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"to keep it consistent. Do you agree?
Consistency is one thing, but it won't allow the split package to be easily dropped,
so I'd still suggest that the ?= would make it easier to override.
Bruce
Quoted 60 lines
Or, we can also revert following commit to make all files in perf package.
commit36c3e923df85e685b707fe6bd84b053a5e366fe4
Author: Henning Heinold <[email protected]>
Date: Mon Jun 9 23:21:29 2014 +0200perf: split packging
Best Regards
ChongQuoted 47 lines
Quoted 45 lines
I will improve commit message and resend a V2.
Best Regards
ChongQuoted 40 lines
Quoted 37 lines
Signed-off-by Chong Lu <[email protected]>--- meta/recipes-kernel/perf/perf.bb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)meta/recipes-kernel/perf/perf.bb +0
-0@@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests${RSUGGESTS_SCRIPTING}"
FILES_${PN} += "${libexecdir}/perf-core${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"meta/recipes-kernel/perf/perf.bb +0
-3-FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" -FILES_${PN}-python = "${libdir}/python*/site-packages${libdir}/perf/perf-core/scripts/python"
meta/recipes-kernel/perf/perf.bb +3
-1-FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" +FILES_${PN}-python = "${libdir}/python*/site-packages${exec_prefix}/libexec/perf-core/scripts/python" +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
INHIBIT_PACKAGE_DEBUG_SPLIT="1"
--
1.9.1--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"