Skip to contentSkip to conversation

arch: score: Export necessary symbols in related files

PATCH In review Chen Gang 2 participants 7 messages Jul 9, 2014 – Aug 2, 2014

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 arch: score: Export necessary symbols in related files

'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by outside modules, so need export them in the related files.

The related error (with allmodconfig under score):

MODPOST 1365 modules
ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!

---
 arch/score/lib/checksum_copy.c | 1 +
 arch/score/mm/cache.c          | 1 +
 2 files changed, 2 insertions(+)
arch/score/lib/checksum_copy.c +1 -0
index 04565dd..9b770b3 100644
@@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
 
 	return csum_partial(dst, len, sum);
 }
+EXPORT_SYMBOL(csum_partial_copy_from_user);
arch/score/mm/cache.c +1 -0
index f85ec1a..be91041 100644
@@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
 	addr = (unsigned long) page_address(page);
 	flush_data_cache_page(addr);
 }
+EXPORT_SYMBOL(flush_dcache_page);
 
 /* called by update_mmu_cache. */
 void __update_cache(struct vm_area_struct *vma, unsigned long address,
Signature · 1 line
1.9.2.459.g68773ac
Acked-by on v1 1/1
#1 lore raw

2014-07-09 16:48 GMT+08:00 Chen Gang <[email protected]>:

Quoted 39 lines

'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by outside modules, so need export them in the related files.

The related error (with allmodconfig under score):

MODPOST 1365 modules
ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!

---
 arch/score/lib/checksum_copy.c | 1 +
 arch/score/mm/cache.c          | 1 +
 2 files changed, 2 insertions(+)
arch/score/lib/checksum_copy.c +1 -0
index 04565dd..9b770b3 100644
@@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
 
        return csum_partial(dst, len, sum);
 }
+EXPORT_SYMBOL(csum_partial_copy_from_user);
arch/score/mm/cache.c +1 -1
index f85ec1a..be91041 100644
@@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
        addr = (unsigned long) page_address(page);
        flush_data_cache_page(addr);
 }
+EXPORT_SYMBOL(flush_dcache_page);
 
 /* called by update_mmu_cache. */
 void __update_cache(struct vm_area_struct *vma, unsigned long address,
--

1.9.2.459.g68773ac

author
#2 lore raw
Quoted 2 lines · Lennox Wu

OK, thank you for your work.

Quoted 40 lines

2014-07-09 16:48 GMT+08:00 Chen Gang <[email protected]>:

Quoted 39 lines

'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by outside modules, so need export them in the related files.

The related error (with allmodconfig under score):

MODPOST 1365 modules
ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!

---
 arch/score/lib/checksum_copy.c | 1 +
 arch/score/mm/cache.c          | 1 +
 2 files changed, 2 insertions(+)
arch/score/lib/checksum_copy.c +1 -0
index 04565dd..9b770b3 100644
@@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
 
        return csum_partial(dst, len, sum);
 }
+EXPORT_SYMBOL(csum_partial_copy_from_user);
arch/score/mm/cache.c +1 -1
index f85ec1a..be91041 100644
@@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
        addr = (unsigned long) page_address(page);
        flush_data_cache_page(addr);
 }
+EXPORT_SYMBOL(flush_dcache_page);
 
 /* called by update_mmu_cache. */
 void __update_cache(struct vm_area_struct *vma, unsigned long address,
--

1.9.2.459.g68773ac

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
#3 lore raw

It was merged into Score's git tree, and it will show in the next PULL request.

Best,
Lennox

Chen Gang 於 2014/7/17 下午 05:01 寫道:

Quoted 48 lines · Lennox Wu
Quoted 2 lines

OK, thank you for your work.

Quoted 40 lines

2014-07-09 16:48 GMT+08:00 Chen Gang <[email protected]>:

Quoted 39 lines

'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by outside modules, so need export them in the related files.

The related error (with allmodconfig under score):

MODPOST 1365 modules
ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!

---
  arch/score/lib/checksum_copy.c | 1 +
  arch/score/mm/cache.c          | 1 +
  2 files changed, 2 insertions(+)
arch/score/lib/checksum_copy.c +1 -0
index 04565dd..9b770b3 100644
@@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
 
         return csum_partial(dst, len, sum);
  }
+EXPORT_SYMBOL(csum_partial_copy_from_user);
arch/score/mm/cache.c +1 -1
index f85ec1a..be91041 100644
@@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
         addr = (unsigned long) page_address(page);
         flush_data_cache_page(addr);
  }
+EXPORT_SYMBOL(flush_dcache_page);
 
  /* called by update_mmu_cache. */
  void __update_cache(struct vm_area_struct *vma, unsigned long address,
--

1.9.2.459.g68773ac

author
#4 lore raw
Quoted 3 lines · Lennox Wu

It was merged into Score's git tree, and it will show in the next PULL request.

OK, thanks. And next, will it be integrated into upstream main line? (I guess it will be).

Thanks

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
#5 lore raw

Yes, I will issue a PULL request to Linus.
Best,
Lennox

Chen Gang 於 2014/8/2 下午 04:18 寫道:

Quoted 11 lines · Lennox Wu
Quoted 3 lines

It was merged into Score's git tree, and it will show in the next PULL request.

OK, thanks. And next, will it be integrated into upstream main line? (I guess it will be).

Thanks

author
#6 lore raw
Quoted 1 line · Lennox Wu

Yes, I will issue a PULL request to Linus.

Thank you very much!

And I shall start allmodconfig for other architecture (microblaze), next week.

Quoted 15 lines

Best,
Lennox

Chen Gang 於 2014/8/2 下午 04:18 寫道:

Quoted 11 lines · Lennox Wu
Quoted 3 lines

It was merged into Score's git tree, and it will show in the next PULL request.

OK, thanks. And next, will it be integrated into upstream main line? (I guess it will be).

Thanks

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed