Skip to contentSkip to conversation

davinci compiler warnings

DISCUSSION Hans Verkuil 2 participants 3 messages Jul 17, 2014 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Prabhakar,

Can you take a look at these new warnings? I've just upgraded my compiler for the daily build to 4.9.1, so that's probably why they weren't seen before.

Regards,

Hans

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c: In function 'vpif_remove':
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c:1389:36: warning: iteration 1u invokes undefined behavior [-Waggressive-loop-optimizations]

   vb2_dma_contig_cleanup_ctx(common->alloc_ctx);
                                    ^

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c:1385:2: note: containing loop
for (i = 0; i < VPIF_DISPLAY_MAX_DEVICES; i++) {
^
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c: In function 'vpif_remove':
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1581:36: warning: iteration 1u invokes undefined behavior [-Waggressive-loop-optimizations]

   vb2_dma_contig_cleanup_ctx(common->alloc_ctx);
                                    ^

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1577:2: note: containing loop
for (i = 0; i < VPIF_CAPTURE_MAX_DEVICES; i++) {
^
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1580:23: warning: array subscript is above array bounds [-Warray-bounds]

   common = &ch->common[i];
                       ^
#1 lore raw

Hi Hans

Quoted 5 lines · Hans Verkuil

Hi Prabhakar,

Can you take a look at these new warnings? I've just upgraded my compiler for the daily build to 4.9.1, so that's probably why they weren't seen before.

Ok will look at it. BTW are these errors from the media/master branch or from your tree ?

Thanks,
--Prabhakar Lad

Quoted 21 lines

Regards,

Hans

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c: In function 'vpif_remove':
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c:1389:36: warning: iteration 1u invokes undefined behavior [-Waggressive-loop-optimizations]

   vb2_dma_contig_cleanup_ctx(common->alloc_ctx);
                                    ^

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c:1385:2: note: containing loop
for (i = 0; i < VPIF_DISPLAY_MAX_DEVICES; i++) {
^
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c: In function 'vpif_remove':
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1581:36: warning: iteration 1u invokes undefined behavior [-Waggressive-loop-optimizations]

   vb2_dma_contig_cleanup_ctx(common->alloc_ctx);
                                    ^

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1577:2: note: containing loop
for (i = 0; i < VPIF_CAPTURE_MAX_DEVICES; i++) {
^
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1580:23: warning: array subscript is above array bounds [-Warray-bounds]

   common = &ch->common[i];
                       ^
#2 lore raw
Quoted 10 lines · Prabhakar Lad

Hi Hans

Quoted 5 lines · Hans Verkuil

Hi Prabhakar,

Can you take a look at these new warnings? I've just upgraded my compiler for the daily build to 4.9.1, so that's probably why they weren't seen before.

Ok will look at it. BTW are these errors from the media/master branch or from your tree ?

media/master

Quoted 30 lines

Thanks,
--Prabhakar Lad

Quoted 13 lines

Regards,

Hans

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c: In function 'vpif_remove':
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c:1389:36: warning: iteration 1u invokes undefined behavior [-Waggressive-loop-optimizations]

   vb2_dma_contig_cleanup_ctx(common->alloc_ctx);
                                    ^

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c:1385:2: note: containing loop
for (i = 0; i < VPIF_DISPLAY_MAX_DEVICES; i++) {
^
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c: In function 'vpif_remove':
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1581:36: warning: iteration 1u invokes undefined behavior [-Waggressive-loop-optimizations]

Quoted 8 lines
   vb2_dma_contig_cleanup_ctx(common->alloc_ctx);
                                    ^

/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1577:2: note: containing loop
for (i = 0; i < VPIF_CAPTURE_MAX_DEVICES; i++) {
^
/home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_capture.c:1580:23: warning: array subscript is above array bounds [-Warray-bounds]

   common = &ch->common[i];
                       ^

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html