Skip to contentSkip to conversation

pkg-infra: Fix DOWNLOAD_LOCALFILES

PATCH New Andreas Naumann 4 participants 5 messages Jul 17, 2014 – Jul 18, 2014

lore
Share & tools
lore

Andreas Naumann

author
#0 lore raw

PATCH 1/1 pkg-infra: Fix DOWNLOAD_LOCALFILES

The cp helperscript expects a filename as target, but just the folder name was given.

---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +1 -1
index 7f208d5..118591c 100644
@@ -206,7 +206,7 @@ endef
 define DOWNLOAD_LOCALFILES
 	test -e $(DL_DIR)/$(2) || \
 	$(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call qstrip,$(1))) \
-					 $(DL_DIR) && \
+					 $(DL_DIR)/$(2) && \
 	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
 endef
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 pkg-infra: Fix DOWNLOAD_LOCALFILES

Andreas, All,

On 2014-07-17 17:06 +0200, Andreas Naumann spake thusly:

Quoted 1 line

The cp helperscript expects a filename as target, but just the folder name was given.

This is mising your Signed-off-by line. Care to just reply to your initial mail to add it, please?

Otherwise:

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +1 -1
index 7f208d5..118591c 100644
@@ -206,7 +206,7 @@ endef
 define DOWNLOAD_LOCALFILES
 	test -e $(DL_DIR)/$(2) || \
 	$(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call qstrip,$(1))) \
-					 $(DL_DIR) && \
+					 $(DL_DIR)/$(2) && \
 	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
 endef
Signature · 6 lines
1.8.3.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 pkg-infra: Fix DOWNLOAD_LOCALFILES

In reply to Andreas Naumann

From 40ba2efd131a4fd70e44a0f9f96c4637da279df8 Mon Sep 17 00:00:00 2001
From: Andreas Naumann <[email protected]>
Date: Thu, 17 Jul 2014 16:47:02 +0200
Subject: [PATCH 1/6] pkg-infra: Fix DOWNLOAD_LOCALFILES

The cp helperscript expects a filename as target, but just the folder name was given.

Signed-off-by Andreas Naumann <[email protected]>
---
  package/pkg-download.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +0 -0
index 7f208d5..118591c 100644
@@ -206,7 +206,7 @@ endef
  define DOWNLOAD_LOCALFILES
  	test -e $(DL_DIR)/$(2) || \
  	$(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call

qstrip,$(1))) \
- $(DL_DIR) && \
+ $(DL_DIR)/$(2) && \
$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
endef

Signature · 1 line
1.8.3.2
#3 lore raw

PATCH 1/1 pkg-infra: Fix DOWNLOAD_LOCALFILES

Andreas, All,

On 2014-07-18 09:12 +0200, Andreas Naumann spake thusly:

Quoted 9 lines

From 40ba2efd131a4fd70e44a0f9f96c4637da279df8 Mon Sep 17 00:00:00 2001
From: Andreas Naumann <[email protected]>
Date: Thu, 17 Jul 2014 16:47:02 +0200
Subject: [PATCH 1/6] pkg-infra: Fix DOWNLOAD_LOCALFILES

The cp helperscript expects a filename as target, but just the folder name was given.

Signed-off-by Andreas Naumann <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 20 lines
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +1 -1
index 7f208d5..118591c 100644
@@ -206,7 +206,7 @@ endef
 define DOWNLOAD_LOCALFILES
 	test -e $(DL_DIR)/$(2) || \
 	$(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call
 qstrip,$(1))) \
-					 $(DL_DIR) && \
+					 $(DL_DIR)/$(2) && \
 	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
 endef
Signature · 2 lines
-- 
1.8.3.2
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#4 lore raw

PATCH 1/1 pkg-infra: Fix DOWNLOAD_LOCALFILES

In reply to Andreas Naumann

Dear Andreas Naumann,

Quoted 5 lines · Andreas Naumann

From 40ba2efd131a4fd70e44a0f9f96c4637da279df8 Mon Sep 17 00:00:00 2001
From: Andreas Naumann <[email protected]>
Date: Thu, 17 Jul 2014 16:47:02 +0200
Subject: [PATCH 1/6] pkg-infra: Fix DOWNLOAD_LOCALFILES

Quoted 7 lines

The cp helperscript expects a filename as target, but just the folder name was given.

Signed-off-by Andreas Naumann <[email protected]>
---
  package/pkg-download.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks. But next time, could you use "git send-email" to send your patch? Your patch was incorrectly line-wrapped, and the formatting of the commit log a bit weird.

Thanks a lot,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com