ubifs: refactor ubifs_file_mmap()
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 ubifs: refactor ubifs_file_mmap()
generic_file_mmap() set vma->vm_ops = &generic_file_vm_ops, then ubifs_file_mmap set vma->vm_ops = &ubifs_file_vm_ops. So it is redundant.
And there is no kind of file does not supply page reading function in ubifs. The readpage() check up for mmap file in generic_file_mmap() is not needed.
So remove the call of generic_file_mmap().
Signed-off-by Zhang Zhen <[email protected]>
--- fs/ubifs/file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
fs/ubifs/file.c +2 -4
@@ -1540,11 +1540,9 @@ static const struct vm_operations_struct ubifs_file_vm_ops = {static int ubifs_file_mmap (struct file *file,struct vm_area_struct *vma) { -int err; +struct address_space *mapping = file->f_mapping; - err =generic_file_mmap (file, vma); -if (err) -return err; +file_accessed (file); vma->vm_ops = &ubifs_file_vm_ops;return 0 ; }
Signature · 4 lines
1.8.1.2 .