Skip to contentSkip to conversation

cubieboard2: Enable AXP209 power controller

PATCH New Ian Campbell 2 participants 5 messages Jul 24, 2014 – Jul 27, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cubieboard2: Enable AXP209 power controller

For some reason even the original sunxi tree was missing this.

---
 boards.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
boards.cfg +2 -2
index 47028e8..8572972 100644
@@ -379,8 +379,8 @@ Active  arm         armv7          s5pc1xx     samsung         smdkc100
 Active  arm         armv7          socfpga     altera          socfpga             socfpga_cyclone5                      -                                                                                                                                 -
 Active  arm         armv7          sunxi       -               sunxi               A13-OLinuXinoM                        sun5i:A13_OLINUXINOM,SPL,CONS_INDEX=2                                                                                             Hans de Goede <[email protected]>
 Active  arm         armv7          sunxi       -               sunxi               Cubieboard                            sun4i:CUBIEBOARD,SPL,AXP209_POWER,SUNXI_EMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                            Hans de Goede <[email protected]>
-Active  arm         armv7          sunxi       -               sunxi               Cubieboard2                           sun7i:CUBIEBOARD2,SPL,SUNXI_GMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                                        Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
-Active  arm         armv7          sunxi       -               sunxi               Cubieboard2_FEL                       sun7i:CUBIEBOARD2,SPL_FEL,SUNXI_GMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                                    Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
+Active  arm         armv7          sunxi       -               sunxi               Cubieboard2                           sun7i:CUBIEBOARD2,SPL,AXP209_POWER,SUNXI_GMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                           Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
+Active  arm         armv7          sunxi       -               sunxi               Cubieboard2_FEL                       sun7i:CUBIEBOARD2,SPL_FEL,AXP209_POWER,SUNXI_GMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                       Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
 Active  arm         armv7          sunxi       -               sunxi               Cubietruck                            sun7i:CUBIETRUCK,SPL,AXP209_POWER,SUNXI_GMAC,RGMII,AHCI,SATAPWR=SUNXI_GPH(12)                                                     Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
 Active  arm         armv7          sunxi       -               sunxi               Cubietruck_FEL                        sun7i:CUBIETRUCK,SPL_FEL,AXP209_POWER,SUNXI_GMAC,RGMII,AHCI,SATAPWR=SUNXI_GPH(12)                                                 Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
 Active  arm         armv7          sunxi       -               sunxi               r7-tv-dongle                          sun5i:R7DONGLE,SPL,AXP152_POWER                                                                                                   Hans de Goede <[email protected]>
Signature · 1 line
2.0.1
#1 lore raw

PATCH 1/1 cubieboard2: Enable AXP209 power controller

Hi,

Quoted 1 line · Ian Campbell

For some reason even the original sunxi tree was missing this.

The original tree is not missing it, in the original tree the logic is backwards, all board get AXP209 unless NO_AXP or AXP152 are defined.

I decided to not carry this "magic" forward to the upstream code, which means that any board which does not have NO_AXP or AXP152 upstream needs AXP209

Quoted 2 lines

Regards,

Hans

Quoted 20 lines
---
  boards.cfg | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
boards.cfg +2 -2
index 47028e8..8572972 100644
@@ -379,8 +379,8 @@ Active  arm         armv7          s5pc1xx     samsung         smdkc100
  Active  arm         armv7          socfpga     altera          socfpga             socfpga_cyclone5                      -                                                                                                                                 -
  Active  arm         armv7          sunxi       -               sunxi               A13-OLinuXinoM                        sun5i:A13_OLINUXINOM,SPL,CONS_INDEX=2                                                                                             Hans de Goede <[email protected]>
  Active  arm         armv7          sunxi       -               sunxi               Cubieboard                            sun4i:CUBIEBOARD,SPL,AXP209_POWER,SUNXI_EMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                            Hans de Goede <[email protected]>
-Active  arm         armv7          sunxi       -               sunxi               Cubieboard2                           sun7i:CUBIEBOARD2,SPL,SUNXI_GMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                                        Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
-Active  arm         armv7          sunxi       -               sunxi               Cubieboard2_FEL                       sun7i:CUBIEBOARD2,SPL_FEL,SUNXI_GMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                                    Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
+Active  arm         armv7          sunxi       -               sunxi               Cubieboard2                           sun7i:CUBIEBOARD2,SPL,AXP209_POWER,SUNXI_GMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                           Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
+Active  arm         armv7          sunxi       -               sunxi               Cubieboard2_FEL                       sun7i:CUBIEBOARD2,SPL_FEL,AXP209_POWER,SUNXI_GMAC,AHCI,SATAPWR=SUNXI_GPB(8)                                                       Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
  Active  arm         armv7          sunxi       -               sunxi               Cubietruck                            sun7i:CUBIETRUCK,SPL,AXP209_POWER,SUNXI_GMAC,RGMII,AHCI,SATAPWR=SUNXI_GPH(12)                                                     Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
  Active  arm         armv7          sunxi       -               sunxi               Cubietruck_FEL                        sun7i:CUBIETRUCK,SPL_FEL,AXP209_POWER,SUNXI_GMAC,RGMII,AHCI,SATAPWR=SUNXI_GPH(12)                                                 Ian Campbell <[email protected]>:Hans de Goede <[email protected]>
  Active  arm         armv7          sunxi       -               sunxi               r7-tv-dongle                          sun5i:R7DONGLE,SPL,AXP152_POWER                                                                                                   Hans de Goede <[email protected]>
#2 lore raw

PATCH 1/1 cubieboard2: Enable AXP209 power controller

Quoted 7 lines · Hans de Goede

Hi,

Quoted 1 line · Ian Campbell

For some reason even the original sunxi tree was missing this.

The original tree is not missing it, in the original tree the logic is backwards, all board get AXP209 unless NO_AXP or AXP152 are defined.

Ah, I missed that tricky bit of logic.

Quoted 1 line

I decided to not carry this "magic" forward to the upstream code,

Yes, that makes absolute sense (and I now vague recall you telling me this before).

Quoted 7 lines

which means
that any board which does not have NO_AXP or AXP152 upstream needs AXP209

Quoted 2 lines

Thanks.

FYI I've started collecting things into next to be swept into master and PR-d once the existing PR goes through.

Ian.

#3 lore raw

PATCH 1/1 cubieboard2: Enable AXP209 power controller

Hi,

Quoted 20 lines · Ian Campbell
Quoted 7 lines · Hans de Goede

Hi,

Quoted 1 line · Ian Campbell

For some reason even the original sunxi tree was missing this.

The original tree is not missing it, in the original tree the logic is backwards, all board get AXP209 unless NO_AXP or AXP152 are defined.

Ah, I missed that tricky bit of logic.

Quoted 1 line

I decided to not carry this "magic" forward to the upstream code,

Yes, that makes absolute sense (and I now vague recall you telling me this before).

Quoted 4 lines

which means
that any board which does not have NO_AXP or AXP152 upstream needs AXP209

Quoted 1 line
Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Thanks.

FYI I've started collecting things into next to be swept into master and PR-d once the existing PR goes through.

Right, I've been using that tree to base my current work to add support for more boards on:

https://github.com/jwrdegoede/u-boot-sunxi/commits/next

Regards,

Hans

#4 lore raw

PATCH 1/1 cubieboard2: Enable AXP209 power controller

In reply to Ian Campbell

Hi,

Quoted 20 lines · Ian Campbell
Quoted 7 lines · Hans de Goede

Hi,

Quoted 1 line · Ian Campbell

For some reason even the original sunxi tree was missing this.

The original tree is not missing it, in the original tree the logic is backwards, all board get AXP209 unless NO_AXP or AXP152 are defined.

Ah, I missed that tricky bit of logic.

Quoted 1 line

I decided to not carry this "magic" forward to the upstream code,

Yes, that makes absolute sense (and I now vague recall you telling me this before).

Quoted 4 lines

which means
that any board which does not have NO_AXP or AXP152 upstream needs AXP209

Quoted 1 line
Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Thanks.

FYI I've started collecting things into next to be swept into master and PR-d once the existing PR goes through.

I've pushed this patch to u-boot-sunxi next now.

Regards,

Hans