mm: fix filemap.c pagecache_get_page() kernel-doc warnings
Subsystems (2)
PATCH 1/1 mm: fix filemap.c pagecache_get_page() kernel-doc warnings
From: Randy Dunlap <[email protected]>
Fix kernel-doc warnings in mm/filemap.c: pagecache_get_page():
Warning(..//mm/filemap.c:1054): No description found for parameter 'cache_gfp_mask' Warning(..//mm/filemap.c:1054): No description found for parameter 'radix_gfp_mask' Warning(..//mm/filemap.c:1054): Excess function parameter 'gfp_mask' description in 'pagecache_get_page'
page cache allocation where possible"
--- mm/filemap.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
mm/filemap.c +4 -3
@@ -1031,16 +1031,17 @@ EXPORT_SYMBOL(find_lock_entry);* @mapping: the address_space to search * @offset: the page index * @fgp_flags: PCG flags -* @gfp_mask: gfp mask to use if a page is to be allocated +* @cache_gfp_mask: gfp mask to use if a page is to be allocated +* @radix_gfp_mask: gfp mask to use for page cache LRU allocation * * Looks up the page cache slot at @mapping & @offset. * -* PCG flags modify how the page is returned +* PCG flags modify how the page is returned. * * FGP_ACCESSED: the page will be marked accessed * FGP_LOCK: Page is return locked * FGP_CREAT: If page is not present then a new page is allocated using -* @gfp_mask and added to the page cache and the VM's LRU +* @cache_gfp_mask and added to the page cache and the VM's LRU * list. The page is returned locked and with an increased * refcount. Otherwise, %NULL is returned. *
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 8 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix kernel-doc warnings in
mm/filemap.c:pagecache_get_page():Warning(..//mm/filemap.c:1054): No description found for parameter '
cache_gfp_mask' Warning(..//mm/filemap.c:1054): No description found for parameter 'radix_gfp_mask' Warning(..//mm/filemap.c:1054): Excess function parameter 'gfp_mask' description in 'pagecache_get_page'
Quoted 5 lines
Fixes 2457aec63745 "mm: non-atomically mark page accessed duringpage cache allocation where possible"
Signed-off-by Randy Dunlap <[email protected]>Cc Mel Gorman <[email protected]>
Use this diff instead?
---8<---
mm/filemap.c +8 -5
@@ -1031,18 +1031,21 @@ EXPORT_SYMBOL(find_lock_entry);* @mapping: the address_space to search * @offset: the page index * @fgp_flags: PCG flags -* @gfp_mask: gfp mask to use if a page is to be allocated +* @cache_gfp_mask: gfp mask to use for the page cache data page allocation +* @radix_gfp_mask: gfp mask to use for radix tree node allocation * * Looks up the page cache slot at @mapping & @offset. * -* PCG flags modify how the page is returned +* PCG flags modify how the page is returned. * * FGP_ACCESSED: the page will be marked accessed * FGP_LOCK: Page is return locked * FGP_CREAT: If page is not present then a new page is allocated using -* @gfp_mask and added to the page cache and the VM's LRU -* list. The page is returned locked and with an increased -* refcount. Otherwise, %NULL is returned. +* @cache_gfp_mask and added to the page cache and the VM's LRU +* list. If radix tree nodes are allocated during page cache +* insertion then @radix_gfp_mask is used. The page is returned +* locked and with an increased refcount. Otherwise, %NULL is +* returned. * * If FGP_LOCK or FGP_CREAT are specified then the function may sleep even * if the GFP flags specified for FGP_CREAT are atomic.
Signature · 8 lines
Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 9 lines · Mel Gorman
Quoted 8 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix kernel-doc warnings in
mm/filemap.c:pagecache_get_page():Warning(..//mm/filemap.c:1054): No description found for parameter '
cache_gfp_mask' Warning(..//mm/filemap.c:1054): No description found for parameter 'radix_gfp_mask' Warning(..//mm/filemap.c:1054): Excess function parameter 'gfp_mask' description in 'pagecache_get_page'
Quoted 7 lines
Quoted 5 lines
Fixes 2457aec63745 "mm: non-atomically mark page accessed duringpage cache allocation where possible"
Signed-off-by Randy Dunlap <[email protected]>Cc Mel Gorman <[email protected]>Use this diff instead?
Sure. Acked-by: Randy Dunlap <[email protected]>
Thanks.
Andrew?
Quoted 34 lines
---8<---
mm/filemap.c +8
-5@@ -1031,18 +1031,21 @@ EXPORT_SYMBOL(find_lock_entry);* @mapping: the address_space to search * @offset: the page index * @fgp_flags: PCG flags -* @gfp_mask: gfp mask to use if a page is to be allocated +* @cache_gfp_mask: gfp mask to use for the page cache data page allocation +* @radix_gfp_mask: gfp mask to use for radix tree node allocation * * Looks up the page cache slot at @mapping & @offset. * -* PCG flags modify how the page is returned +* PCG flags modify how the page is returned. * * FGP_ACCESSED: the page will be marked accessed * FGP_LOCK: Page is return locked * FGP_CREAT: If page is not present then a new page is allocated using -* @gfp_mask and added to the page cache and the VM's LRU -* list. The page is returned locked and with an increased -* refcount. Otherwise, %NULL is returned. +* @cache_gfp_mask and added to the page cache and the VM's LRU +* list. If radix tree nodes are allocated during page cache +* insertion then @radix_gfp_mask is used. The page is returned +* locked and with an increased refcount. Otherwise, %NULL is +* returned. * * If FGP_LOCK or FGP_CREAT are specified then the function may sleep even * if the GFP flags specified for FGP_CREAT are atomic.
Signature · 7 lines
~Randy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>