Add support to get PMU address via DT for exynos5260

PATCH RESEND Superseded Vikas Sajjan 4 participants 7 messages Jul 28, 2014

Subsystems (4)

Device tree bindings Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Vikas Sajjan

author

2014-07-28 12:37 UTC #0 lore raw

cover Add support to get PMU address via DT for exynos5260

rebased on kgene tree for-next branch
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/log/?h=for-next

Vikas Sajjan (2):
ARM: DTS: Add PMU DT node for exynos5260 SoC
ARM: EXYNOS: Add exynos5260 PMU compatible string to DT match table

 .../devicetree/bindings/arm/samsung/pmu.txt        |    1 +
 arch/arm/boot/dts/exynos5260.dtsi                  |    5 +++++
 arch/arm/mach-exynos/exynos.c                      |    1 +
 3 files changed, 7 insertions(+)

Signature · 1 line

1.7.9.5

Vikas Sajjan

author

2014-07-28 12:37 UTC #1 lore raw

PATCH RESEND 1/2 ARM: DTS: Add PMU DT node for exynos5260 SoC

Adds PMU DT node for exynos5260 SoC.

Signed-off-by Vikas Sajjan <[email protected]>

---
 .../devicetree/bindings/arm/samsung/pmu.txt        |    1 +
 arch/arm/boot/dts/exynos5260.dtsi                  |    5 +++++
 2 files changed, 6 insertions(+)

Documentation/devicetree/bindings/arm/samsung/pmu.txt +1 -0

index 2a4ab04..c038628 100644
@@ -8,6 +8,7 @@ Properties:
 		   - "samsung,exynos4412-pmu" - for Exynos4412 SoC,
 		   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
 		   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
+		   - "samsung,exynos5260-pmu" - for Exynos5260 SoC.
 		second value must be always "syscon".
 
  - reg : offset and length of the register set.

arch/arm/boot/dts/exynos5260.dtsi +5 -0

index 5398a60..4f2fabe 100644
@@ -227,6 +227,11 @@
 			interrupts = <0 243 0>;
 		};
 
+		pmu_system_controller: system-controller at 10D50000 {
+			compatible = "samsung,exynos5260-pmu", "syscon";
+			reg = <0x10D50000 0x10000>;
+		};
+
 		uart0: serial at 12C00000 {
 			compatible = "samsung,exynos4210-uart";
 			reg = <0x12C00000 0x100>;

Signature · 1 line

1.7.9.5

Sachin Kamat

2014-07-28 15:26 UTC #2 lore raw

PATCH RESEND 1/2 ARM: DTS: Add PMU DT node for exynos5260 SoC

Hi Vikas,

Quoted 13 lines · Vikas Sajjan

Adds PMU DT node for exynos5260 SoC.
Signed-off-by Vikas Sajjan <[email protected]>
---
 .../devicetree/bindings/arm/samsung/pmu.txt        |    1 +
 arch/arm/boot/dts/exynos5260.dtsi                  |    5 +++++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/samsung/pmu.txt +0 -0
index 2a4ab04..c038628 100644

Documentation/devicetree/bindings/arm/samsung/pmu.txt Properties: · line 11

Quoted 4 lines

Documentation/devicetree/bindings/arm/samsung/pmu.txt +1 -0

@@ -8,6 +8,7 @@ Properties:
                   - "samsung,exynos4412-pmu" - for Exynos4412 SoC,
                   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
                   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
+                  - "samsung,exynos5260-pmu" - for Exynos5260 SoC.

nit: This line should come after 5250 entry to preserve the order.

Otherwise, looks good.

Signature · 2 lines

Regards,
Sachin.

Andreas Färber

2014-07-28 20:29 UTC #3 lore raw

PATCH RESEND 1/2 ARM: DTS: Add PMU DT node for exynos5260 SoC

Hi Vikas and Sachin,

Am 28.07.2014 17:26, schrieb Sachin Kamat:

Quoted 21 lines · Vikas Sajjan

Quoted 13 lines
Adds PMU DT node for exynos5260 SoC.
Signed-off-by Vikas Sajjan <[email protected]>
---
 .../devicetree/bindings/arm/samsung/pmu.txt        |    1 +
 arch/arm/boot/dts/exynos5260.dtsi                  |    5 +++++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/samsung/pmu.txt +0 -0
index 2a4ab04..c038628 100644
Documentation/devicetree/bindings/arm/samsung/pmu.txt Properties: · line 11
Quoted 4 lines
Documentation/devicetree/bindings/arm/samsung/pmu.txt +1 -0
@@ -8,6 +8,7 @@ Properties:
                   - "samsung,exynos4412-pmu" - for Exynos4412 SoC,
                   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
                   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
+                  - "samsung,exynos5260-pmu" - for Exynos5260 SoC.
nit: This line should come after 5250 entry to preserve the order.

Quoted 1 line

Otherwise, looks good.

Earlier today, Kukjin indicated he would apply my corresponding 5410 series [*], but he hasn't pushed yet. It adds a 5410 entry before 5420, which will conflict with adding 5260 in the same place.

Regards,
Andreas

[*]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34686.html

Signature · 2 lines

SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

Kukjin Kim

2014-07-28 21:25 UTC #4 lore raw

PATCH RESEND 1/2 ARM: DTS: Add PMU DT node for exynos5260 SoC

Quoted 30 lines · Andreas F?rber

Hi Vikas and Sachin,
Am 28.07.2014 17:26, schrieb Sachin Kamat:
Quoted 21 lines · Vikas Sajjan
Quoted 13 lines
Adds PMU DT node for exynos5260 SoC.
Signed-off-by Vikas Sajjan<[email protected]>
---
  .../devicetree/bindings/arm/samsung/pmu.txt        |    1 +
  arch/arm/boot/dts/exynos5260.dtsi                  |    5 +++++
  2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/samsung/pmu.txt +0 -0
index 2a4ab04..c038628 100644
Documentation/devicetree/bindings/arm/samsung/pmu.txt Properties: · line 11
Quoted 4 lines
Documentation/devicetree/bindings/arm/samsung/pmu.txt +1 -0
@@ -8,6 +8,7 @@ Properties:
                    - "samsung,exynos4412-pmu" - for Exynos4412 SoC,
                    - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
                    - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
+                  - "samsung,exynos5260-pmu" - for Exynos5260 SoC.
nit: This line should come after 5250 entry to preserve the order.
Quoted 1 line
Otherwise, looks good.
Earlier today, Kukjin indicated he would apply my corresponding 5410 series [*], but he hasn't pushed yet. It adds a 5410 entry before 5420, which will conflict with adding 5260 in the same place.

Quoted 6 lines

Regards,
Andreas
[*]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34686.html

Thanks for you guys' comments, and I've applied this whole series with some handy modification ;)

- Kukjin

Vikas Sajjan

author

2014-07-28 12:38 UTC #5 lore raw

PATCH RESEND 2/2 ARM: EXYNOS: Add exynos5260 PMU compatible string to DT match table

In reply to Vikas Sajjan

Exynos initialisation code now relies on obtaining the PMU address via DT, so add the exynos5260 PMU compatible string to DT match table.

Signed-off-by Vikas Sajjan <[email protected]>

---
 arch/arm/mach-exynos/exynos.c |    1 +
 1 file changed, 1 insertion(+)

arch/arm/mach-exynos/exynos.c +1 -0

index df41bd1..e4f7270 100644
@@ -253,6 +253,7 @@ static const struct of_device_id exynos_dt_pmu_match[] = {
 	{ .compatible = "samsung,exynos4412-pmu" },
 	{ .compatible = "samsung,exynos5250-pmu" },
 	{ .compatible = "samsung,exynos5420-pmu" },
+	{ .compatible = "samsung,exynos5260-pmu" },
 	{ /*sentinel*/ },
 };

Signature · 1 line

1.7.9.5

Sachin Kamat

2014-07-28 15:27 UTC #6 lore raw

PATCH RESEND 2/2 ARM: EXYNOS: Add exynos5260 PMU compatible string to DT match table

Hi Vikas,

Quoted 13 lines · Vikas Sajjan

Exynos initialisation code now relies on obtaining the PMU address via DT, so add the exynos5260 PMU compatible string to DT match table.
Signed-off-by Vikas Sajjan <[email protected]>
---
 arch/arm/mach-exynos/exynos.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-exynos/exynos.c +0 -0
index df41bd1..e4f7270 100644

arch/arm/mach-exynos/exynos.c static const struct of_device_id exynos_dt_pmu_match[] = { · line 256

Quoted 4 lines

arch/arm/mach-exynos/exynos.c +1 -0

@@ -253,6 +253,7 @@ static const struct of_device_id exynos_dt_pmu_match[] = {
        { .compatible = "samsung,exynos4412-pmu" },
        { .compatible = "samsung,exynos5250-pmu" },
        { .compatible = "samsung,exynos5420-pmu" },
+       { .compatible = "samsung,exynos5260-pmu" },

Same comment as previous patch regarding order.

Signature · 2 lines

Regards,
Sachin.