Skip to contentSkip to conversation

staging: dgap: introduce dgap_cleanup_nodes()

PATCH Mark Hounschell 3 participants 6 messages Jul 31, 2014 – Aug 5, 2014 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 8 lines · Daeseok Youn

When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board.

Making a node will allocate node memory and strings for saving configrations with kstrdup().

So these are freed when dgap is unloaded or failed to initialize.

Quoted 9 lines

---
V2: Do not need to free for NULLNODE.

I have been too busy to solve this issue, sorry for late.

Mark, Can you test this patch? I try to make simple module which is testing dgap_parsefile() and dgap_cleanup_nodes().

I'll be happy to, but I can't do it until Monday. I'm not where the hardware is until then.

Regards
Mark

#2 lore raw

Hi, Mark

2014-07-31 21:44 GMT+09:00 Mark Hounschell <[email protected]>:

Quoted 14 lines · Daeseok Youn
Quoted 13 lines

When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board.

Making a node will allocate node memory and strings for saving configrations with kstrdup().

So these are freed when dgap is unloaded or failed to initialize.

---
V2: Do not need to free for NULLNODE.

Quoted 8 lines
Quoted 5 lines

I have been too busy to solve this issue, sorry for late.

Mark, Can you test this patch? I try to make simple module which is testing dgap_parsefile() and dgap_cleanup_nodes().

I'll be happy to, but I can't do it until Monday. I'm not where the hardware is until then.

That's OK. :-)

Thanks.
Daeseok Youn.

Quoted 4 lines

Regards
Mark

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 19 lines · DaeSeok Youn

Hi, Mark

2014-07-31 21:44 GMT+09:00 Mark Hounschell <[email protected]>:

Quoted 16 lines · Daeseok Youn
Quoted 15 lines

When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board.

Making a node will allocate node memory and strings for saving configrations with kstrdup().

So these are freed when dgap is unloaded or failed to initialize.

---
V2: Do not need to free for NULLNODE.

I have been too busy to solve this issue, sorry for late.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Mark, Can you test this patch? I try to make simple module which is testing dgap_parsefile() and dgap_cleanup_nodes().

I'll be happy to, but I can't do it until Monday. I'm not where the hardware is until then.

That's OK. :-)

After applying this patch I am still able to load and unload the driver at will, and it still works for me.

Regards
Mark

#5 lore raw

Hi, Mark and Greg.

Thanks for testing. :-)

Greg, is this patch possible to merge to your staging tree? Please check for me.
patch : https://lkml.org/lkml/2014/7/31/2

Thanks.

regards,
Daeseok Youn.

2014-08-04 21:40 GMT+09:00 Mark Hounschell <[email protected]>:

Quoted 40 lines · DaeSeok Youn
Quoted 26 lines

Hi, Mark

2014-07-31 21:44 GMT+09:00 Mark Hounschell <[email protected]>:

Quoted 22 lines · Daeseok Youn
Quoted 19 lines

When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board.

Making a node will allocate node memory and strings for saving configrations with kstrdup().

So these are freed when dgap is unloaded or failed to initialize.

---
V2: Do not need to free for NULLNODE.

I have been too busy to solve this issue, sorry for late.

Mark, Can you test this patch? I try to make simple module which is testing dgap_parsefile() and dgap_cleanup_nodes().

Quoted 6 lines
Quoted 3 lines

I'll be happy to, but I can't do it until Monday. I'm not where the hardware
is until then.

That's OK. :-)

After applying this patch I am still able to load and unload the driver at will, and it still works for me.

Regards
Mark

#6 lore raw
Quoted 7 lines · DaeSeok Youn

Hi, Mark and Greg.

Thanks for testing. :-)

Greg, is this patch possible to merge to your staging tree? Please check for me.
patch : https://lkml.org/lkml/2014/7/31/2

It's the middle of the merge window, I can't do anything until after 3.17-rc1 is out. So wait until then, I'll pick up the patch at that point in time, it's still in my "to-apply" queue.

thanks,

greg k-h

#7 lore raw

2014-08-05 8:38 GMT+09:00 Greg KH <[email protected]>:

Quoted 5 lines · DaeSeok Youn
Quoted 4 lines

Hi, Mark and Greg.

Thanks for testing. :-)

Quoted 7 lines
Quoted 3 lines

Greg, is this patch possible to merge to your staging tree? Please check for me.
patch : https://lkml.org/lkml/2014/7/31/2

It's the middle of the merge window, I can't do anything until after 3.17-rc1 is out. So wait until then, I'll pick up the patch at that point in time, it's still in my "to-apply" queue.

OK. I will wait until then.
Thanks.

regards,
Daeseok Youn

Quoted 4 lines

thanks,

greg k-h