Skip to contentSkip to conversation

arm64: More than 16 stream ids

DISCUSSION Joel Schopp 2 participants 2 messages Jul 31, 2014

lore
Share & tools
lore

Joel Schopp

author
#0 lore raw

I recently ran into a situation where I needed more than 16 stream ids for an smmu, but we are currently limited to 16 by:

#define MAX_MASTER_STREAMIDS MAX_PHANDLE_ARGS
#define MAX_PHANDLE_ARGS 16

I changed that 16 to 32 and everything worked for me. I am wondering if this is the preferred way to fix the limitation? If so I'd be happy to send out the 1 line patch.

-Joel

#1 lore raw

[Adding the other Rob ;)]

Quoted 9 lines · Joel Schopp

I recently ran into a situation where I needed more than 16 stream ids for an smmu, but we are currently limited to 16 by:

#define MAX_MASTER_STREAMIDS MAX_PHANDLE_ARGS
#define MAX_PHANDLE_ARGS 16

I changed that 16 to 32 and everything worked for me. I am wondering if this is the preferred way to fix the limitation? If so I'd be happy to send out the 1 line patch.

This seems fine to me. Last time it was brought up, the objection from RobH was that there wasn't any upstream activity for the AMD board, so this change could wait:

http://lists.linuxfoundation.org/pipermail/iommu/2014-January/007556.html

Will