ARM: enable ARMv7 virt support for the Arndale board
PATCH 1/1 ARM: enable ARMv7 virt support for the Arndale board
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.
---
Note that Andre previously reported a board reset on initial boot with this patch, but I have applied this patch on upstream master of U-Boot and tested on two separate Arndale boards and it boots perfectly fine and lets you use KVM, so I recommend taking this patch as is.
board/samsung/arndale/arndale.c | 10 ++++++++++ include/configs/arndale.h | 8 ++++++++ 2 files changed, 18 insertions(+)
board/samsung/arndale/arndale.c +10 -0
@@ -117,3 +117,13 @@ int checkboard(void) return 0; }#endif + +#ifdef CONFIG_S5P_PA_SYSRAM +void smp_set_core_boot_addr (unsigned long addr,int corenr) +{ +writel (addr,CONFIG_S5P_PA_SYSRAM ); + +/* make sure this write is really executed */ + __asm__volatile ("dsb\n" ); +} +#endif
include/configs/arndale.h +8 -0
@@ -250,4 +250,12 @@/* Enable Time Command */ #define CONFIG_CMD_TIME +#define CONFIG_S5P_PA_SYSRAM 0x02020000 +#define CONFIG_SMP_PEN_ADDR CONFIG_S5P_PA_SYSRAM + +/* The PERIPHBASE in the CBAR register is wrong on the Arndale, so override it */ +#define CONFIG_ARM_GIC_BASE_ADDRESS 0x10480000 + +#define CONFIG_ARMV7_VIRT +#endif /* __CONFIG_H */
Signature · 1 line
1.8.5.2
PATCH 1/1 ARM: enable ARMv7 virt support for the Arndale board
Hi,
Am 01.08.2014 13:35, schrieb Christoffer Dall:
Quoted 10 lines
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.Reviewed-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>
You forgot to sign off the patch.
But nice to see progress on this!
Cheers,
Andreas
Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
PATCH 1/1 ARM: enable ARMv7 virt support for the Arndale board
Quoted 11 lines · Andreas F?rber
Hi,
Am 01.08.2014 13:35, schrieb Christoffer Dall:
Quoted 8 lines
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.
Quoted 7 lines
Quoted 2 lines
Reviewed-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>You forgot to sign off the patch.
But nice to see progress on this!
Can you just add when applying the patch?
PATCH 1/1 ARM: enable ARMv7 virt support for the Arndale board
Quoted 15 lines · Christoffer Dall
Quoted 14 lines · Andreas F?rber
Hi,
Am 01.08.2014 13:35, schrieb Christoffer Dall:
Quoted 10 lines
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.Reviewed-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>
Quoted 7 lines
Quoted 4 lines
You forgot to sign off the patch.
But nice to see progress on this!
Can you just add when applying the patch?
Signed-off-by Christoffer Dall <[email protected]>
Andreas,
I wonder if you could change (or add) my new address, as my Linaro address does not work any more (just tested).
Christoffer,
thanks for taking care of this!
Cheers,
Andre.
PATCH 1/1 ARM: enable ARMv7 virt support for the Arndale board
Quoted 24 lines · Andre Przywara
Quoted 21 lines · Christoffer Dall
Quoted 11 lines · Andreas F?rber
Hi,
Am 01.08.2014 13:35, schrieb Christoffer Dall:
Quoted 8 lines
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.Quoted 7 lines
Quoted 2 lines
Reviewed-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>You forgot to sign off the patch.
But nice to see progress on this!
Can you just add when applying the patch?
Quoted 9 lines
Quoted 1 line
Signed-off-by Christoffer Dall <[email protected]>Andreas,
I wonder if you could change (or add) my new address, as my Linaro address does not work any more (just tested).
Signed-off-by Andre Przywara <[email protected]>
So I actually did not know the policy here, given that you did the work under your linaro.org address, so I decided to keep this as they were and just cc your arm address. If you're fine with using the @arm.com address I can respin the patch with the right addresses and signed-off-by's.
-Christoffer
PATCH 1/1 ARM: enable ARMv7 virt support for the Arndale board
Quoted 32 lines · Christoffer Dall
Quoted 31 lines · Andre Przywara
Quoted 15 lines · Christoffer Dall
Quoted 14 lines · Andreas F?rber
Hi,
Am 01.08.2014 13:35, schrieb Christoffer Dall:
Quoted 10 lines
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.Reviewed-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>Quoted 7 lines
Quoted 4 lines
You forgot to sign off the patch.
But nice to see progress on this!
Can you just add when applying the patch?
Signed-off-by Christoffer Dall <[email protected]>Andreas,
I wonder if you could change (or add) my new address, as my Linaro address does not work any more (just tested).
Quoted 7 lines
Quoted 2 lines
Signed-off-by Andre Przywara <[email protected]>So I actually did not know the policy here, given that you did the work under your linaro.org address, so I decided to keep this as they were and just cc your arm address. If you're fine with using the @arm.com address I can respin the patch with the right addresses and signed-off-by's.
I don't know about the policy either - actually I hoped you could help here ;-) I am perfectly fine with giving Linaro as a sponsor credit for this, but I am just concerned about potential feedback, which would bounce and at best annoy people. As long as a post goes to a list also I catch it, but private only email would be stuck.
This said I am fine both ways - maybe we keep both addresses for reference in?
Andreas,
could you just add Christoffer's Signed-off-by and my Signed-off-by @arm.com without a respin?
Regards,
Andre.
PATCH 1/1 ARM: enable ARMv7 virt support for the Arndale board
Quoted 51 lines · Andre Przywara
Quoted 32 lines · Christoffer Dall
Quoted 31 lines · Andre Przywara
Quoted 15 lines · Christoffer Dall
Quoted 14 lines · Andreas F?rber
Hi,
Am 01.08.2014 13:35, schrieb Christoffer Dall:
Quoted 10 lines
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.Reviewed-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>Quoted 7 lines
Quoted 4 lines
You forgot to sign off the patch.
But nice to see progress on this!
Can you just add when applying the patch?
Signed-off-by Christoffer Dall <[email protected]>Andreas,
I wonder if you could change (or add) my new address, as my Linaro address does not work any more (just tested).
Quoted 7 lines
Quoted 2 lines
Signed-off-by Andre Przywara <[email protected]>So I actually did not know the policy here, given that you did the work under your linaro.org address, so I decided to keep this as they were and just cc your arm address. If you're fine with using the @arm.com address I can respin the patch with the right addresses and signed-off-by's.
I don't know about the policy either - actually I hoped you could help here ;-) I am perfectly fine with giving Linaro as a sponsor credit for this, but I am just concerned about potential feedback, which would bounce and at best annoy people. As long as a post goes to a list also I catch it, but private only email would be stuck.
This said I am fine both ways - maybe we keep both addresses for reference in?
Quoted 4 lines
Andreas,
could you just add Christoffer's Signed-off-by and my Signed-off-by @arm.com without a respin?
Andreas pointed out that he's not the maintainer, so let's see what the maintainer says :)
all this policy stuff seems to be bikeshedding anyhow.
-Christoffer
PATCH 1/1 ARM: enable ARMv7 virt support for the Arndale board
In reply to Andre PrzywaraAm 01.08.2014 15:29, schrieb Andre Przywara:
Quoted 47 lines · Christoffer Dall
Quoted 30 lines · Andre Przywara
Quoted 29 lines · Christoffer Dall
Quoted 15 lines · Andreas F?rber
Quoted 14 lines
Hi,
Am 01.08.2014 13:35, schrieb Christoffer Dall:
Quoted 10 lines
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.Reviewed-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>Quoted 7 lines
Quoted 4 lines
You forgot to sign off the patch.
But nice to see progress on this!
Can you just add when applying the patch?
Signed-off-by Christoffer Dall <[email protected]>Andreas,
I wonder if you could change (or add) my new address, as my Linaro address does not work any more (just tested).
Quoted 7 lines
Quoted 2 lines
Signed-off-by Andre Przywara <[email protected]>So I actually did not know the policy here, given that you did the work under your linaro.org address, so I decided to keep this as they were and just cc your arm address. If you're fine with using the @arm.com address I can respin the patch with the right addresses and signed-off-by's.
I don't know about the policy either - actually I hoped you could help here ;-) I am perfectly fine with giving Linaro as a sponsor credit for this, but I am just concerned about potential feedback, which would bounce and at best annoy people. As long as a post goes to a list also I catch it, but private only email would be stuck.
This said I am fine both ways - maybe we keep both addresses for reference in?
Quoted 3 lines
Andreas,
could you just add Christoffer's Signed-off-by and my Signed-off-by @arm.com without a respin?
Guys, I just reacted to this patch because I spotted "virt" and we have a small farm of Arndale boards for OBS.
Please take a look at http://www.denx.de/wiki/U-Boot/Custodians, which lists Albert for ARM and Minkyu for Samsung (CC'ed).
Regards,
Andreas
Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
Quoted 8 lines · Christoffer Dall
From: Andre Przywara <[email protected]>
To enable hypervisors utilizing the ARMv7 virtualization extension on the Arndale board, add the simple SMP pen address writer function and add the required configuration variables to switch all cores to HYP mode before launching the OS.
This allows booting KVM and Xen directly from u-boot.
Quoted 4 lines
Reviewed-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>Signed-off-by Christoffer Dall <[email protected]>Signed-off-by Andre Przywara <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140830/fcd58e02/attachment.pgp>