ARM: dts: Add DT changes for display on peach_pi
Subsystems (2)
PATCH v2 1/1 ARM: dts: Add DT changes for display on peach_pi
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add panel phandle needed by dp to enable display on peach_pi.
---
Changes since V1:
Remove "simple-panel" compatible string and use only ""auo,b133htn01".
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)
arch/arm/boot/dts/exynos5800-peach-pi.dts +10 -17
@@ -28,11 +28,13 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx2 2 0>; + power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };
@@ -98,6 +100,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple { + compatible = "auo,b133htn01"; + power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {
@@ -111,22 +119,7 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <150660000>; - hactive = <1920>; - vactive = <1080>; - hfront-porch = <60>; - hback-porch = <172>; - hsync-len = <80>; - vback-porch = <25>; - vfront-porch = <10>; - vsync-len = <10>; - }; - }; + panel = <&panel>; }; &fimd {
Signature · 1 line
1.7.9.5
PATCH v2 1/1 ARM: dts: Add DT changes for display on peach_pi
+Kukjin
Quoted 71 lines · Ajay Kumar
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add panel phandle needed by dp to enable display onpeach_pi.Signed-off-by Ajay Kumar <[email protected]>---
Changes since V1:
Remove "simple-panel" compatible string and use only ""auo,b133htn01".arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)arch/arm/boot/dts/exynos5800-peach-pi.dts +10
-18@@ -28,11 +28,13 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx2 2 0>; + power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };@@ -98,6 +100,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple { + compatible = "auo,b133htn01"; + power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {@@ -111,22 +119,7 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <150660000>; - hactive = <1920>; - vactive = <1080>; - hfront-porch = <60>; - hback-porch = <172>; - hsync-len = <80>; - vback-porch = <25>; - vfront-porch = <10>; - vsync-len = <10>; - }; - }; + panel = <&panel>; }; &fimd { --1.7.9.5
PATCH v2 1/1 ARM: dts: Add DT changes for display on peach_pi
In reply to Ajay KumarHi,
Am 01.08.2014 18:24, schrieb Ajay Kumar:
Quoted 17 lines
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add panel phandle needed by dp to enable display onpeach_pi.Signed-off-by Ajay Kumar <[email protected]>---
Changes since V1:
Remove "simple-panel" compatible string and use only ""auo,b133htn01".arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)arch/arm/boot/dts/exynos5800-peach-pi.dts +0
-0
arch/arm/boot/dts/exynos5800-peach-pi.dts line 36
Quoted 10 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +2
-1@@ -28,11 +28,13 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx2 2 0>;
For Spring I was asked to use GPIO_ACTIVE_* - here that would mean s/0/GPIO_ACTIVE_HIGH/ IIUC and if necessary
#include <dt-bindings/gpio/gpio.h> before the .dtsi #include.
A modified version of your patch for Snow, rebased onto my cleanups, can be found on my spring-next branch.
arch/arm/boot/dts/exynos5800-peach-pi.dts line 104
Quoted 10 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +3
-0+ power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };@@ -98,6 +100,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple {
Nit: panel-simple seems backwards in English language, and given that simple-panel would be referring to the implementation, I used just "panel" for Spring.
arch/arm/boot/dts/exynos5800-peach-pi.dts line 105
Quoted 1 line
arch/arm/boot/dts/exynos5800-peach-pi.dts +1
-0+ compatible = "auo,b133htn01";
FWIW this depends on auo,b133htn01 getting added to Documentation and panel-simple, which I think hasn't happened yet?
Quoted 20 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +3
-10+ power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {@@ -111,22 +119,7 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <150660000>; - hactive = <1920>; - vactive = <1080>; - hfront-porch = <60>; - hback-porch = <172>;
arch/arm/boot/dts/exynos5800-peach-pi.dts line 125
Quoted 10 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +1
-6- hsync-len = <80>; - vback-porch = <25>; - vfront-porch = <10>; - vsync-len = <10>; - }; - }; + panel = <&panel>; }; &fimd {
Regards,
Andreas
Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
PATCH v2 1/1 ARM: dts: Add DT changes for display on peach_pi
Hi Andreas,
Thanks for the comments.
Quoted 23 lines · Andreas F?rber
Hi,
Am 01.08.2014 18:24, schrieb Ajay Kumar:
Quoted 20 lines
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add panel phandle needed by dp to enable display onpeach_pi.Signed-off-by Ajay Kumar <[email protected]>---
Changes since V1:
Remove "simple-panel" compatible string and use only ""auo,b133htn01".arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)arch/arm/boot/dts/exynos5800-peach-pi.dts +0
-0@@ -28,11 +28,13 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; };
Quoted 11 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts line 36
Quoted 7 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +2
-1- backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx2 2 0>;For Spring I was asked to use GPIO_ACTIVE_* - here that would mean s/0/GPIO_ACTIVE_HIGH/ IIUC and if necessary
#include <dt-bindings/gpio/gpio.h> before the .dtsi #include.
Ok. I will use it.
Quoted 17 lines
A modified version of your patch for Snow, rebased onto my cleanups, can be found on my spring-next branch.
arch/arm/boot/dts/exynos5800-peach-pi.dts line 104
Quoted 10 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +3
-0+ power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };@@ -98,6 +100,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple {Nit: panel-simple seems backwards in English language, and given that simple-panel would be referring to the implementation, I used just "panel" for Spring.
Right. All the platforms just use "panel". I will use the same.
Quoted 6 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts line 105
Quoted 1 line
arch/arm/boot/dts/exynos5800-peach-pi.dts +1
-0+ compatible = "auo,b133htn01";FWIW this depends on auo,b133htn01 getting added to Documentation and panel-simple, which I think hasn't happened yet?
This version is already old ;)
Latest version is here:
http://www.spinics.net/lists/devicetree/msg44158.html
I hope it will be(is?) merged!
Ajay
Quoted 37 lines
Quoted 20 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +3
-10+ power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {@@ -111,22 +119,7 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <150660000>; - hactive = <1920>; - vactive = <1080>; - hfront-porch = <60>; - hback-porch = <172>;arch/arm/boot/dts/exynos5800-peach-pi.dts line 125
Quoted 10 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +1
-6- hsync-len = <80>; - vback-porch = <25>; - vfront-porch = <10>; - vsync-len = <10>; - }; - }; + panel = <&panel>; }; &fimd {Regards,
Andreas--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg