drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture

PATCH In review Chen Gang 3 participants 5 messages Aug 4, 2014 – Aug 5, 2014

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Chen Gang

author

2014-08-04 18:24 UTC #0 lore raw

PATCH 1/1 drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture

For HISAX_NETJET, HISAX_NETJET_U or related config needs !__BIG_ENDIAN, so skip microblaze, just like skip all other architectures which have no CONFIG_*_ENDIAN.

The related error (with allmodconfig under microblaze):

CC [M] drivers/isdn/hisax/nj_s.o
drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
drivers/isdn/hisax/nj_s.c:265:2: error: #error "not running on big endian machines now"
#error "not running on big endian machines now"

Signed-off-by Chen Gang <[email protected]>

---
 drivers/isdn/hisax/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/isdn/hisax/Kconfig +2 -2

index 97465ac..eb83d94 100644
@@ -237,7 +237,7 @@ config HISAX_MIC
 
 config HISAX_NETJET
 	bool "NETjet card"
-	depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+	depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
 	depends on VIRT_TO_BUS
 	help
 	  This enables HiSax support for the NetJet from Traverse

@@ -249,7 +249,7 @@ config HISAX_NETJET
 
 config HISAX_NETJET_U
 	bool "NETspider U card"
-	depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+	depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
 	depends on VIRT_TO_BUS
 	help
 	  This enables HiSax support for the Netspider U interface ISDN card

Signature · 1 line

1.7.11.7

Jean Delvare

2014-08-04 19:23 UTC #1 lore raw

Hi Chen Gang,

Quoted 31 lines · Chen Gang

For HISAX_NETJET, HISAX_NETJET_U or related config needs !__BIG_ENDIAN, so skip microblaze, just like skip all other architectures which have no CONFIG_*_ENDIAN.
The related error (with allmodconfig under microblaze):
CC [M] drivers/isdn/hisax/nj_s.o
drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
drivers/isdn/hisax/nj_s.c:265:2: error: #error "not running on big endian machines now"
#error "not running on big endian machines now"
    ^
Signed-off-by Chen Gang <[email protected]>
---
 drivers/isdn/hisax/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/isdn/hisax/Kconfig +1 -1
index 97465ac..eb83d94 100644
@@ -237,7 +237,7 @@ config HISAX_MIC
 
 config HISAX_NETJET
 	bool "NETjet card"
-	depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+	depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
 	depends on VIRT_TO_BUS
 	help
 	  This enables HiSax support for the NetJet from Traverse

drivers/isdn/hisax/Kconfig config HISAX_NETJET · line 255

Quoted 8 lines

drivers/isdn/hisax/Kconfig +1 -1

@@ -249,7 +249,7 @@ config HISAX_NETJET
 
 config HISAX_NETJET_U
 	bool "NETspider U card"
-	depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+	depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
 	depends on VIRT_TO_BUS
 	help
 	  This enables HiSax support for the Netspider U interface ISDN card

Fine with me, however the list is getting long. It would be better if we could depend on a functional symbol rather than a negated list of architectures. Would it make sense to have CONFIG_CPU_LITTLE_ENDIAN defined on all little-endian architectures, so that driver can depend on that if needed?

Alternatively, it might make more sense to list the architectures where these drivers are actually used in practice. I guess that's X86, maybe ARM and IA64, and that's all?

Signature · 2 lines

Jean Delvare
SUSE L3 Support

Geert Uytterhoeven

2014-08-04 19:44 UTC #2 lore raw

Quoted 13 lines · Jean Delvare

Quoted 13 lines

drivers/isdn/hisax/Kconfig +1 -1

@@ -237,7 +237,7 @@ config HISAX_MIC
 
 config HISAX_NETJET
      bool "NETjet card"
-     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
      depends on VIRT_TO_BUS
      help
        This enables HiSax support for the NetJet from Traverse

@@ -249,7 +249,7 @@ config HISAX_NETJET

Quoted 13 lines

drivers/isdn/hisax/Kconfig config HISAX_NETJET · line 255
Quoted 7 lines
drivers/isdn/hisax/Kconfig +1 -1
 config HISAX_NETJET_U
      bool "NETspider U card"
-     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
      depends on VIRT_TO_BUS
      help
        This enables HiSax support for the Netspider U interface ISDN card
Fine with me, however the list is getting long. It would be better if we could depend on a functional symbol rather than a negated list of architectures. Would it make sense to have CONFIG_CPU_LITTLE_ENDIAN defined on all little-endian architectures, so that driver can depend on that if needed?

Yes, that idea pops up once in a while.

BTW, these days little endian PPC is also supported by Linux...

Quoted 3 lines

Alternatively, it might make more sense to list the architectures where these drivers are actually used in practice. I guess that's X86, maybe ARM and IA64, and that's all?

|| COMPILE_TEST ....

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Chen Gang

author

2014-08-05 04:21 UTC #3 lore raw

Quoted 30 lines · Geert Uytterhoeven

Quoted 13 lines · Jean Delvare
Quoted 13 lines
drivers/isdn/hisax/Kconfig +1 -1
@@ -237,7 +237,7 @@ config HISAX_MIC
 
 config HISAX_NETJET
      bool "NETjet card"
-     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
      depends on VIRT_TO_BUS
      help
        This enables HiSax support for the NetJet from Traverse
@@ -249,7 +249,7 @@ config HISAX_NETJET
 
Quoted 13 lines
drivers/isdn/hisax/Kconfig config HISAX_NETJET · line 255
Quoted 7 lines
drivers/isdn/hisax/Kconfig +1 -1
 config HISAX_NETJET_U
      bool "NETspider U card"
-     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
      depends on VIRT_TO_BUS
      help
        This enables HiSax support for the Netspider U interface ISDN card
Fine with me, however the list is getting long. It would be better if we could depend on a functional symbol rather than a negated list of architectures. Would it make sense to have CONFIG_CPU_LITTLE_ENDIAN defined on all little-endian architectures, so that driver can depend on that if needed?
Yes, that idea pops up once in a while.

Quoted 8 lines

BTW, these days little endian PPC is also supported by Linux...
Quoted 3 lines
Alternatively, it might make more sense to list the architectures where these drivers are actually used in practice. I guess that's X86, maybe ARM and IA64, and that's all?
|| COMPILE_TEST ....

OK, thanks, what all of you said sounds reasonable to me.

Hello Geert:

Could you help send the related patch for it?

Thanks.

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Chen Gang

author

2014-08-05 16:30 UTC #4 lore raw

Quoted 33 lines · Chen Gang

Quoted 30 lines · Geert Uytterhoeven
Quoted 13 lines · Jean Delvare
Quoted 13 lines
drivers/isdn/hisax/Kconfig +1 -1
@@ -237,7 +237,7 @@ config HISAX_MIC
 
 config HISAX_NETJET
      bool "NETjet card"
-     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
      depends on VIRT_TO_BUS
      help
        This enables HiSax support for the NetJet from Traverse
@@ -249,7 +249,7 @@ config HISAX_NETJET
 
Quoted 13 lines
drivers/isdn/hisax/Kconfig config HISAX_NETJET · line 255
Quoted 7 lines
drivers/isdn/hisax/Kconfig +1 -1
 config HISAX_NETJET_U
      bool "NETspider U card"
-     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+     depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
      depends on VIRT_TO_BUS
      help
        This enables HiSax support for the Netspider U interface ISDN card
Fine with me, however the list is getting long. It would be better if we could depend on a functional symbol rather than a negated list of architectures. Would it make sense to have CONFIG_CPU_LITTLE_ENDIAN defined on all little-endian architectures, so that driver can depend on that if needed?
Yes, that idea pops up once in a while.

Quoted 9 lines

Quoted 8 lines
BTW, these days little endian PPC is also supported by Linux...
Quoted 3 lines
Alternatively, it might make more sense to list the architectures where these drivers are actually used in practice. I guess that's X86, maybe ARM and IA64, and that's all?
|| COMPILE_TEST ....

If no additional response within 3 days, I shall continue to try to send patch for it.

Excuse me, I need additional thinking of for it, so I plan to send patch for discussing and review within next week end (2014-08-17).

And welcome any members' ideas, suggestions and completions.

Thanks.

Quoted 9 lines

OK, thanks, what all of you said sounds reasonable to me.
Hello Geert:
Could you help send the related patch for it?
Thanks.

Signature · 3 lines

Chen Gang

Open share and attitude like air water and life which God blessed