ladspa-sdk: new package
PATCH 1/3 ladspa-sdk: new package
LADSPA is a standard that allows software audio processors and effects to be plugged into a wide range of audio synthesis and recording packages.
--- package/Config.in | 1 + package/ladspa-sdk/Config.in | 8 +++++ .../ladspa-sdk/ladspa-sdk-01-no-mkdirhier.patch | 18 ++++++++++ .../ladspa-sdk-02-default-ladspa-path.patch | 30 ++++++++++++++++ .../ladspa-sdk-04-fix-linkage-C-plugins.diff | 23 ++++++++++++ .../ladspa-sdk/ladspa-sdk-05-linking-order.patch | 37 ++++++++++++++++++++ .../ladspa-sdk-06-cross-compile-fix.patch | 35 ++++++++++++++++++ package/ladspa-sdk/ladspa-sdk.mk | 27 ++++++++++++++ 8 files changed, 179 insertions(+) create mode 100644 package/ladspa-sdk/Config.in create mode 100644 package/ladspa-sdk/ladspa-sdk-01-no-mkdirhier.patch create mode 100644 package/ladspa-sdk/ladspa-sdk-02-default-ladspa-path.patch create mode 100644 package/ladspa-sdk/ladspa-sdk-04-fix-linkage-C-plugins.diff create mode 100644 package/ladspa-sdk/ladspa-sdk-05-linking-order.patch create mode 100644 package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch create mode 100644 package/ladspa-sdk/ladspa-sdk.mk
package/Config.in +1 -0
@@ -493,6 +493,7 @@ source "package/alsa-lib/Config.in" source "package/audiofile/Config.in" source "package/celt051/Config.in" source "package/fdk-aac/Config.in" +source "package/ladspa-sdk/Config.in" source "package/libao/Config.in" source "package/libcdaudio/Config.in" source "package/libcdio/Config.in"
package/ladspa-sdk/Config.in new file +8 -0
@@ -0,0 +1,8 @@ +config BR2_PACKAGE_LADSPA_SDK + bool "ladspa-sdk" + help + LADSPA is a standard that allows software audio processors and + effects to be plugged into a wide range of audio synthesis and + recording packages. + + http://www.ladspa.org/
package/ladspa-sdk/ladspa-sdk-01-no-mkdirhier.patch new file +18 -0
@@ -0,0 +1,18 @@ +Use mkdir -p instead of mkdirhier to avoid build-dep on xutils-dev +Index: ladspa-sdk/src/makefile +=================================================================== +--- ladspa-sdk.orig/src/makefile 2009-06-05 14:49:37.000000000 +1000 ++++ ladspa-sdk/src/makefile 2009-06-05 14:50:07.000000000 +1000 +@@ -59,9 +59,9 @@ + @echo Test complete. + + install: targets +- -mkdirhier $(INSTALL_PLUGINS_DIR) +- -mkdirhier $(INSTALL_INCLUDE_DIR) +- -mkdirhier $(INSTALL_BINARY_DIR) ++ -mkdir -p $(INSTALL_PLUGINS_DIR) ++ -mkdir -p $(INSTALL_INCLUDE_DIR) ++ -mkdir -p $(INSTALL_BINARY_DIR) + cp ../plugins/* $(INSTALL_PLUGINS_DIR) + cp ladspa.h $(INSTALL_INCLUDE_DIR) + cp ../bin/* $(INSTALL_BINARY_DIR)
package/ladspa-sdk/ladspa-sdk-02-default-ladspa-path.patch new file +30 -0
@@ -0,0 +1,30 @@ +Use a default ladspa path instead of failing when LADSPA_PATH is undefined +Index: ladspa-sdk/src/load.c +=================================================================== +--- ladspa-sdk.orig/src/load.c 2009-06-05 14:52:05.000000000 +1000 ++++ ladspa-sdk/src/load.c 2009-06-05 14:54:04.000000000 +1000 +@@ -54,6 +54,8 @@ + to search. */ + + pcLADSPAPath = getenv("LADSPA_PATH"); ++ if (!pcLADSPAPath) ++ pcLADSPAPath = "/usr/lib/ladspa"; + + if (pcLADSPAPath) { + +Index: ladspa-sdk/src/search.c +=================================================================== +--- ladspa-sdk.orig/src/search.c 2009-06-05 14:52:05.000000000 +1000 ++++ ladspa-sdk/src/search.c 2009-06-05 14:52:57.000000000 +1000 +@@ -99,10 +99,10 @@ + + pcLADSPAPath = getenv("LADSPA_PATH"); + if (!pcLADSPAPath) { ++ pcLADSPAPath = "/usr/lib/ladspa/"; + fprintf(stderr, + "Warning: You do not have a LADSPA_PATH " + "environment variable set.\n"); +- return; + } + + pcStart = pcLADSPAPath;
package/ladspa-sdk/ladspa-sdk-04-fix-linkage-C-plugins.diff new file +23 -0
@@ -0,0 +1,23 @@ +LD does not automatically insert needed libraries, we must specify them +Index: ladspa-sdk/src/makefile +=================================================================== +--- ladspa-sdk.orig/src/makefile 2009-11-03 20:36:21.000000000 -0300 ++++ ladspa-sdk/src/makefile 2009-11-03 20:37:25.000000000 -0300 +@@ -14,7 +14,7 @@ + # + + INCLUDES = -I. +-LIBRARIES = -ldl -lm ++LIBRARIES = -ldl -lm -lc + CFLAGS = $(INCLUDES) -Wall -Werror -O2 -fPIC + CXXFLAGS = $(CFLAGS) + PLUGINS = ../plugins/amp.so \ +@@ -35,7 +35,7 @@ + + ../plugins/%.so: plugins/%.c ladspa.h + $(CC) $(CFLAGS) -o plugins/$*.o -c plugins/$*.c +- $(LD) -o ../plugins/$*.so plugins/$*.o -shared ++ $(LD) -o ../plugins/$*.so plugins/$*.o -shared $(LIBRARIES) + + ../plugins/%.so: plugins/%.cpp ladspa.h + $(CPP) $(CXXFLAGS) -o plugins/$*.o -c plugins/$*.cpp
package/ladspa-sdk/ladspa-sdk-05-linking-order.patch new file +37 -0
@@ -0,0 +1,37 @@ +Description: Correct linking order to prevent FTBFS with GCC4.5 + binutils-gold. +Author: Alessio Treglia <[email protected]> +--- + src/makefile | 15 +++++++++------ + 1 file changed, 9 insertions(+), 6 deletions(-) + +--- ladspa-sdk-1.13.orig/src/makefile ++++ ladspa-sdk-1.13/src/makefile +@@ -90,19 +90,22 @@ targets: $(PLUGINS) $(PROGRAMS) + # + + ../bin/applyplugin: applyplugin.o load.o default.o +- $(CC) $(CFLAGS) $(LIBRARIES) \ ++ $(CC) $(CFLAGS) \ + -o ../bin/applyplugin \ +- applyplugin.o load.o default.o ++ applyplugin.o load.o default.o \ ++ $(LIBRARIES) + + ../bin/analyseplugin: analyseplugin.o load.o default.o +- $(CC) $(CFLAGS) $(LIBRARIES) \ ++ $(CC) $(CFLAGS) \ + -o ../bin/analyseplugin \ +- analyseplugin.o load.o default.o ++ analyseplugin.o load.o default.o \ ++ $(LIBRARIES) + + ../bin/listplugins: listplugins.o search.o +- $(CC) $(CFLAGS) $(LIBRARIES) \ ++ $(CC) $(CFLAGS) \ + -o ../bin/listplugins \ +- listplugins.o search.o ++ listplugins.o search.o \ ++ $(LIBRARIES) + + ############################################################################### + #
package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch new file +35 -0
@@ -0,0 +1,35 @@ +--- ladspa-sdk-1.13.original/src/makefile 2014-04-24 19:59:18.151359520 +0100 ++++ ladspa-sdk-1.13/src/makefile 2014-04-24 20:01:42.820770007 +0100 +@@ -15,8 +15,8 @@ + + INCLUDES = -I. + LIBRARIES = -ldl -lm +-CFLAGS = $(INCLUDES) -Wall -Werror -O3 -fPIC +-CXXFLAGS = $(CFLAGS) ++CFLAGS += $(INCLUDES) -Wall -fPIC ++CXXFLAGS += $(CFLAGS) + PLUGINS = ../plugins/amp.so \ + ../plugins/delay.so \ + ../plugins/filter.so \ +@@ -25,8 +25,8 @@ + PROGRAMS = ../bin/analyseplugin \ + ../bin/applyplugin \ + ../bin/listplugins +-CC = cc +-CPP = c++ ++CC ?= cc ++CXX ?= c++ + + ############################################################################### + # +@@ -38,8 +38,8 @@ + $(LD) -o ../plugins/$*.so plugins/$*.o -shared + + ../plugins/%.so: plugins/%.cpp ladspa.h +- $(CPP) $(CXXFLAGS) -o plugins/$*.o -c plugins/$*.cpp +- $(CPP) -o ../plugins/$*.so plugins/$*.o -shared ++ $(CXX) $(CXXFLAGS) -o plugins/$*.o -c plugins/$*.cpp ++ $(CXX) -o ../plugins/$*.so plugins/$*.o -shared + + ############################################################################### + #
package/ladspa-sdk/ladspa-sdk.mk new file +27 -0
@@ -0,0 +1,27 @@ +################################################################################ +# +# ladspa-sdk +# +################################################################################ + +LADSPA_SDK_VERSION = 1.13 +LADSPA_SDK_SOURCE = ladspa_sdk_$(LADSPA_SDK_VERSION).tgz +LADSPA_SDK_SITE = http://www.ladspa.org/download/ +LADSPA_SDK_LICENSE = LGPLv2.1+ +LADSPA_SDK_LICENSE_FILES = doc/COPYING +LADSPA_SDK_INSTALL_STAGING = YES + +define LADSPA_SDK_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/src targets +endef + +define LADSPA_SDK_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0644 $(@D)/plugins/*.so $(TARGET_DIR)/usr/lib/ladspa/. + $(INSTALL) -D -m 0755 $(@D)/bin/* $(TARGET_DIR)/usr/bin/. +endef + +define LADSPA_SDK_INSTALL_STAGING_CMDS + $(INSTALL) -D -m 0644 $(@D)/src/ladspa.h $(STAGING_DIR)/usr/include/. +endef + +$(eval $(generic-package))
Signature · 1 line
1.7.9.5
PATCH 2/3 caps: new package
CAPS is a collection of audio plugins comprising virtual guitar amplification and a small range of basic classic effects, signal processors and generators of often elementary and occasionally exotic nature.
The plugins aim to satisfy the highest demands in sound quality with maximal computational efficiency and zero latency.
--- package/Config.in | 1 + package/caps/Config.in | 12 ++++++ package/caps/caps-01-cross-compile-fix.patch | 54 ++++++++++++++++++++++++++ package/caps/caps.mk | 21 ++++++++++ 4 files changed, 88 insertions(+) create mode 100644 package/caps/Config.in create mode 100644 package/caps/caps-01-cross-compile-fix.patch create mode 100644 package/caps/caps.mk
package/Config.in +1 -0
@@ -491,6 +491,7 @@ menu "Libraries" menu "Audio/Sound" source "package/alsa-lib/Config.in" source "package/audiofile/Config.in" +source "package/caps/Config.in" source "package/celt051/Config.in" source "package/fdk-aac/Config.in" source "package/ladspa-sdk/Config.in"
package/caps/Config.in new file +12 -0
@@ -0,0 +1,12 @@ +config BR2_PACKAGE_CAPS + bool "caps" + help + CAPS is a collection of audio plugins comprising virtual guitar + amplification and a small range of basic classic effects, signal + processors and generators of often elementary and occasionally + exotic nature. + + The plugins aim to satisfy the highest demands in sound quality + with maximal computational efficiency and zero latency. + + http://quitte.de/dsp/caps.html
package/caps/caps-01-cross-compile-fix.patch new file +54 -0
54 lines not on this page · raw message
package/caps/caps.mk new file +21 -0
@@ -0,0 +1,21 @@ +################################################################################ +# +# caps +# +################################################################################ + +CAPS_VERSION = 0.9.23 +CAPS_SOURCE = caps_$(CAPS_VERSION).tar.bz2 +CAPS_SITE = http://quitte.de/dsp/ +CAPS_LICENSE = GPLv3 +CAPS_LICENSE_FILES = COPYING + +define CAPS_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all +endef + +define CAPS_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR) +endef + +$(eval $(generic-package))
Signature · 1 line
1.7.9.5
PATCH 2/3 caps: new package
Dear Martin Bark,
Thanks for your contribution, and sorry for the slow feedback. Some comments below.
package/Config.in menu "Libraries" · line 494
Quoted 9 lines · Martin Bark
package/Config.in +1
-0@@ -491,6 +491,7 @@ menu "Libraries" menu "Audio/Sound" source "package/alsa-lib/Config.in" source "package/audiofile/Config.in" +source "package/caps/Config.in"
This will have to be rebased on top of the latest master.
package/caps/Config.in line 2
Quoted 7 lines
new file mode 100644
index 0000000..28ff332package/caps/Config.in new file +2
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_CAPS + bool "caps"
Missing dependency on C++ in toolchain. Also, this package uses ladspa.h, so surely it should select BR2_PACKAGE_LADSPA_SDK, no?
package/caps/caps-01-cross-compile-fix.patch
Quoted 5 lines
package/caps/caps-01-cross-compile-fix.patch new file +0
-0
Missing description + Signed-off-by line.
Quoted 7 lines
package/caps/caps.mk new file +1
-0@@ -0,0 +1,21 @@ +################################################################################
package/caps/caps.mk line 11
Quoted 10 lines
package/caps/caps.mk new file +10
-0+# +# caps +# +################################################################################ + +CAPS_VERSION = 0.9.23 +CAPS_SOURCE = caps_$(CAPS_VERSION).tar.bz2 +CAPS_SITE = http://quitte.de/dsp/ +CAPS_LICENSE = GPLv3 +CAPS_LICENSE_FILES = COPYING
CAPS_DEPENDENCIES = ladspa-sdk
maybe ?
package/caps/caps.mk line 14
Quoted 3 lines
package/caps/caps.mk new file +3
-0+ +define CAPS_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all
We normally try to pass $(TARGET_CONFIGURE_OPTS) on the right hand side of $(MAKE), and we pass $(TARGET_MAKE_ENV) on the left hand side of make.
package/caps/caps.mk line 18
Quoted 2 lines
package/caps/caps.mk new file +2
-0+define CAPS_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR)
$(TARGET_MAKE_ENV) on the left hand side, and DESTDIR passed before 'install' would be preferred here.
Otherwise, looks good.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 2/3 caps: new package
Thomas,
Thanks for the feedback
Quoted 7 lines · Thomas Petazzoni
Dear Martin Bark,
Thanks for your contribution, and sorry for the slow feedback. Some comments below.
On Thu, 24 Apr 2014 22:19:43 +0100, Martin Bark wrote:
Quoted 11 lines
package/Config.in menu "Libraries" · line 494
Quoted 9 lines
package/Config.in +1
-0@@ -491,6 +491,7 @@ menu "Libraries" menu "Audio/Sound" source "package/alsa-lib/Config.in" source "package/audiofile/Config.in" +source "package/caps/Config.in"This will have to be rebased on top of the latest master.
will do
Quoted 11 lines
package/caps/Config.in line 2
Quoted 8 lines
new file mode 100644
index 0000000..28ff332package/caps/Config.in new file +2
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_CAPS + bool "caps"Missing dependency on C++ in toolchain. Also, this package uses
ladspa.h, so surely it should selectBR2_PACKAGE_LADSPA_SDK, no?
I'll fix the c++ dependency issue. As per my other email caps includes a copy of the ladsp-sdk header hence it's not a dependency.
Quoted 29 lines
package/caps/caps-01-cross-compile-fix.patch
Quoted 6 lines
package/caps/caps-01-cross-compile-fix.patch new file +0
-0Missing description + Signed-off-by line.
Quoted 7 lines
package/caps/caps.mk new file +1
-0@@ -0,0 +1,21 @@ +################################################################################package/caps/caps.mk line 11
Quoted 10 lines
package/caps/caps.mk new file +10
-0+# +# caps +# +################################################################################ + +CAPS_VERSION = 0.9.23 +CAPS_SOURCE = caps_$(CAPS_VERSION).tar.bz2 +CAPS_SITE = http://quitte.de/dsp/ +CAPS_LICENSE = GPLv3 +CAPS_LICENSE_FILES = COPYING
CAPS_DEPENDENCIES= ladspa-sdk
Quoted 1 line
maybe ?
As above
Quoted 8 lines
package/caps/caps.mk line 14
Quoted 4 lines
package/caps/caps.mk new file +3
-0+ +define CAPS_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) allWe normally try to pass $(TARGET_CONFIGURE_OPTS) on the right hand side of $(MAKE), and we pass $(TARGET_MAKE_ENV) on the left hand side of make.
I'll fix that
Quoted 6 lines
package/caps/caps.mk line 18
Quoted 3 lines
package/caps/caps.mk new file +2
-0+define CAPS_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR)$(TARGET_MAKE_ENV) on the left hand side, and DESTDIR passed before 'install' would be preferred here.
I'll fix that too
Quoted 7 lines
Otherwise, looks good.
Thanks,
Thomas
Thanks
Martin
PATCH 3/3 alsaequal: new package
In reply to Martin BarkAlsaequal is a real-time adjustable equalizer plugin for ALSA. It can be adjusted using an ALSA compatible mixer, like alsamixergui or alsamixer.
Alsaequal uses the Eq CAPS LADSPA Plugin as it's default equalizer.
--- package/Config.in | 1 + package/alsaequal/Config.in | 19 ++++++ .../alsaequal/alsaequal-01-cross-compile-fix.patch | 17 ++++++ package/alsaequal/alsaequal-05_fix-eq-name.patch | 63 ++++++++++++++++++++ .../alsaequal/alsaequal-06_fix-caps-error.patch | 20 +++++++ package/alsaequal/alsaequal.mk | 22 +++++++ package/alsaequal/readme.txt | 59 ++++++++++++++++++ 7 files changed, 201 insertions(+) create mode 100644 package/alsaequal/Config.in create mode 100644 package/alsaequal/alsaequal-01-cross-compile-fix.patch create mode 100644 package/alsaequal/alsaequal-05_fix-eq-name.patch create mode 100644 package/alsaequal/alsaequal-06_fix-caps-error.patch create mode 100644 package/alsaequal/alsaequal.mk create mode 100644 package/alsaequal/readme.txt
package/Config.in +1 -0
@@ -489,6 +489,7 @@ endmenu menu "Libraries" menu "Audio/Sound" +source "package/alsaequal/Config.in" source "package/alsa-lib/Config.in" source "package/audiofile/Config.in" source "package/caps/Config.in"
package/alsaequal/Config.in new file +19 -0
@@ -0,0 +1,19 @@ +config BR2_PACKAGE_ALSAEQUAL + bool "alsaequal" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib + select BR2_PACKAGE_ALSA_LIB + select BR2_PACKAGE_CAPS # Runtime dependency + help + Alsaequal is a real-time adjustable equalizer plugin for ALSA. It + can be adjusted using an ALSA compatible mixer, like alsamixergui + or alsamixer. + + Alsaequal uses the Eq CAPS LADSPA Plugin as it's default + equalizer. + + http://www.thedigitalmachine.net/alsaequal.html + +comment "alsaequal needs a toolchain w/ C++, threads" + depends on !BR2_INSTALL_LIBSTDCPP + depends on !BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
package/alsaequal/alsaequal-01-cross-compile-fix.patch new file +17 -0
@@ -0,0 +1,17 @@ +--- alsaequal-0.6.original/Makefile 2010-03-05 17:30:39.000000000 +0000 ++++ alsaequal-0.6/Makefile 2014-04-24 16:25:59.468030181 +0100 +@@ -4,10 +4,10 @@ + #Q ?= + + # Build Tools +-CC := gcc +-CFLAGS := -I. -O2 -Wall -funroll-loops -ffast-math -fPIC -DPIC +-LD := gcc +-LDFLAGS := -O2 -Wall -shared -lasound ++CC ?= gcc ++CFLAGS += -I. -Wall -ffast-math -fPIC -DPIC ++LD := $(CC) ++LDFLAGS := -shared -lasound + + SND_PCM_OBJECTS = pcm_equal.o ladspa_utils.o + SND_PCM_LIBS =
package/alsaequal/alsaequal-05_fix-eq-name.patch new file +63 -0
63 lines not on this page · raw message
package/alsaequal/alsaequal-06_fix-caps-error.patch new file +20 -0
@@ -0,0 +1,20 @@ +Description: Fix a spurious error with newer caps versions +Origin: vendor, https://aur.archlinux.org/packages/alsaequal/?comments=all +Forwarded: no +Author: Alessandro Ghedini <[email protected]> +Last-Update: 2013-08-30 +Applied-Upstream: *** FIXME *** + +--- a/ctl_equal.c ++++ b/ctl_equal.c +@@ -263,8 +263,8 @@ + for(i = 0; i < equal->num_input_controls; i++) { + if(equal->control_data->control[i].type == LADSPA_CNTRL_INPUT) { + index = equal->control_data->control[i].index; +- if(equal->klass->PortDescriptors[index] != +- (LADSPA_PORT_INPUT | LADSPA_PORT_CONTROL)) { ++ if((equal->klass->PortDescriptors[index] & ++ (LADSPA_PORT_INPUT | LADSPA_PORT_CONTROL)) == 0) { + SNDERR("Problem with control file %s, %d.", controls, index); + return -1; + }
package/alsaequal/alsaequal.mk new file +22 -0
@@ -0,0 +1,22 @@ +################################################################################ +# +# alsaequal +# +################################################################################ + +ALSAEQUAL_VERSION = 0.6 +ALSAEQUAL_SOURCE = alsaequal-$(ALSAEQUAL_VERSION).tar.bz2 +ALSAEQUAL_SITE = http://www.thedigitalmachine.net/tools/ +ALSAEQUAL_LICENSE = LGPLv2.1 +ALSAEQUAL_LICENSE_FILES = COPYING +ALSAEQUAL_DEPENDENCIES = alsa-lib + +define ALSAEQUAL_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all +endef + +define ALSAEQUAL_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR) +endef + +$(eval $(generic-package))
package/alsaequal/readme.txt new file +59 -0
59 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH 3/3 alsaequal: new package
Dear Martin Bark,
package/alsaequal/alsaequal-01-cross-compile-fix.patch
Quoted 6 lines · Martin Bark
package/alsaequal/alsaequal-01-cross-compile-fix.patch new file +0
-0@@ -0,0 +1,17 @@
Description + Signed-off-by.
package/alsaequal/alsaequal-05_fix-eq-name.patch
Quoted 18 lines
package/alsaequal/alsaequal-01-cross-compile-fix.patch new file +17
-0+--- alsaequal-0.6.original/Makefile 2010-03-05 17:30:39.000000000 +0000 ++++ alsaequal-0.6/Makefile 2014-04-24 16:25:59.468030181 +0100 +@@ -4,10 +4,10 @@ + #Q ?= + + # Build Tools +-CC := gcc +-CFLAGS := -I. -O2 -Wall -funroll-loops -ffast-math -fPIC -DPIC +-LD := gcc +-LDFLAGS := -O2 -Wall -shared -lasound ++CC ?= gcc ++CFLAGS += -I. -Wall -ffast-math -fPIC -DPIC ++LD := $(CC) ++LDFLAGS := -shared -lasound + + SND_PCM_OBJECTS = pcm_equal.o ladspa_utils.o + SND_PCM_LIBS =package/alsaequal/alsaequal-05_fix-eq-name.patch +0
-0
Should be alsaequal-02-fix-eq-name.patch (notice the sequence number and the difference between - and _).
Also description + Signed-off-by.
Quoted 16 lines
package/alsaequal/alsaequal.mk new file +10
-0@@ -0,0 +1,22 @@ +################################################################################ +# +# alsaequal +# +################################################################################ + +ALSAEQUAL_VERSION = 0.6 +ALSAEQUAL_SOURCE = alsaequal-$(ALSAEQUAL_VERSION).tar.bz2 +ALSAEQUAL_SITE = http://www.thedigitalmachine.net/tools/ +ALSAEQUAL_LICENSE = LGPLv2.1
package/alsaequal/alsaequal.mk line 20
Quoted 10 lines
package/alsaequal/alsaequal.mk new file +10
-0+ALSAEQUAL_LICENSE_FILES = COPYING +ALSAEQUAL_DEPENDENCIES = alsa-lib + +define ALSAEQUAL_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all +endef + +define ALSAEQUAL_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR) +endef
Same comments here for $(TARGET_MAKE_ENV) and $(TARGET_CONFIGURE_OPTS) as the ones made on the 'caps' package.
So there's really no build dependency on ladspa or caps in alsaequal ?
Like the ladspa-sdk and caps patches, I've marked this one as "Changes requested" in our patch tracking system. Could you resubmit an updated version of those patches?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 3/3 alsaequal: new package
Thomas,
Quoted 4 lines · Thomas Petazzoni
Dear Martin Bark,
On Thu, 24 Apr 2014 22:19:44 +0100, Martin Bark wrote:
Quoted 8 lines
package/alsaequal/alsaequal-01-cross-compile-fix.patch
Quoted 6 lines
package/alsaequal/alsaequal-01-cross-compile-fix.patch new file +0
-0@@ -0,0 +1,17 @@Description + Signed-off-by.
Some of these patches are copies from debian patches hence they lack the description and Signed-off-by. I'll fix this and resubmit.
Quoted 23 lines
package/alsaequal/alsaequal-05_fix-eq-name.patch
Quoted 19 lines
package/alsaequal/alsaequal-01-cross-compile-fix.patch new file +17
-0+--- alsaequal-0.6.original/Makefile 2010-03-05 17:30:39.000000000 +0000 ++++ alsaequal-0.6/Makefile 2014-04-24 16:25:59.468030181 +0100 +@@ -4,10 +4,10 @@ + #Q ?= + + # Build Tools +-CC := gcc +-CFLAGS := -I. -O2 -Wall -funroll-loops -ffast-math -fPIC -DPIC +-LD := gcc +-LDFLAGS := -O2 -Wall -shared -lasound ++CC ?= gcc ++CFLAGS += -I. -Wall -ffast-math -fPIC -DPIC ++LD := $(CC) ++LDFLAGS := -shared -lasound + + SND_PCM_OBJECTS = pcm_equal.o ladspa_utils.o + SND_PCM_LIBS =package/alsaequal/alsaequal-05_fix-eq-name.patch +0
-0Should be alsaequal-02-fix-eq-name.patch (notice the sequence number and the difference between - and _).
Quoted 1 line
Also description + Signed-off-by.
I'll fix that
Quoted 32 lines
Quoted 18 lines
package/alsaequal/alsaequal.mk new file +10
-0@@ -0,0 +1,22 @@ +################################################################################ +# +# alsaequal +# +################################################################################ + +ALSAEQUAL_VERSION = 0.6 +ALSAEQUAL_SOURCE = alsaequal-$(ALSAEQUAL_VERSION).tar.bz2 +ALSAEQUAL_SITE = http://www.thedigitalmachine.net/tools/ +ALSAEQUAL_LICENSE = LGPLv2.1package/alsaequal/alsaequal.mk line 20
Quoted 10 lines
package/alsaequal/alsaequal.mk new file +10
-0+ALSAEQUAL_LICENSE_FILES = COPYING +ALSAEQUAL_DEPENDENCIES = alsa-lib + +define ALSAEQUAL_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all +endef + +define ALSAEQUAL_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR) +endefSame comments here for $(TARGET_MAKE_ENV) and $(TARGET_CONFIGURE_OPTS) as the ones made on the 'caps' package.
Quoted 1 line
So there's really no build dependency on ladspa or caps in alsaequal ?
alsaequal loads the caps 10 band equaliser at runtime hence caps is not a build dependency but is a dependency in Config.in.
Quoted 4 lines
Like the ladspa-sdk and caps patches, I've marked this one as "Changes requested" in our patch tracking system. Could you resubmit an updated version of those patches?
Yes I?ll resubmit patches
Quoted 5 lines
Thanks a lot!
Thomas
Thanks
Martin
PATCH 3/3 alsaequal: new package
Dear Martin Bark,
Quoted 4 lines · Martin Bark
Quoted 1 line
Description + Signed-off-by.
Some of these patches are copies from debian patches hence they lack the description and Signed-off-by. I'll fix this and resubmit.
No problem with patches coming from Debian, but please indicate where they are coming from.
Quoted 7 lines
Quoted 4 lines
Same comments here for $(TARGET_MAKE_ENV) and $(TARGET_CONFIGURE_OPTS) as the ones made on the 'caps' package.
So there's really no build dependency on ladspa or caps in alsaequal ?
alsaequal loads the caps 10 band equaliser at runtime hence caps is not a build dependency but is a dependency in Config.in.
Ok. Maybe put a comment about this somewhere in the Config.in or .mk file.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/3 ladspa-sdk: new package
In reply to Martin BarkDear Martin Bark,
Sorry for the lack of feedback until now on these patches. See below for a number of comments.
Quoted 5 lines · Martin Bark
LADSPA is a standard that allows software audio processors and effects to be plugged into a wide range of audio synthesis and recording packages.
Signed-off-by Martin Bark <[email protected]>
First, looking at LADSPA, it seems like there has been no releases since 2007 or so. Is this still actively developed and used? Googling around, I've seen mentions of a new thing called LV2 which would be a LADSPA replacement.
package/Config.in source "package/alsa-lib/Config.in" · line 496
Quoted 9 lines
package/Config.in +1
-0@@ -493,6 +493,7 @@ source "package/alsa-lib/Config.in" source "package/audiofile/Config.in" source "package/celt051/Config.in" source "package/fdk-aac/Config.in" +source "package/ladspa-sdk/Config.in"
This will have to be rebased on top of the latest master.
package/ladspa-sdk/Config.in line 2
Quoted 11 lines
package/Config.in +0
-0source "package/libao/Config.in" source "package/libcdaudio/Config.in" source "package/libcdio/Config.in"package/ladspa-sdk/Config.in new file +2
-0@@ -0,0 +1,8 @@ +config BR2_PACKAGE_LADSPA_SDK + bool "ladspa-sdk"
I've at least seen that one of the plugins is developed in C++, so a dependency on BR2_INSTALL_LIBSDTCPP is needed here. Look at the manual and other examples on how to add this dependency properly (including the relevant Config.in comment).
package/ladspa-sdk/ladspa-sdk-01-no-mkdirhier.patch line 1
Quoted 7 lines
package/ladspa-sdk/ladspa-sdk-01-no-mkdirhier.patch new file +1
-0@@ -0,0 +1,18 @@ +Use mkdir -p instead of mkdirhier to avoid build-dep on xutils-dev
There should be a Signed-off-by line in all patches, separated with a newline from the patch description and patch contents.
package/ladspa-sdk/ladspa-sdk-04-fix-linkage-C-plugins.diff
Quoted 1 line
package/ladspa-sdk/ladspa-sdk-04-fix-linkage-C-plugins.diff +0
-0
This one does not get applied, as it is named ".diff". And is it really needed?
Also, the sequence number is not consecutive with 02 of the previous patch.
package/ladspa-sdk/ladspa-sdk-05-linking-order.patch line 2
Quoted 8 lines
package/ladspa-sdk/ladspa-sdk-05-linking-order.patch new file +2
-0@@ -0,0 +1,37 @@ +Description: Correct linking order to prevent FTBFS with GCC4.5 + binutils-gold. +Author: Alessio Treglia <[email protected]>
Please add your Signed-off-by here as well, in addition to the Author:
information.
That's typically the kind of patch that worries me: gcc 4.5 has been released years and years ago, and still issues with this compiler have not been solved upstream.
package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch
Quoted 5 lines
package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch new file +0
-0
Missing description + Signed-off-by.
Quoted 9 lines
package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch new file +9
-0+################################################################################ +# +# ladspa-sdk +# +################################################################################ + +LADSPA_SDK_VERSION = 1.13 +LADSPA_SDK_SOURCE = ladspa_sdk_$(LADSPA_SDK_VERSION).tgz +LADSPA_SDK_SITE = http://www.ladspa.org/download/
package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch
Quoted 10 lines
package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch new file +10
-0+LADSPA_SDK_LICENSE = LGPLv2.1+ +LADSPA_SDK_LICENSE_FILES = doc/COPYING +LADSPA_SDK_INSTALL_STAGING = YES + +define LADSPA_SDK_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/src targets +endef + +define LADSPA_SDK_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0644 $(@D)/plugins/*.so $(TARGET_DIR)/usr/lib/ladspa/.
The "." at the end is making the installation fail.
package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch
Quoted 5 lines
package/ladspa-sdk/ladspa-sdk-06-cross-compile-fix.patch new file +5
-0+ $(INSTALL) -D -m 0755 $(@D)/bin/* $(TARGET_DIR)/usr/bin/. +endef + +define LADSPA_SDK_INSTALL_STAGING_CMDS + $(INSTALL) -D -m 0644 $(@D)/src/ladspa.h $(STAGING_DIR)/usr/include/.
Same here.
Also, what about using "make install" instead? Either by patching the makefile to add $(DESTDIR) support, or by passing explicitly values for INSTALL_PLUGINS_DIR, INSTALL_INCLUDE_DIR and INSTALL_BINARY_DIR ?
While waiting for your new version of this patch, I'll mark this patch as "Changes Requested" in our patch tracking system.
Thanks for your contribution!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/3 ladspa-sdk: new package
Thomas,
Quoted 4 lines · Thomas Petazzoni
Dear Martin Bark,
Sorry for the lack of feedback until now on these patches. See below for a number of comments.
That's fine, to be honest I forgot I submitted these patches :)
Quoted 6 lines · Martin Bark
Quoted 4 lines
LADSPA is a standard that allows software audio processors and effects to be plugged into a wide range of audio synthesis and recording packages.
Quoted 6 lines
Quoted 1 line
Signed-off-by Martin Bark <[email protected]>First, looking at LADSPA, it seems like there has been no releases since 2007 or so. Is this still actively developed and used? Googling around, I've seen mentions of a new thing called LV2 which would be a LADSPA replacement.
Originally I started this because I wanted an equaliser for some work i was doing with acoustic echo cancellation. alsaeqaul was a quick easy way to add a equaliser i could change real time. alsaequal needs caps which is an ladsp module hence the 3 patches.
I don't know if ladsp is under active development. Really it's just the definition of an API in a C header file so I think it's not meant to change. It's the packages like caps which implement the interface which i expect to be active.
caps is self contained (it includes a copy of ladsp.h) and does not need this ladsp-sdk package, i added it for completeness.
Is the lack of development activity an issue? I could drop ladsp-sdk if you like. Please let me know your thoughts.
Thanks
Martin
PATCH 1/3 ladspa-sdk: new package
Dear Martin Bark,
Quoted 4 lines · Martin Bark
Quoted 2 lines
Sorry for the lack of feedback until now on these patches. See below for a number of comments.
That's fine, to be honest I forgot I submitted these patches :)
Yeah, it's been a while, but I'm trying to do some clean up of the patch backlog.
Quoted 4 lines
Originally I started this because I wanted an equaliser for some work i was doing with acoustic echo cancellation. alsaeqaul was a quick easy way to add a equaliser i could change real time. alsaequal needs caps which is an ladsp module hence the 3 patches.
Ok.
Quoted 4 lines
I don't know if ladsp is under active development. Really it's just the definition of an API in a C header file so I think it's not meant to change. It's the packages like caps which implement the interface which i expect to be active.
Ok, makes sense. I was a bit worried about the lack of upstream activity, but it is indeed just an API definition, so probably it doesn't make sense for it to move very often.
Quoted 2 lines
caps is self contained (it includes a copy of
ladsp.h) and does not need this ladsp-sdk package, i added it for completeness.
Ah, ok.
Quoted 2 lines
Is the lack of development activity an issue? I could drop ladsp-sdk if you like. Please let me know your thoughts.
Well, if it's not needed for caps, I'd say leave it aside for now.
And for both packages, if you do patches on them to make them work in Buildroot, we generally prefer when some patches are submitted upstream. So that one day, maybe, we can drop those patches when upstream releases a new version.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com