ipv6: reallocate addrconf router for ipv6 address when lo, device up
Subsystems (2)
PATCH 1/1 ipv6: reallocate addrconf router for ipv6 address when lo, device up
Hi David,
Please queue this for 3.4 stable kernel.
It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
The patch can't be applied directly, as it' used the function introduced by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly either. So I had to write this one.
====================
From: Gao feng <[email protected]>
commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
This commit don't have a stable tag, but it fix the bug no reply after loopback down-up.It's very worthy to be applied to stable 3.4 kernels.
The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
--- net/ipv6/addrconf.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
net/ipv6/addrconf.c +12 -2
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)if (sp_ifa->flags & (IFA_F_DADFAILED |IFA_F_TENTATIVE ))continue ; -if (sp_ifa->rt) -continue ; +if (sp_ifa->rt) { +/* This dst has been added to garbage list when +* lo device down, release this obsolete dst and +* reallocate a new router for ifa. +*/ +if (sp_ifa->rt->dst.obsolete >0 ) { +dst_release (sp_ifa->rt); + sp_ifa->rt =NULL ; + }else { +continue ; + } + } sp_rt =addrconf_dst_alloc (idev, &sp_ifa->addr,0 );
-- 1.7.12
David Miller
maintainerFrom: chenweilong <[email protected]>
Date: Thu, 19 Jun 2014 08:50:33 +0800
Quoted 1 line
Please queue this for 3.4 stable kernel.
...
net/ipv6/addrconf.c static void init_loopback(struct net_device *dev) · line 2444
Quoted 1 line
net/ipv6/addrconf.c +1
-0+dst_release (sp_ifa->rt);
dst_release() does not take a "struct rt6_info *", and therefore the compile warns when you try to compile this.
For something like -stable, we should be as conservative as possible, I expect at a minimum that you look at the build for warnings added by your change.
Sorry.
I'll change it.
Quoted 15 lines · David Miller
From: chenweilong <[email protected]>
Date: Thu, 19 Jun 2014 08:50:33 +0800Quoted 1 line
Please queue this for 3.4 stable kernel.
...
net/ipv6/addrconf.c static void init_loopback(struct net_device *dev) · line 2444
Quoted 1 line
net/ipv6/addrconf.c +1
-0+dst_release (sp_ifa->rt);
dst_release()does not take a "structrt6_info*", and therefore the compile warns when you try to compile this.For something like -stable, we should be as conservative as possible, I expect at a minimum that you look at the build for warnings added by your change.