Skip to contentSkip to conversation

Please add my temporary MIPS fixes branch to linux-next

DISCUSSION James Hogan 6 participants 10 messages Jul 30, 2014 – Aug 26, 2014 MIPS

lore
Share & tools
lore
#0 lore raw

Hi Stephen & MIPS people

v3.16 is fast approaching and there are quite a few important MIPS patches pending. Since Ralf appears to be unavailable at the moment I've reviewed and applied some of those patches which are least controversial to a fixes branch with the intention of sending a pull request to Ralf & Linus so that one of them can hopefully merge it before the release.

Please could the following branch be added to linux-next:

git://git.kernel.org/pub/scm/linux/kernel/git/jhogan/mips.git
branch: mips-fixes

Details of fixes below.

Thanks
James

The current shortlog looks like this:

Aaro Koskinen (1):
MIPS: OCTEON: make get_system_type() thread-safe

Markos Chandras (5):
MIPS: syscall: Fix AUDIT value for O32 processes on MIPS64
MIPS: scall64-o32: Fix indirect syscall detection
MIPS: EVA: Add new EVA header
MIPS: Malta: EVA: Rename 'eva_entry' to 'platform_eva_init'
MIPS: CPS: Initialize EVA before bringing up VPEs from secondary cores

Paul Burton (1):
MIPS: prevent user from setting FCSR cause bits

Rob Kendrick (1):
MIPS: math-emu: cp1emu: Fix typo when returning to register file

If I've missed any other critical fixes for v3.16 please let me know.

I haven't included the patches below, even though they are important, as I'm less sure about them. Comments welcome.

This one fixes mips32 debian boot, but changes the layout of the NT_PRSTATUS regset which is accessible through ptrace. I don't believe this will break anything, but there are other patches pending in the patchset to fix up the regset stuff properly anyway (as it is already broken for core dumps) and I don't really want to take the risk without Ralf's okay.

Alex Smith (1):
MIPS: O32/32-bit: Fix bug which can cause incorrect system call
restarts

This one I'm not confident about, hasn't had any comments on the list, and has been broken for quite a while anyway, so I haven't risked it.

Huacai Chen (1):
MIPS: tlbex: fix a missing statement for HUGETLB

#1 lore raw

On 07/30/2014 09:00 AM, James Hogan wrote:
[...]

Quoted 2 lines

... Since Ralf appears to be unavailable at the moment ...

[...]

This doesn't seem to be a temporary situation.

If we want to keep the MIPS architecture in a functioning state, it may make sense to establish an alternate path for merging MIPS patches upstream.

David Daney.

#2 lore raw
In reply to James Hogan
Quoted 10 lines · James Hogan

This one fixes mips32 debian boot, but changes the layout of the NT_PRSTATUS regset which is accessible through ptrace. I don't believe this will break anything, but there are other patches pending in the patchset to fix up the regset stuff properly anyway (as it is already broken for core dumps) and I don't really want to take the risk without Ralf's okay.

Alex Smith (1):
MIPS: O32/32-bit: Fix bug which can cause incorrect system call
restarts

Right now the NT_PRSTATUS regset can't be relied upon to return the same layout anyway, as it can differ depending on whether the kernel is 32- or 64-bit, as well as with a couple of other Kconfig options. Changing it in this patch shouldn't make things any worse. As you say other patches in the series properly fix the regset/core dump situation, though I suppose they aren't too critical for 3.16 as nobody seems to have noticed/cared that core dumps aren't working until now!

Thanks,
Alex

#3 lore raw

Hi Alex,

Quoted 8 lines · Alex Smith
Quoted 7 lines · James Hogan

This one fixes mips32 debian boot, but changes the layout of the NT_PRSTATUS regset which is accessible through ptrace. I don't believe this will break anything, but there are other patches pending in the patchset to fix up the regset stuff properly anyway (as it is already broken for core dumps) and I don't really want to take the risk without Ralf's okay.

Quoted 8 lines
Quoted 3 lines

Alex Smith (1):
MIPS: O32/32-bit: Fix bug which can cause incorrect system call
restarts

Right now the NT_PRSTATUS regset can't be relied upon to return the same layout anyway, as it can differ depending on whether the kernel is 32- or 64-bit, as well as with a couple of other Kconfig options. Changing it in this patch shouldn't make things any worse.

Yeh, that is true, and it does fix a real regression.

Since Ralf does appear to be online I'll apply the patch unless he objects.

Cheers
James

#4 lore raw
In reply to James Hogan

Hi James,

Quoted 11 lines · On Wed, 30 Jul 2014 17:00:29 +0100 James Hogan <[email protected]> wrote:

v3.16 is fast approaching and there are quite a few important MIPS patches pending. Since Ralf appears to be unavailable at the moment I've reviewed and applied some of those patches which are least controversial to a fixes branch with the intention of sending a pull request to Ralf & Linus so that one of them can hopefully merge it before the release.

Please could the following branch be added to linux-next:

git://git.kernel.org/pub/scm/linux/kernel/git/jhogan/mips.git
branch: mips-fixes

Added from today.

Thanks for adding your subsystem tree as a participant of linux-next. As you may know, this is not a judgment of your code. The purpose of linux-next is for integration testing and to lower the impact of conflicts between subsystems in the next merge window.

You will need to ensure that the patches/commits in your tree/series have been:
* submitted under GPL v2 (or later) and include the Contributor's Signed-off-by,
* posted to the relevant mailing list,
* reviewed by you (or another maintainer of your subsystem tree),
* successfully unit tested, and
* destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him to fetch). It is allowed to be rebased if you deem it necessary.

Signature · 3 lines
Cheers,
Stephen Rothwell 
[email protected]
#5 lore raw
In reply to James Hogan

Hi Ralf,

Quoted 7 lines · James Hogan

Hi Stephen & MIPS people

v3.16 is fast approaching and there are quite a few important MIPS patches pending. Since Ralf appears to be unavailable at the moment I've reviewed and applied some of those patches which are least controversial to a fixes branch with the intention of sending a pull request to Ralf & Linus so that one of them can hopefully merge it before the release.

I sent you a pull request for these fixes prior to v3.16 but unfortunately they still missed the release, and only two of the patches were applied in the main v3.17 MIPS merge.

What are you intentions for the remaining fixes from Markos & Aaro? I'm happy for my branch to be dropped from linux-next if you want to apply them yourself, or to drop the two patches you applied so you can merge it cleanly.

Thanks
James

Quoted 57 lines

Please could the following branch be added to linux-next:

git://git.kernel.org/pub/scm/linux/kernel/git/jhogan/mips.git
branch: mips-fixes

Details of fixes below.

Thanks
James

The current shortlog looks like this:

Aaro Koskinen (1):
MIPS: OCTEON: make get_system_type() thread-safe

Markos Chandras (5):
MIPS: syscall: Fix AUDIT value for O32 processes on MIPS64
MIPS: scall64-o32: Fix indirect syscall detection
MIPS: EVA: Add new EVA header
MIPS: Malta: EVA: Rename 'eva_entry' to 'platform_eva_init'
MIPS: CPS: Initialize EVA before bringing up VPEs from secondary cores

Paul Burton (1):
MIPS: prevent user from setting FCSR cause bits

Rob Kendrick (1):
MIPS: math-emu: cp1emu: Fix typo when returning to register file

If I've missed any other critical fixes for v3.16 please let me know.

I haven't included the patches below, even though they are important, as I'm less sure about them. Comments welcome.

This one fixes mips32 debian boot, but changes the layout of the NT_PRSTATUS regset which is accessible through ptrace. I don't believe this will break anything, but there are other patches pending in the patchset to fix up the regset stuff properly anyway (as it is already broken for core dumps) and I don't really want to take the risk without Ralf's okay.

Alex Smith (1):
MIPS: O32/32-bit: Fix bug which can cause incorrect system call
restarts

This one I'm not confident about, hasn't had any comments on the list, and has been broken for quite a while anyway, so I haven't risked it.

Huacai Chen (1):
MIPS: tlbex: fix a missing statement for HUGETLB

#6 lore raw

Hi,

Quoted 9 lines · James Hogan
Quoted 7 lines · James Hogan

Hi Stephen & MIPS people

v3.16 is fast approaching and there are quite a few important MIPS patches pending. Since Ralf appears to be unavailable at the moment I've reviewed and applied some of those patches which are least controversial to a fixes branch with the intention of sending a pull request to Ralf & Linus so that one of them can hopefully merge it before the release.

Quoted 5 lines

I sent you a pull request for these fixes prior to v3.16 but unfortunately they still missed the release, and only two of the patches were applied in the main v3.17 MIPS merge.

What are you intentions for the remaining fixes from Markos & Aaro?

Ralf, any comments? I think at least this fix is imporant, because currently users can hang OCTEON systems simply by lauching multiple readers of the proc file:

https://git.kernel.org/cgit/linux/kernel/git/jhogan/mips.git/commit/?id=08a9c3c9afcf6e8975fc1c9a97e871e6a039c25a

A.

#7 lore raw
Quoted 18 lines · Aaro Koskinen

Hi,

Quoted 9 lines · James Hogan
Quoted 7 lines · James Hogan

Hi Stephen & MIPS people

v3.16 is fast approaching and there are quite a few important MIPS patches pending. Since Ralf appears to be unavailable at the moment I've reviewed and applied some of those patches which are least controversial to a fixes branch with the intention of sending a pull request to Ralf & Linus so that one of them can hopefully merge it before the release.

Quoted 5 lines

I sent you a pull request for these fixes prior to v3.16 but unfortunately they still missed the release, and only two of the patches were applied in the main v3.17 MIPS merge.

What are you intentions for the remaining fixes from Markos & Aaro?

Quoted 8 lines

Ralf, any comments? I think at least this fix is imporant, because currently users can hang OCTEON systems simply by lauching multiple readers of the proc file:

https://git.kernel.org/cgit/linux/kernel/git/jhogan/mips.git/commit/?id=08a9c3c9afcf6e8975fc1c9a97e871e6a039c25a

A.

Hi,

I plan to send GregKH another set of fixes to backport to 3.16, and since this patch is now in mainline[1], I will include this one as well.

[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=608308682addfdc7b8e2aee88f0e028331d88e4d

Signature · 1 line
markos
#8 lore raw
Quoted 27 lines · Markos Chandras
Quoted 18 lines · Aaro Koskinen

Hi,

Quoted 9 lines · James Hogan
Quoted 7 lines · James Hogan

Hi Stephen & MIPS people

v3.16 is fast approaching and there are quite a few important MIPS patches pending. Since Ralf appears to be unavailable at the moment I've reviewed and applied some of those patches which are least controversial to a fixes branch with the intention of sending a pull request to Ralf & Linus so that one of them can hopefully merge it before the release.

Quoted 5 lines

I sent you a pull request for these fixes prior to v3.16 but unfortunately they still missed the release, and only two of the patches were applied in the main v3.17 MIPS merge.

What are you intentions for the remaining fixes from Markos & Aaro?

Quoted 8 lines

Ralf, any comments? I think at least this fix is imporant, because currently users can hang OCTEON systems simply by lauching multiple readers of the proc file:

https://git.kernel.org/cgit/linux/kernel/git/jhogan/mips.git/commit/?id=08a9c3c9afcf6e8975fc1c9a97e871e6a039c25a

A.

Quoted 7 lines

Hi,

I plan to send GregKH another set of fixes to backport to 3.16, and since this patch is now in mainline[1], I will include this one as well.

[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=608308682addfdc7b8e2aee88f0e028331d88e4d

This particular fix is already marked for stable.

The ones I applied that aren't marked for stable (but are now needed in linux-3.16.y) are:

f85b71ceabb9 MIPS: EVA: Add new EVA header
ca4d24f7954f MIPS: Malta: EVA: Rename 'eva_entry' to 'platform_eva_init' 6521d9a436a6 MIPS: CPS: Initialize EVA before bringing up VPEs from secondary cores

Cheers
James

#9 lore raw
Quoted 30 lines · James Hogan
Quoted 29 lines · Markos Chandras
Quoted 18 lines · Aaro Koskinen

Hi,

Quoted 9 lines · James Hogan
Quoted 7 lines · James Hogan

Hi Stephen & MIPS people

v3.16 is fast approaching and there are quite a few important MIPS patches pending. Since Ralf appears to be unavailable at the moment I've reviewed and applied some of those patches which are least controversial to a fixes branch with the intention of sending a pull request to Ralf & Linus so that one of them can hopefully merge it before the release.

Quoted 5 lines

I sent you a pull request for these fixes prior to v3.16 but unfortunately they still missed the release, and only two of the patches were applied in the main v3.17 MIPS merge.

What are you intentions for the remaining fixes from Markos & Aaro?

Quoted 8 lines

Ralf, any comments? I think at least this fix is imporant, because currently users can hang OCTEON systems simply by lauching multiple readers of the proc file:

https://git.kernel.org/cgit/linux/kernel/git/jhogan/mips.git/commit/?id=08a9c3c9afcf6e8975fc1c9a97e871e6a039c25a

A.

Hi,

Quoted 7 lines
Quoted 5 lines

I plan to send GregKH another set of fixes to backport to 3.16, and since this patch is now in mainline[1], I will include this one as well.

[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=608308682addfdc7b8e2aee88f0e028331d88e4d

This particular fix is already marked for stable.

True I didn't notice. Thanks!

Signature · 1 line
markos