Skip to contentSkip to conversation

Fix invalid interface calls

PATCH New Sven Vermeulen 2 participants 10 messages Aug 8, 2014 – Aug 14, 2014

lore
Share & tools
lore
#0 lore raw

cover Fix invalid interface calls

Found a few inconsistencies in the policy while scripting up some QA.

Sven Vermeulen (8):
Use logging_search_logs, not logging_search_log
Use logging_search_logs, not logging_search_log
Use files_search_etc, not logging_search_etc
Use files_search_etc, not logging_search_etc
Use files_search_etc, not files_search_config
Use corecmd_search_bin, not corecmd_searh_bin
Use fs_search_tmpfs, not files_search_tmpfs
Use domain_auto_trans, not auto_trans

 ircd.if           | 2 +-
 monop.if          | 2 +-
 networkmanager.if | 2 +-
 nslcd.if          | 2 +-
 rsync.if          | 2 +-
 smstools.if       | 2 +-
 tgtd.if           | 2 +-
 zarafa.if         | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.5.5
#1 lore raw

PATCH 1/8 Use logging_search_logs, not logging_search_log

---
 ircd.if | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ircd.if +1 -1
index ade9803..1a88664 100644
@@ -34,7 +34,7 @@ interface(`ircd_admin',`
 	files_search_etc($1)
 	admin_pattern($1, ircd_etc_t)
 
-	logging_search_log($1)
+	logging_search_logs($1)
 	admin_pattern($1, ircd_log_t)
 
 	files_search_var_lib($1)
Signature · 1 line
1.8.5.5
#2 lore raw

PATCH 2/8 Use logging_search_logs, not logging_search_log

In reply to Sven Vermeulen
---
 zarafa.if | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
zarafa.if +1 -1
index 36e32df..83b4ca5 100644
@@ -163,7 +163,7 @@ interface(`zarafa_admin',`
 	files_search_tmp($1)
 	admin_pattern($1, { zarafa_deliver_tmp_t zarafa_indexer_tmp_t zarafa_server_tmp_t })
 
-	logging_search_log($1)
+	logging_search_logs($1)
 	admin_pattern($1, zarafa_logfile)
 
 	files_search_var_lib($1)
Signature · 1 line
1.8.5.5
#3 lore raw

PATCH 3/8 Use files_search_etc, not logging_search_etc

In reply to Sven Vermeulen
---
 monop.if | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
monop.if +1 -1
index 8fdaece..a6ec137 100644
@@ -31,7 +31,7 @@ interface(`monop_admin',`
 	role_transition $2 monopd_initrc_exec_t system_r;
 	allow $2 system_r;
 
-	logging_search_etc($1)
+	files_search_etc($1)
 	admin_pattern($1, monopd_etc_t)
 
 	files_search_pids($1)
Signature · 1 line
1.8.5.5
#4 lore raw

PATCH 4/8 Use files_search_etc, not logging_search_etc

In reply to Sven Vermeulen
---
 networkmanager.if | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
networkmanager.if +1 -1
index 86dc29d..baebe99 100644
@@ -302,7 +302,7 @@ interface(`networkmanager_admin',`
 	role_transition $2 NetworkManager_initrc_exec_t system_r;
 	allow $2 system_r;
 
-	logging_search_etc($1)
+	files_search_etc($1)
 	admin_pattern($1, { NetworkManager_etc_t NetworkManager_etc_rw_t })
 
 	logging_search_logs($1)
Signature · 1 line
1.8.5.5
#5 lore raw

PATCH 5/8 Use files_search_etc, not files_search_config

In reply to Sven Vermeulen
---
 smstools.if | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
smstools.if +1 -1
index cbfe369..81136f0 100644
@@ -32,7 +32,7 @@ interface(`smstools_admin',`
 	role_transition $2 smsd_initrc_exec_t system_r;
 	allow $2 system_r;
 
-	files_search_config($1)
+	files_search_etc($1)
 	admin_pattern($1, smsd_conf_t)
 
 	files_search_var_lib($1)
Signature · 1 line
1.8.5.5
#6 lore raw

PATCH 6/8 Use corecmd_search_bin, not corecmd_searh_bin

In reply to Sven Vermeulen
---
 nslcd.if | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
nslcd.if +1 -1
index 97df768..bbd7cac 100644
@@ -15,7 +15,7 @@ interface(`nslcd_domtrans',`
 		type nslcd_t, nslcd_exec_t;
 	')
 
-	corecmd_searh_bin($1)
+	corecmd_search_bin($1)
 	domtrans_pattern($1, nslcd_exec_t, nslcd_t)
 ')
 
Signature · 1 line
1.8.5.5
#7 lore raw

PATCH 7/8 Use fs_search_tmpfs, not files_search_tmpfs

In reply to Sven Vermeulen
---
 tgtd.if | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tgtd.if +1 -1
index 5406b6e..dc5b46e 100644
@@ -97,6 +97,6 @@ interface(`tgtd_admin',`
 	files_search_tmp($1)
 	admin_pattern($1, tgtd_tmp_t)
 
-	files_search_tmpfs($1)
+	fs_search_tmpfs($1)
 	admin_pattern($1, tgtd_tmpfs_t)
 ')
Signature · 1 line
1.8.5.5
#8 lore raw

PATCH 8/8 Use domain_auto_trans, not auto_trans

In reply to Sven Vermeulen
---
 rsync.if | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
rsync.if +1 -1
index f1140ef..431471b 100644
@@ -50,7 +50,7 @@ interface(`rsync_entry_spec_domtrans',`
 	')
 
 	corecmd_search_bin($1)
-	auto_trans($1, rsync_exec_t, $2)
+	domain_auto_trans($1, rsync_exec_t, $2)
 ')
 
 ########################################
Signature · 1 line
1.8.5.5
#9 lore raw

cover Fix invalid interface calls

In reply to Sven Vermeulen
Quoted 12 lines · Sven Vermeulen

Found a few inconsistencies in the policy while scripting up some QA.

Sven Vermeulen (8):
Use logging_search_logs, not logging_search_log
Use logging_search_logs, not logging_search_log
Use files_search_etc, not logging_search_etc
Use files_search_etc, not logging_search_etc
Use files_search_etc, not files_search_config
Use corecmd_search_bin, not corecmd_searh_bin
Use fs_search_tmpfs, not files_search_tmpfs
Use domain_auto_trans, not auto_trans

Quoted 9 lines
 ircd.if           | 2 +-
 monop.if          | 2 +-
 networkmanager.if | 2 +-
 nslcd.if          | 2 +-
 rsync.if          | 2 +-
 smstools.if       | 2 +-
 tgtd.if           | 2 +-
 zarafa.if         | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

This set is merged.

Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com