cm-t54: misc board fixes, convert to generic board

Fix MAC address data read (from EEPROM) issue and boot mode check. Convert to generic board.

Dmitry Lifshitz (3):
cm-t54: fix EEPROM read return value check
cm-t54: fix eMMC boot mode check
cm-t54: convert to generic board

 board/compulab/cm_t54/cm_t54.c |    6 +++---
 include/configs/cm_t54.h       |    3 +++
 2 files changed, 6 insertions(+), 3 deletions(-)

1.7.5.4

Fix cl_eeprom_read_mac_addr() return value check. Fix long line codding style issue in board_init().

---
 board/compulab/cm_t54/cm_t54.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

index fadfddc..306491b 100644
@@ -43,7 +43,7 @@ const struct omap_sysinfo sysinfo = {
  */
 int board_init(void)
 {
-	gd->bd->bi_boot_params = (CONFIG_SYS_SDRAM_BASE + 0x100); /* boot param addr */
+	gd->bd->bi_boot_params = (CONFIG_SYS_SDRAM_BASE + 0x100);
 
 	return 0;
 }

@@ -169,7 +169,7 @@ static int handle_mac_address(void)
 		return 0;
 
 	ret = cl_eeprom_read_mac_addr(enetaddr);
-	if (!ret || !is_valid_ether_addr(enetaddr))
+	if (ret || !is_valid_ether_addr(enetaddr))
 		generate_mac_addr(enetaddr);
 
 	if (!is_valid_ether_addr(enetaddr))

1.7.5.4

Applied to u-boot-ti/master, thanks!

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140825/88fa1b99/attachment-0001.pgp>

Boot from eMMC boot partition corresponds to BOOT_DEVICE_MMC2 omap_bootmode, while BOOT_DEVICE_MMC2_2 corresponds to the user data partition boot.

Fix mmc_get_env_part() boot mode check to use a correct value.

---
 board/compulab/cm_t54/cm_t54.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

index 306491b..944b723 100644
@@ -89,7 +89,7 @@ uint mmc_get_env_part(struct mmc *mmc)
 	 * If booted from eMMC boot partition then force eMMC
 	 * FIRST boot partition to be env storage
 	 */
-	if (bootmode == BOOT_DEVICE_MMC2_2)
+	if (bootmode == BOOT_DEVICE_MMC2)
 		bootpart = 1;
 
 	return bootpart;

1.7.5.4

Applied to u-boot-ti/master, thanks!

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140825/6514d10f/attachment.pgp>

Use generic board setup functions by defining
CONFIG_SYS_GENERIC_BOARD.

---
 include/configs/cm_t54.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

index db04095..df93a59 100644
@@ -19,6 +19,9 @@
 #undef CONFIG_MISC_INIT_R
 #undef CONFIG_SPL_OS_BOOT
 
+/* Enable Generic board */
+#define CONFIG_SYS_GENERIC_BOARD
+
 /* Device Tree defines */
 #define CONFIG_OF_LIBFDT
 #define CONFIG_OF_BOARD_SETUP

1.7.5.4

Applied to u-boot-ti/master, thanks!

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140825/1f2d399b/attachment.pgp>

Gentle ping...

Regards,
Igor.