Skip to contentSkip to conversation

kconfig: remove DEFCONFIG_LIST

PATCH In review Masahiro Yamada 3 participants 3 messages Aug 15, 2014 – Aug 23, 2014

lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 kconfig: remove DEFCONFIG_LIST

CONFIG_DEFCONFIG_LIST specifies the default defconfig. It is used by "make savedefconfig" when .config is missing. But that's it. I could not find other useful cases.

As a side effect, CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig" is contained in .config of every target board, which some people think is odd. So, let's remove it.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>

---

 Kconfig | 6 ------
 1 file changed, 6 deletions(-)
Kconfig +0 -6
index 9e77a6e..1a38645 100644
@@ -12,12 +12,6 @@ config KCONFIG_OBJDIR
 	string
 	option env="KCONFIG_OBJDIR"
 
-config DEFCONFIG_LIST
-	string
-	depends on !SPL_BUILD
-	option defconfig_list
-	default "configs/sandbox_defconfig"
-
 menu "General setup"
 
 config SPL_BUILD
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 kconfig: remove DEFCONFIG_LIST

Quoted 11 lines · Masahiro Yamada

CONFIG_DEFCONFIG_LIST specifies the default defconfig. It is used by "make savedefconfig" when .config is missing. But that's it. I could not find other useful cases.

As a side effect, CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig" is contained in .config of every target board, which some people think is odd. So, let's remove it.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>

---

Great.

Acked-by Michal Simek <[email protected]>

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140819/67babdab/attachment.pgp>
#2 lore raw
In reply to Masahiro Yamada
Quoted 11 lines · Masahiro Yamada

CONFIG_DEFCONFIG_LIST specifies the default defconfig. It is used by "make savedefconfig" when .config is missing. But that's it. I could not find other useful cases.

As a side effect, CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig" is contained in .config of every target board, which some people think is odd. So, let's remove it.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>
Acked-by Michal Simek <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140823/d8bd400e/attachment.pgp>