fs/fsstress: modify compile warning about fsstress.c
PATCH 1/1 fs/fsstress: modify compile warning about fsstress.c
when compile kernel/fs/fsstress/fsstress.c, some warning always be printed. Because there is a new field 'isxfs' be added in opdesc_t struct, but some lines of opdesc_t ops[] forget to init this field.
---
Hi,
Ping ...
I have sent my two patch for a long time, but no response until now. If there are any problems you don't want to merge it, please tell me.
(Re-send this patch again now. )
Thank you,
Zorro Lang
testcases/kernel/fs/fsstress/fsstress.c | 40 ++++++++++++++++----------------- 1 file changed, 20 insertions(+), 20 deletions(-)
(quoted diff) +0 -0
b/testcases/kernel/fs/fsstress/fsstress.c
index 4a8a1c2..1783783 100644
testcases/kernel/fs/fsstress/fsstress.c +20 -20
@@ -164,35 +164,35 @@ opdesc_t ops[] = { {OP_BULKSTAT, "bulkstat", bulkstat_f, 1, 0, 1}, {OP_BULKSTAT1, "bulkstat1", bulkstat1_f, 1, 0, 1}, #endif - {OP_CHOWN, "chown", chown_f, 3, 1}, - {OP_CREAT, "creat", creat_f, 4, 1}, - {OP_DREAD, "dread", dread_f, 4, 0}, - {OP_DWRITE, "dwrite", dwrite_f, 4, 1}, - {OP_FDATASYNC, "fdatasync", fdatasync_f, 1, 1}, + {OP_CHOWN, "chown", chown_f, 3, 1, 0}, + {OP_CREAT, "creat", creat_f, 4, 1, 0}, + {OP_DREAD, "dread", dread_f, 4, 0, 0}, + {OP_DWRITE, "dwrite", dwrite_f, 4, 1, 0}, + {OP_FDATASYNC, "fdatasync", fdatasync_f, 1, 1, 0}, #ifndef NO_XFS {OP_FREESP, "freesp", freesp_f, 1, 1, 1}, #endif - {OP_FSYNC, "fsync", fsync_f, 1, 1}, - {OP_GETDENTS, "getdents", getdents_f, 1, 0}, - {OP_LINK, "link", link_f, 1, 1}, - {OP_MKDIR, "mkdir", mkdir_f, 2, 1}, - {OP_MKNOD, "mknod", mknod_f, 2, 1}, - {OP_READ, "read", read_f, 1, 0}, - {OP_READLINK, "readlink", readlink_f, 1, 0}, - {OP_RENAME, "rename", rename_f, 2, 1}, + {OP_FSYNC, "fsync", fsync_f, 1, 1, 0}, + {OP_GETDENTS, "getdents", getdents_f, 1, 0, 0}, + {OP_LINK, "link", link_f, 1, 1, 0}, + {OP_MKDIR, "mkdir", mkdir_f, 2, 1, 0}, + {OP_MKNOD, "mknod", mknod_f, 2, 1, 0}, + {OP_READ, "read", read_f, 1, 0, 0}, + {OP_READLINK, "readlink", readlink_f, 1, 0, 0}, + {OP_RENAME, "rename", rename_f, 2, 1, 0}, #ifndef NO_XFS {OP_RESVSP, "resvsp", resvsp_f, 1, 1, 1}, #endif - {OP_RMDIR, "rmdir", rmdir_f, 1, 1}, - {OP_STAT, "stat", stat_f, 1, 0}, - {OP_SYMLINK, "symlink", symlink_f, 2, 1}, - {OP_SYNC, "sync", sync_f, 1, 0}, - {OP_TRUNCATE, "truncate", truncate_f, 2, 1}, - {OP_UNLINK, "unlink", unlink_f, 1, 1}, + {OP_RMDIR, "rmdir", rmdir_f, 1, 1, 0}, + {OP_STAT, "stat", stat_f, 1, 0, 0}, + {OP_SYMLINK, "symlink", symlink_f, 2, 1, 0}, + {OP_SYNC, "sync", sync_f, 1, 0, 0}, + {OP_TRUNCATE, "truncate", truncate_f, 2, 1, 0}, + {OP_UNLINK, "unlink", unlink_f, 1, 1, 0}, #ifndef NO_XFS {OP_UNRESVSP, "unresvsp", unresvsp_f, 1, 1, 1}, #endif - {OP_WRITE, "write", write_f, 4, 1}, + {OP_WRITE, "write", write_f, 4, 1, 0}, }, *ops_end; flist_t flist[FT_nft] = {
Signature · 11 lines
1.9.3 ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Hi!
Quoted 3 lines
when compile
kernel/fs/fsstress/fsstress.c, some warning always be printed. Because there is a new field 'isxfs' be added inopdesc_tstruct, but some lines ofopdesc_tops[] forget to init this field.
The changes looks good but 'git am' says:
Applying: fs/fsstress: modify compile warning about fsstress.c
fatal: corrupt patch at line 81
Can you please resend (preferably generated by 'git format-patch' or send by 'git send-email')?
Signature · 11 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi!
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
when compile
kernel/fs/fsstress/fsstress.c, some warning always be printed. Because there is a new field 'isxfs' be added inopdesc_tstruct, but some lines ofopdesc_tops[] forget to init this field.The changes looks good but 'git am' says:
Applying: fs/fsstress: modify compile warning about
fsstress.c
fatal: corrupt patch at line 81
Quoted 7 lines
Quoted 3 lines
Can you please resend (preferably generated by 'git format-patch' or send by 'git send-email')?
Sorry about that. Because there is no reply for long time, I edited the patch email by my thunderbird(an email tool) and re-sent to you. I think that changed the format of the patch.
I will resend my two patches aboutfsstress.clater.
That explains it, thunderbird is known for mangling patches. There is a howto for configuring it not to do that in linux kernel source in Documentation/email-clients.txt.
Signature · 11 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list