ARM: dts: Add display DT changes for snow, peach_pit and peach_pi
Subsystems (2)
cover ARM: dts: Add display DT changes for snow, peach_pit and peach_pi
This series is based on dt-samsung branch of Kukjin's samsung repository at:git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
Add DT changes needed for bridge chips, panels and backlight on snow, peach_pit and peach_pi.
To test these patches, you need the latest version of bridge chip series:
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34667.html
Ajay Kumar (3):
[PATCH 1/3] ARM: dts: Add DT changes for display on snow [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++------------- arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++------------ arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 +++++++------------ 3 files changed, 50 insertions(+), 53 deletions(-)
Signature · 1 line
1.7.9.5
PATCH 1/3 ARM: dts: Add DT changes for display on snow
Add DT nodes for ptn3460 bridge chip and panel-simple panel. Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.
--- arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++---------------- 1 file changed, 21 insertions(+), 19 deletions(-)
arch/arm/boot/dts/exynos5250-snow.dts +21 -19
@@ -270,7 +270,7 @@ dcdc3 { ti,enable-ext-control; }; - fet1 { + fet1: fet1 { regulator-name = "vcd_led"; ti,overcurrent-wait = <3>; };
@@ -293,7 +293,7 @@ regulator-always-on; ti,overcurrent-wait = <3>; }; - fet6 { + fet6: fet6 { regulator-name = "lcd_vdd"; ti,overcurrent-wait = <3>; };
@@ -342,6 +342,15 @@ pinctrl-0 = <&max98095_en>; pinctrl-names = "default"; }; + + ptn3460: ptn3460-bridge at 20 { + compatible = "nxp,ptn3460"; + reg = <0x20>; + powerdown-gpios = <&gpy2 5 0>; + reset-gpios = <&gpx1 5 0>; + edid-emulation = <5>; + panel = <&panel>; + }; }; i2s0: i2s at 03830000 {
@@ -389,11 +398,13 @@ vdd_pll-supply = <&ldo8_reg>; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx3 0 0>; + power-supply = <&fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };
@@ -403,6 +414,12 @@ samsung,invert-vclk; }; + panel: panel-simple { + compatible = "simple-panel"; + power-supply = <&fet6>; + backlight = <&backlight>; + }; + dp-controller at 145B0000 { status = "okay"; pinctrl-names = "default";
@@ -414,21 +431,6 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx0 7 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <70589280>; - hactive = <1366>; - vactive = <768>; - hfront-porch = <40>; - hback-porch = <40>; - hsync-len = <32>; - vback-porch = <10>; - vfront-porch = <12>; - vsync-len = <6>; - }; - }; + bridge = <&ptn3460>; }; };
Signature · 1 line
1.7.9.5
PATCH 1/3 ARM: dts: Add DT changes for display on snow
Am 25.07.2014 21:44, schrieb Ajay Kumar:
Quoted 1 line
Add DT nodes for ptn3460 bridge chip and panel-simple panel.
"simple-panel"
Quoted 31 lines
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.
Signed-off-by Ajay Kumar <[email protected]>--- arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++---------------- 1 file changed, 21 insertions(+), 19 deletions(-)arch/arm/boot/dts/exynos5250-snow.dts +2
-2@@ -270,7 +270,7 @@ dcdc3 { ti,enable-ext-control; }; - fet1 { + fet1: fet1 { regulator-name = "vcd_led"; ti,overcurrent-wait = <3>; };@@ -293,7 +293,7 @@ regulator-always-on; ti,overcurrent-wait = <3>; }; - fet6 { + fet6: fet6 { regulator-name = "lcd_vdd"; ti,overcurrent-wait = <3>; };
arch/arm/boot/dts/exynos5250-snow.dts line 346
Quoted 5 lines
arch/arm/boot/dts/exynos5250-snow.dts +2
-0@@ -342,6 +342,15 @@ pinctrl-0 = <&max98095_en>; pinctrl-names = "default"; }; + + ptn3460: ptn3460-bridge at 20 {
"lvds-bridge"? (AF)
Quoted 26 lines
arch/arm/boot/dts/exynos5250-snow.dts +10
-1+ compatible = "nxp,ptn3460"; + reg = <0x20>; + powerdown-gpios = <&gpy2 5 0>; + reset-gpios = <&gpx1 5 0>; + edid-emulation = <5>; + panel = <&panel>; + }; }; i2s0: i2s at 03830000 {@@ -389,11 +398,13 @@ vdd_pll-supply = <&ldo8_reg>; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx3 0 0>; + power-supply = <&fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };
arch/arm/boot/dts/exynos5250-snow.dts line 417
Quoted 4 lines
arch/arm/boot/dts/exynos5250-snow.dts +1
-0@@ -403,6 +414,12 @@ samsung,invert-vclk; }; + panel: panel-simple {
Just "panel"? (AF)
arch/arm/boot/dts/exynos5250-snow.dts line 418
Quoted 1 line
arch/arm/boot/dts/exynos5250-snow.dts +1
-0+ compatible = "simple-panel";
Use something more concrete than "simple-panel"? (Thierry)
Quoted 20 lines
arch/arm/boot/dts/exynos5250-snow.dts +4
-9+ power-supply = <&fet6>; + backlight = <&backlight>; + }; + dp-controller at 145B0000 { status = "okay"; pinctrl-names = "default";@@ -414,21 +431,6 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx0 7 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <70589280>; - hactive = <1366>; - vactive = <768>; - hfront-porch = <40>;
arch/arm/boot/dts/exynos5250-snow.dts line 436
Quoted 10 lines
arch/arm/boot/dts/exynos5250-snow.dts +1
-7- hback-porch = <40>; - hsync-len = <32>; - vback-porch = <10>; - vfront-porch = <12>; - vsync-len = <6>; - }; - }; + bridge = <&ptn3460>; }; };
This patch will trivially conflict with my Snow cleanup [1]; ptn3460 would go into the appropriate &i2c_* and this hunk into &dp then.
Regards,
Andreas
[1] https://patchwork.kernel.org/patch/4664801/
Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
PATCH 1/3 ARM: dts: Add DT changes for display on snow
Quoted 4 lines · Andreas F?rber
Am 25.07.2014 21:44, schrieb Ajay Kumar:
Quoted 1 line
Add DT nodes for ptn3460 bridge chip and panel-simple panel.
"simple-panel"
Ok.
Quoted 30 lines
Quoted 30 lines
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.
Signed-off-by Ajay Kumar <[email protected]>--- arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++---------------- 1 file changed, 21 insertions(+), 19 deletions(-)arch/arm/boot/dts/exynos5250-snow.dts +2
-2@@ -270,7 +270,7 @@ dcdc3 { ti,enable-ext-control; }; - fet1 { + fet1: fet1 { regulator-name = "vcd_led"; ti,overcurrent-wait = <3>; };@@ -293,7 +293,7 @@ regulator-always-on; ti,overcurrent-wait = <3>; }; - fet6 { + fet6: fet6 { regulator-name = "lcd_vdd"; ti,overcurrent-wait = <3>; };
Quoted 8 lines
arch/arm/boot/dts/exynos5250-snow.dts line 346
Quoted 6 lines
arch/arm/boot/dts/exynos5250-snow.dts +2
-0@@ -342,6 +342,15 @@ pinctrl-0 = <&max98095_en>; pinctrl-names = "default"; }; + + ptn3460: ptn3460-bridge at 20 {"lvds-bridge"? (AF)
Ok.
Quoted 29 lines
Quoted 29 lines
arch/arm/boot/dts/exynos5250-snow.dts +10
-1+ compatible = "nxp,ptn3460"; + reg = <0x20>; + powerdown-gpios = <&gpy2 5 0>; + reset-gpios = <&gpx1 5 0>; + edid-emulation = <5>; + panel = <&panel>; + }; }; i2s0: i2s at 03830000 {@@ -389,11 +398,13 @@ vdd_pll-supply = <&ldo8_reg>; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx3 0 0>; + power-supply = <&fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };@@ -403,6 +414,12 @@ samsung,invert-vclk; };
Quoted 7 lines
arch/arm/boot/dts/exynos5250-snow.dts line 417
Quoted 1 line
arch/arm/boot/dts/exynos5250-snow.dts +1
-0+ panel: panel-simple {Just "panel"? (AF)
arch/arm/boot/dts/exynos5250-snow.dts line 418
Quoted 1 line
arch/arm/boot/dts/exynos5250-snow.dts +1
-0+ compatible = "simple-panel";Use something more concrete than "simple-panel"? (Thierry)
Right.
Quoted 25 lines
Quoted 25 lines
arch/arm/boot/dts/exynos5250-snow.dts +4
-14+ power-supply = <&fet6>; + backlight = <&backlight>; + }; + dp-controller at 145B0000 { status = "okay"; pinctrl-names = "default";@@ -414,21 +431,6 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx0 7 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <70589280>; - hactive = <1366>; - vactive = <768>; - hfront-porch = <40>; - hback-porch = <40>; - hsync-len = <32>; - vback-porch = <10>; - vfront-porch = <12>; - vsync-len = <6>;
Quoted 8 lines
arch/arm/boot/dts/exynos5250-snow.dts line 436
Quoted 5 lines
arch/arm/boot/dts/exynos5250-snow.dts +1
-2- }; - }; + bridge = <&ptn3460>; }; };This patch will trivially conflict with my Snow cleanup [1]; ptn3460 would go into the appropriate &i2c_* and this hunk into &dp then.
Yes, display-timings node should be removed from the DP DT node. Should I rebase these DT patches on top of your cleanup series?
Ajay
PATCH 2/3 ARM: dts: Add DT changes for display on peach_pit
In reply to Ajay KumarAdd DT nodes for ps8622 bridge chip and panel-simple panel. Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on peach_pit.
Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.
--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++------------- 1 file changed, 19 insertions(+), 17 deletions(-)
arch/arm/boot/dts/exynos5420-peach-pit.dts +19 -17
@@ -30,11 +30,12 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };
@@ -100,6 +101,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple { + compatible = "chunghwa,claa101wb01", "simple-panel"; + power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {
@@ -113,22 +120,7 @@ samsung,link-rate = <0x06>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <70589280>; - hactive = <1366>; - vactive = <768>; - hfront-porch = <40>; - hback-porch = <40>; - hsync-len = <32>; - vback-porch = <10>; - vfront-porch = <12>; - vsync-len = <6>; - }; - }; + bridge = <&ps8625>; }; &fimd {
@@ -155,6 +147,16 @@ pinctrl-names = "default"; pinctrl-0 = <&max98090_irq>; }; + + ps8625: ps8625-bridge at 48 { + compatible = "parade,ps8625"; + reg = <0x48>; + sleep-gpios = <&gpx3 5 0>; + reset-gpios = <&gpy7 7 0>; + lane-count = <2>; + panel = <&panel>; + backlight = <&backlight>; + }; }; &hsi2c_9 {
Signature · 1 line
1.7.9.5
PATCH 2/3 ARM: dts: Add DT changes for display on peach_pit
Hello Ajay,
Quoted 10 lines · Ajay Kumar
Add DT nodes for ps8622 bridge chip and panel-simple panel. Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display onpeach_pit.Note that,
peach_pitdoesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.Signed-off-by Ajay Kumar <[email protected]>---
Best regards,
Javier
PATCH 2/3 ARM: dts: Add DT changes for display on peach_pit
In reply to Ajay KumarAm 25.07.2014 21:44, schrieb Ajay Kumar:
Quoted 1 line
Add DT nodes for ps8622 bridge chip and panel-simple panel.
"simple-panel"
Quoted 2 lines
Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display onpeach_pit.
Note that peach_pi[t] is inconsistent with the file names being peach-pi[t] here and in the two subjects.
Quoted 29 lines
Note that,
peach_pitdoesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.Signed-off-by Ajay Kumar <[email protected]>--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++------------- 1 file changed, 19 insertions(+), 17 deletions(-)arch/arm/boot/dts/exynos5420-peach-pit.dts +2
-1@@ -30,11 +30,12 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };
arch/arm/boot/dts/exynos5420-peach-pit.dts line 105
Quoted 5 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +2
-0@@ -100,6 +101,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple {
Just "panel"? (AF)
arch/arm/boot/dts/exynos5420-peach-pit.dts line 106
Quoted 1 line
arch/arm/boot/dts/exynos5420-peach-pit.dts +1
-0+ compatible = "chunghwa,claa101wb01", "simple-panel";
Drop "simple-panel" (Thierry)
Quoted 31 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +4
-16+ power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {@@ -113,22 +120,7 @@ samsung,link-rate = <0x06>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <70589280>; - hactive = <1366>; - vactive = <768>; - hfront-porch = <40>; - hback-porch = <40>; - hsync-len = <32>; - vback-porch = <10>; - vfront-porch = <12>; - vsync-len = <6>; - }; - }; + bridge = <&ps8625>; }; &fimd {
arch/arm/boot/dts/exynos5420-peach-pit.dts line 151
Quoted 5 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +2
-0@@ -155,6 +147,16 @@ pinctrl-names = "default"; pinctrl-0 = <&max98090_irq>; }; + + ps8625: ps8625-bridge at 48 {
"lvds-bridge"? (AF)
arch/arm/boot/dts/exynos5420-peach-pit.dts line 162
Quoted 11 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +8
-0+ compatible = "parade,ps8625"; + reg = <0x48>; + sleep-gpios = <&gpx3 5 0>; + reset-gpios = <&gpy7 7 0>; + lane-count = <2>; + panel = <&panel>; + backlight = <&backlight>; + }; }; &hsi2c_9 {
Regards,
Andreas
Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
PATCH 2/3 ARM: dts: Add DT changes for display on peach_pit
Quoted 4 lines · Andreas F?rber
Am 25.07.2014 21:44, schrieb Ajay Kumar:
Quoted 1 line
Add DT nodes for ps8622 bridge chip and panel-simple panel.
"simple-panel"
Ok.
Quoted 5 lines
Quoted 2 lines
Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display onpeach_pit.Note that peach_pi[t] is inconsistent with the file names being peach-pi[t] here and in the two subjects.
Ok.
Quoted 37 lines
Quoted 29 lines
Note that,
peach_pitdoesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.Signed-off-by Ajay Kumar <[email protected]>--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++------------- 1 file changed, 19 insertions(+), 17 deletions(-)arch/arm/boot/dts/exynos5420-peach-pit.dts +2
-1@@ -30,11 +30,12 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };arch/arm/boot/dts/exynos5420-peach-pit.dts line 105
Quoted 5 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +2
-0@@ -100,6 +101,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple {Just "panel"? (AF)
Quoted 3 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts line 106
Quoted 1 line
arch/arm/boot/dts/exynos5420-peach-pit.dts +1
-0+ compatible = "chunghwa,claa101wb01", "simple-panel";Drop "simple-panel" (Thierry)
Right.
Quoted 29 lines
Quoted 29 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +4
-16+ power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {@@ -113,22 +120,7 @@ samsung,link-rate = <0x06>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <70589280>; - hactive = <1366>; - vactive = <768>; - hfront-porch = <40>; - hback-porch = <40>; - hsync-len = <32>; - vback-porch = <10>; - vfront-porch = <12>; - vsync-len = <6>; - }; - }; + bridge = <&ps8625>; };
Quoted 9 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts line 151
Quoted 7 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +2
-0&fimd {@@ -155,6 +147,16 @@ pinctrl-names = "default"; pinctrl-0 = <&max98090_irq>; }; + + ps8625: ps8625-bridge at 48 {"lvds-bridge"? (AF)
Ok.
I will fix all these nits and resend along with the driver patches.
Ajay
Quoted 18 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts line 162
Quoted 11 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +8
-0+ compatible = "parade,ps8625"; + reg = <0x48>; + sleep-gpios = <&gpx3 5 0>; + reset-gpios = <&gpy7 7 0>; + lane-count = <2>; + panel = <&panel>; + backlight = <&backlight>; + }; }; &hsi2c_9 {Regards,
Andreas--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
PATCH 3/3 ARM: dts: Add DT changes for display on peach_pi
In reply to Ajay KumarAdd DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add panel phandle needed by dp to enable display on peach_pi.
--- arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)
arch/arm/boot/dts/exynos5800-peach-pi.dts +10 -17
@@ -28,11 +28,13 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx2 2 0>; + power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };
@@ -98,6 +100,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple { + compatible = "auo,b133htn01", "simple-panel"; + power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {
@@ -111,22 +119,7 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <150660000>; - hactive = <1920>; - vactive = <1080>; - hfront-porch = <60>; - hback-porch = <172>; - hsync-len = <80>; - vback-porch = <25>; - vfront-porch = <10>; - vsync-len = <10>; - }; - }; + panel = <&panel>; }; &fimd {
Signature · 1 line
1.7.9.5
PATCH 3/3 ARM: dts: Add DT changes for display on peach_pi
Hello Ajay,
Quoted 6 lines · Ajay Kumar
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add panel phandle needed by dp to enable display onpeach_pi.Signed-off-by Ajay Kumar <[email protected]>---
Looks good to me.
Best regards,
Javier
PATCH 3/3 ARM: dts: Add DT changes for display on peach_pi
In reply to Ajay KumarSeeing a Reviewed-by, I'm recording comments from another thread so that they don't get forgotten:
Am 25.07.2014 21:44, schrieb Ajay Kumar:
Quoted 29 lines
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add panel phandle needed by dp to enable display onpeach_pi.Signed-off-by Ajay Kumar <[email protected]>--- arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)arch/arm/boot/dts/exynos5800-peach-pi.dts +3
-1@@ -28,11 +28,13 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx2 2 0>; + power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };
arch/arm/boot/dts/exynos5800-peach-pi.dts line 104
Quoted 5 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +2
-0@@ -98,6 +100,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple {
Just "panel"? (AF)
arch/arm/boot/dts/exynos5800-peach-pi.dts line 105
Quoted 1 line
arch/arm/boot/dts/exynos5800-peach-pi.dts +1
-0+ compatible = "auo,b133htn01", "simple-panel";
Drop "simple-panel" (Thierry)
Quoted 20 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +3
-10+ power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {@@ -111,22 +119,7 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <150660000>; - hactive = <1920>; - vactive = <1080>; - hfront-porch = <60>; - hback-porch = <172>;
arch/arm/boot/dts/exynos5800-peach-pi.dts line 125
Quoted 10 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +1
-6- hsync-len = <80>; - vback-porch = <25>; - vfront-porch = <10>; - vsync-len = <10>; - }; - }; + panel = <&panel>; }; &fimd {
Regards,
Andreas
Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
PATCH 3/3 ARM: dts: Add DT changes for display on peach_pi
Quoted 2 lines · Andreas F?rber
Seeing a Reviewed-by, I'm recording comments from another thread so that they don't get forgotten:
I did remember these. Thanks for the reminder though!
Quoted 37 lines
Am 25.07.2014 21:44, schrieb Ajay Kumar:
Quoted 29 lines
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add panel phandle needed by dp to enable display onpeach_pi.Signed-off-by Ajay Kumar <[email protected]>--- arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)arch/arm/boot/dts/exynos5800-peach-pi.dts +3
-1@@ -28,11 +28,13 @@ i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; }; - backlight { + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 1000000 0>; brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; default-brightness-level = <7>; + enable-gpios = <&gpx2 2 0>; + power-supply = <&tps65090_fet1>; pinctrl-0 = <&pwm0_out>; pinctrl-names = "default"; };arch/arm/boot/dts/exynos5800-peach-pi.dts line 104
Quoted 5 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +2
-0@@ -98,6 +100,12 @@ regulator-boot-on; regulator-always-on; }; + + panel: panel-simple {Just "panel"? (AF)
Quoted 3 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts line 105
Quoted 1 line
arch/arm/boot/dts/exynos5800-peach-pi.dts +1
-0+ compatible = "auo,b133htn01", "simple-panel";Drop "simple-panel" (Thierry)
I will fix all these nits as per the other patch and resend along with the driver patches.
Ajay
Quoted 37 lines
Quoted 20 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +3
-10+ power-supply = <&tps65090_fet6>; + backlight = <&backlight>; + }; }; &dp {@@ -111,22 +119,7 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 0>; - - display-timings { - native-mode = <&timing1>; - - timing1: timing at 1 { - clock-frequency = <150660000>; - hactive = <1920>; - vactive = <1080>; - hfront-porch = <60>; - hback-porch = <172>;arch/arm/boot/dts/exynos5800-peach-pi.dts line 125
Quoted 10 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +1
-6- hsync-len = <80>; - vback-porch = <25>; - vfront-porch = <10>; - vsync-len = <10>; - }; - }; + panel = <&panel>; }; &fimd {Regards,
Andreas--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg