Skip to contentSkip to conversation

phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry

PATCH Superseded Sjoerd Simons 2 participants 3 messages Aug 22, 2014 – Aug 25, 2014

Subsystems (2)
Arm Samsung Exynos Generic PHY framework
lore
Share & tools
lore

Sjoerd Simons

author
#0 lore raw

PATCH 1/1 phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry

Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the module to be autoloaded based on devicetree information.

Signed-off-by Sjoerd Simons <[email protected]>
---
 drivers/phy/phy-exynos5-usbdrd.c | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/phy-exynos5-usbdrd.c +1 -0
index b05302b..e9a0f54 100644
@@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE (of, exynos5_usbdrd_phy_of_match);
 
 static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
 {
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry

Hi,

Am 22.08.2014 15:58, schrieb Sjoerd Simons:

Quoted 13 lines

Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the module to be autoloaded based on devicetree information.

Signed-off-by Sjoerd Simons <[email protected]>
---
 drivers/phy/phy-exynos5-usbdrd.c | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/phy-exynos5-usbdrd.c +0 -0
index b05302b..e9a0f54 100644

drivers/phy/phy-exynos5-usbdrd.c static const struct of_device_id exynos5_usbdrd_phy_of_match[] = { · line 545

Quoted 4 lines
drivers/phy/phy-exynos5-usbdrd.c +1 -0
@@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE (of, exynos5_usbdrd_phy_of_match);

Nit: Probably there should be no space before '('?

drivers/phy/phy-exynos5-usbdrd.c static const struct of_device_id exynos5_usbdrd_phy_of_match[] = { · line 548

Quoted 3 lines
drivers/phy/phy-exynos5-usbdrd.c +0 -0
 static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
 {

Otherwise certainly sensible. I ran into another such case myself.

Regards,
Andreas

Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
author
#2 lore raw

PATCH v2 1/1 phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry

Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the module to be autoloaded based on devicetree information.

Signed-off-by Sjoerd Simons <[email protected]>

---
Changes since v1:
- Fix an indentation nitpick spotted by Andreas F?rber

 drivers/phy/phy-exynos5-usbdrd.c | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/phy-exynos5-usbdrd.c +1 -0
index b05302b..392101c 100644
@@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE(of, exynos5_usbdrd_phy_of_match);
 
 static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
 {
Signature · 1 line
2.1.0