Skip to contentSkip to conversation

net: bnx2x: fix build error with ptp

PATCH Applied Randy Dunlap 2 participants 3 messages Aug 25, 2014 – Aug 26, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: bnx2x: fix build error with ptp

From: Randy Dunlap <[email protected]>

bnx2x uses ptp functions, so it should select the provider of those functions (PTP_1588_CLOCK). Fixes these build errors:

drivers/built-in.o: In function `__bnx2x_remove':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13409:
undefined reference to ptp_clock_unregister' drivers/built-in.o: In function bnx2x_register_phc':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13202:
undefined reference to ptp_clock_register' drivers/built-in.o: In function bnx2x_get_ts_info':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3498:
undefined reference to `ptp_clock_index'

---
 drivers/net/ethernet/broadcom/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/broadcom/Kconfig +1 -0
Index: linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
===================================================================
@@ -122,6 +122,7 @@ config TIGON3
 config BNX2X
 	tristate "Broadcom NetXtremeII 10Gb support"
 	depends on PCI
+	select PTP_1588_CLOCK
 	select FW_LOADER
 	select ZLIB_INFLATE
 	select LIBCRC32C
#1 lore raw

Note: This patch fixes a build error in linux-next (not in mainline).

Quoted 34 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

bnx2x uses ptp functions, so it should select the provider of those functions (PTP_1588_CLOCK). Fixes these build errors:

drivers/built-in.o: In function `__bnx2x_remove':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13409:
undefined reference to ptp_clock_unregister' drivers/built-in.o: In function bnx2x_register_phc':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13202:
undefined reference to ptp_clock_register' drivers/built-in.o: In function bnx2x_get_ts_info':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3498:
undefined reference to `ptp_clock_index'

---
 drivers/net/ethernet/broadcom/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
===================================================================

drivers/net/ethernet/broadcom/Kconfig +1 -1
@@ -122,6 +122,7 @@ config TIGON3
 config BNX2X
 	tristate "Broadcom NetXtremeII 10Gb support"
 	depends on PCI
+	select PTP_1588_CLOCK
 	select FW_LOADER
 	select ZLIB_INFLATE
 	select LIBCRC32C
--
Signature · 1 line
~Randy
maintainer Applied
#2 lore raw

From: Randy Dunlap <[email protected]>
Date: Mon, 25 Aug 2014 13:14:08 -0700

Quoted 1 line

Note: This patch fixes a build error in linux-next (not in mainline).

Applied to net-next, thanks Randy.

You can put "[PATCH net-next]" into your subject line to make this explicit next time.