Skip to contentSkip to conversation

clocksource: Document Renesas SoC specific bindings

PATCH New Simon Horman 3 participants 8 messages Aug 27, 2014 – Sep 3, 2014

Subsystems (3)
Device tree bindings SuperH Clocksource, clockevent drivers
lore
Share & tools
lore

Simon Horman

author
#0 lore raw

cover clocksource: Document Renesas SoC specific bindings

In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for the drivers a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas clocksource drivers to follow this convention.

I plan to follow up with patches to use these new bindings in the dtsi files for the affected SoCs.

Simon Horman (3):
clocksource: sh_cmt: Document SoC specific bindings
clocksource: sh_mtu2: Document r7s72100 binding
clocksource: sh_tmu: Document r8a7779 binding

 .../devicetree/bindings/timer/renesas,cmt.txt      | 26 +++++++++++++++++++++-
 .../devicetree/bindings/timer/renesas,mtu2.txt     |  6 +++--
 .../devicetree/bindings/timer/renesas,tmu.txt      |  6 +++--
 3 files changed, 33 insertions(+), 5 deletions(-)
Signature · 1 line
2.0.1
author
#1 lore raw

PATCH 1/3 clocksource: sh_cmt: Document SoC specific bindings

In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for the drivers a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Compare Match Timer (CMT) driver to follow this convention.

Signed-off-by Simon Horman <[email protected]>

---
* I plan to follow up with patches to use these new bindings in the dtsi files for the affected SoCs.

---
 .../devicetree/bindings/timer/renesas,cmt.txt      | 26 +++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/timer/renesas,cmt.txt +25 -1
index a17418b..500bad2 100644
@@ -16,10 +16,34 @@ Required Properties:
 		(CMT0 on sh7372, sh73a0 and r8a7740)
     - "renesas,cmt-32-fast" for the 32-bit CMT with fast clock support
 		(CMT[234] on sh7372, sh73a0 and r8a7740)
+    - "renesas,cmt-32-fast-r8a7740" for the R8A7740 32-bit CMT with fast
+		clock support (CMT[234])
+    - "renesas,cmt-32-fast-sh7372" for the SH7372 32-bit CMT with fast
+		clock support (CMT[234])
+    - "renesas,cmt-32-fast-sh73a0" for the SH73A0 32-bit CMT with fast
+		clock support (CMT[234])
+    - "renesas,cmt-32-r8a7740" for the R8a7740 32-bit CMT
+		(CMT0)
+    - "renesas,cmt-32-sh7372" for the SH7372 32-bit CMT
+		(CMT0)
+    - "renesas,cmt-32-sh73a0" for the SH73a0 32-bit CMT
+		(CMT0)
     - "renesas,cmt-48" for the 48-bit CMT
 		(CMT1 on sh7372, sh73a0 and r8a7740)
     - "renesas,cmt-48-gen2" for the second generation 48-bit CMT
 		(CMT[01] on r8a73a4, r8a7790 and r8a7791)
+    - "renesas,cmt-48-r8a73a4" for the R8A73A4 48-bit CMT
+		(CMT[01])
+    - "renesas,cmt-48-r8a7740" for the R8A7740 48-bit CMT
+		(CMT1)
+    - "renesas,cmt-48-r8a7790" for the R8A7790 48-bit CMT
+		(CMT[01])
+    - "renesas,cmt-48-r8a7791" for the R8A7791 48-bit CMT
+		(CMT[01])
+    - "renesas,cmt-48-sh7372" for the SH7372 48-bit CMT
+		(CMT1)
+    - "renesas,cmt-48-sh73a0" for the SH73A0 48-bit CMT
+		(CMT1)
 
   - reg: base address and length of the registers block for the timer module.
   - interrupts: interrupt-specifier for the timer, one per channel.

@@ -36,7 +60,7 @@ Example: R8A7790 (R-Car H2) CMT0 node
 	them channels 0 and 1 in the documentation.
 
 	cmt0: timer at ffca0000 {
-		compatible = "renesas,cmt-48-gen2";
+		compatible = "renesas,cmt-48-r8a7790", "renesas,cmt-48-gen2";
 		reg = <0 0xffca0000 0 0x1004>;
 		interrupts = <0 142 IRQ_TYPE_LEVEL_HIGH>,
 			     <0 142 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.0.1
author
#2 lore raw

PATCH 2/3 clocksource: sh_mtu2: Document r7s72100 binding

In reply to Simon Horman

In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for the drivers a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Multi-Function Timer Pulse Unit 2 (MTU2) driver to follow this convention.

Signed-off-by Simon Horman <[email protected]>

---
* I plan to follow up with a patch patch to use the new binding in the dtsi files for the r7s72100 SoC.

---
 Documentation/devicetree/bindings/timer/renesas,mtu2.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +4 -2
index 917453f..ec4d334 100644
@@ -8,7 +8,9 @@ are independent. The MTU2 hardware supports five channels indexed from 0 to 4.
 
 Required Properties:
 
-  - compatible: must contain "renesas,mtu2"
+  - compatible: must be one of the following.
+    - "renesas,mtu2" for generic MTU2
+    - "renesas,mtu2-r7s72100" for R7S72100 MTU2
 
   - reg: base address and length of the registers block for the timer module.
 

@@ -26,7 +28,7 @@ Required Properties:
 Example: R7S72100 (RZ/A1H) MTU2 node
 
 	mtu2: timer at fcff0000 {
-		compatible = "renesas,mtu2";
+		compatible = "renesas,mtu2-r7s72100", "renesas,mtu2";
 		reg = <0xfcff0000 0x400>;
 		interrupts = <0 139 IRQ_TYPE_LEVEL_HIGH>,
 			     <0 146 IRQ_TYPE_LEVEL_HIGH>,
Signature · 1 line
2.0.1
#3 lore raw

PATCH 2/3 clocksource: sh_mtu2: Document r7s72100 binding

Hello.

Quoted 26 lines · Simon Horman

In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for the drivers a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Multi-Function Timer Pulse Unit 2 (MTU2) driver to follow this convention.

Signed-off-by Simon Horman <[email protected]>

---
* I plan to follow up with a patch patch to use the new binding in the dtsi files for the r7s72100 SoC.

---
  Documentation/devicetree/bindings/timer/renesas,mtu2.txt | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +0 -0
index 917453f..ec4d334 100644

Documentation/devicetree/bindings/timer/renesas,mtu2.txt are independent. The MTU2 hardware supports five channels indexed from 0 to 4. · line 11

Quoted 5 lines
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +1 -1
@@ -8,7 +8,9 @@ are independent. The MTU2 hardware supports five channels indexed from 0 to 4.
 
  Required Properties:
 
-  - compatible: must contain "renesas,mtu2"
+  - compatible: must be one of the following.

Your example below has both.

Quoted 6 lines
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +2 -0
+    - "renesas,mtu2" for generic MTU2
+    - "renesas,mtu2-r7s72100" for R7S72100 MTU2
 
    - reg: base address and length of the registers block for the timer module.

Documentation/devicetree/bindings/timer/renesas,mtu2.txt Required Properties: · line 34

Quoted 8 lines
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +1 -1
@@ -26,7 +28,7 @@ Required Properties:
  Example: R7S72100 (RZ/A1H) MTU2 node
 
  	mtu2: timer at fcff0000 {
-		compatible = "renesas,mtu2";
+		compatible = "renesas,mtu2-r7s72100", "renesas,mtu2";
  		reg = <0xfcff0000 0x400>;
  		interrupts = <0 139 IRQ_TYPE_LEVEL_HIGH>,
  			     <0 146 IRQ_TYPE_LEVEL_HIGH>,

WBR, Sergei

#4 lore raw

PATCH 2/3 clocksource: sh_mtu2: Document r7s72100 binding

Quoted 31 lines · Sergei Shtylyov

Hello.

Quoted 27 lines · Simon Horman

In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for the drivers a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Multi-Function Timer Pulse Unit 2 (MTU2) driver to follow this convention.

Signed-off-by Simon Horman <[email protected]>

---
* I plan to follow up with a patch patch to use the new binding in the dtsi files for the r7s72100 SoC.

---
 Documentation/devicetree/bindings/timer/renesas,mtu2.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +0 -0
index 917453f..ec4d334 100644
@@ -8,7 +8,9 @@ are independent. The MTU2 hardware supports five channels indexed from 0 to 4.
Quoted 6 lines

Documentation/devicetree/bindings/timer/renesas,mtu2.txt are independent. The MTU2 hardware supports five channels indexed from 0 to 4. · line 11

Quoted 4 lines
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +1 -1
 Required Properties:
 
-  - compatible: must contain "renesas,mtu2"
+  - compatible: must be one of the following.

Your example below has both.

Thanks, as I will change "one of" to "one or more of".

Quoted 22 lines
Quoted 6 lines
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +2 -0
+    - "renesas,mtu2" for generic MTU2
+    - "renesas,mtu2-r7s72100" for R7S72100 MTU2
 
   - reg: base address and length of the registers block for the timer module.

Documentation/devicetree/bindings/timer/renesas,mtu2.txt Required Properties: · line 34

Quoted 8 lines
Documentation/devicetree/bindings/timer/renesas,mtu2.txt +1 -1
@@ -26,7 +28,7 @@ Required Properties:
 Example: R7S72100 (RZ/A1H) MTU2 node
 
 	mtu2: timer at fcff0000 {
-		compatible = "renesas,mtu2";
+		compatible = "renesas,mtu2-r7s72100", "renesas,mtu2";
 		reg = <0xfcff0000 0x400>;
 		interrupts = <0 139 IRQ_TYPE_LEVEL_HIGH>,
 			     <0 146 IRQ_TYPE_LEVEL_HIGH>,

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw

PATCH 3/3 clocksource: sh_tmu: Document r8a7779 binding

In reply to Simon Horman

In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for the drivers a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Timer Unit (TMU) driver to follow this convention.

Signed-off-by Simon Horman <[email protected]>

---
* I plan to follow up with a patch patch to use the new binding in the dtsi files for the r8a7779 SoC.

---
 Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/renesas,tmu.txt +4 -2
index 425d0c5..712ddfa 100644
@@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three channels.
 
 Required Properties:
 
-  - compatible: must contain "renesas,tmu"
+  - compatible: must contain one of the following.
+    - "renesas,tmu" generic TMU
+    - "renesas,tmu-r8a7779" R8A7779 TMU
 
   - reg: base address and length of the registers block for the timer module.
 

@@ -27,7 +29,7 @@ Optional Properties:
 Example: R8A7779 (R-Car H1) TMU0 node
 
 	tmu0: timer at ffd80000 {
-		compatible = "renesas,tmu";
+		compatible = "renesas,tmu-r8a7779", "renesas,tmu";
 		reg = <0xffd80000 0x30>;
 		interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>,
 			     <0 33 IRQ_TYPE_LEVEL_HIGH>,
Signature · 1 line
2.0.1
#6 lore raw

PATCH 3/3 clocksource: sh_tmu: Document r8a7779 binding

Quoted 26 lines · Simon Horman

In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for the drivers a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Timer Unit (TMU) driver to follow this convention.

Signed-off-by Simon Horman <[email protected]>

---
* I plan to follow up with a patch patch to use the new binding in the dtsi files for the r8a7779 SoC.

---
  Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/renesas,tmu.txt +0 -0
index 425d0c5..712ddfa 100644

Documentation/devicetree/bindings/timer/renesas,tmu.txt are independent. The TMU hardware supports up to three channels. · line 11

Quoted 5 lines
Documentation/devicetree/bindings/timer/renesas,tmu.txt +1 -1
@@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three channels.
 
  Required Properties:
 
-  - compatible: must contain "renesas,tmu"
+  - compatible: must contain one of the following.

Likewise, the example has both.

Quoted 6 lines
Documentation/devicetree/bindings/timer/renesas,tmu.txt +2 -0
+    - "renesas,tmu" generic TMU
+    - "renesas,tmu-r8a7779" R8A7779 TMU
 
    - reg: base address and length of the registers block for the timer module.

Documentation/devicetree/bindings/timer/renesas,tmu.txt Optional Properties: · line 35

Quoted 8 lines
Documentation/devicetree/bindings/timer/renesas,tmu.txt +1 -1
@@ -27,7 +29,7 @@ Optional Properties:
  Example: R8A7779 (R-Car H1) TMU0 node
 
  	tmu0: timer at ffd80000 {
-		compatible = "renesas,tmu";
+		compatible = "renesas,tmu-r8a7779", "renesas,tmu";
  		reg = <0xffd80000 0x30>;
  		interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>,
  			     <0 33 IRQ_TYPE_LEVEL_HIGH>,

WBR, Sergei

#7 lore raw

PATCH 3/3 clocksource: sh_tmu: Document r8a7779 binding

Quoted 29 lines · Sergei Shtylyov
Quoted 27 lines · Simon Horman

In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for the drivers a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Timer Unit (TMU) driver to follow this convention.

Signed-off-by Simon Horman <[email protected]>

---
* I plan to follow up with a patch patch to use the new binding in the dtsi files for the r8a7779 SoC.

---
 Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/renesas,tmu.txt +0 -0
index 425d0c5..712ddfa 100644
@@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three channels.
Quoted 6 lines

Documentation/devicetree/bindings/timer/renesas,tmu.txt are independent. The TMU hardware supports up to three channels. · line 11

Quoted 4 lines
Documentation/devicetree/bindings/timer/renesas,tmu.txt +1 -1
 Required Properties:
 
-  - compatible: must contain "renesas,tmu"
+  - compatible: must contain one of the following.

Likewise, the example has both.

Thanks, as I will change "one of" to "one or more of".

Quoted 22 lines
Quoted 6 lines
Documentation/devicetree/bindings/timer/renesas,tmu.txt +2 -0
+    - "renesas,tmu" generic TMU
+    - "renesas,tmu-r8a7779" R8A7779 TMU
 
   - reg: base address and length of the registers block for the timer module.

Documentation/devicetree/bindings/timer/renesas,tmu.txt Optional Properties: · line 35

Quoted 8 lines
Documentation/devicetree/bindings/timer/renesas,tmu.txt +1 -1
@@ -27,7 +29,7 @@ Optional Properties:
 Example: R8A7779 (R-Car H1) TMU0 node
 
 	tmu0: timer at ffd80000 {
-		compatible = "renesas,tmu";
+		compatible = "renesas,tmu-r8a7779", "renesas,tmu";
 		reg = <0xffd80000 0x30>;
 		interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>,
 			     <0 33 IRQ_TYPE_LEVEL_HIGH>,

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html