package/xscreensaver: fix linking with intl
PATCH v2 1/1 package/xscreensaver: fix linking with intl
Hi Thomas,
Le 26/08/2014 09:23, Thomas Petazzoni a ?crit :
Quoted 9 lines
Dear Romain Naour,
Review
Quoted 1 line · Romain Naour
(quoted diff) +1
-0+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXTHave you verified if it's really
BR2_NEEDS_GETTEXTorBR2_NEEDS_GETTEXT_IF_LOCALEthat should be used?
gettext package is always selected with xscreensaver when BR2_NEEDS_GETTEXT is set due to dependencies on libgtk2 and libglib2.
This is libglib2 that select gettext package when BR2_NEEDS_GETTEXT is set.
But, It seems that xscreensaver can live without gettext by looking at utils/xscreensaver-intl.h.
So, it's seems correct to select gettext package when BR2_NEEDS_GETTEXT_IF_LOCALE is set but the build fail with the following link error:
xscreensaver.o: In function `main':
undefined reference to `libintl_bindtextdomain'
undefined reference to `libintl_textdomain'
That why I added BR2_NEEDS_GETTEXT...
Ok, I just found a patch that fix this issue in version 5.28. Please see v3.
Thanks for your review !
Best regards
Romain