Skip to contentSkip to conversation

drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()

PATCH In review James Flowers 2 participants 4 messages May 3, 2025 – May 20, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()

Adds kernel-doc for externally linked dc_stream_remove_writeback function.

---
V1 -> V2: Corrected checkpatch warnings and errors

 drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_stream.c +8 -0
index e6e41678525f..b883fb24fa12 100644
@@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
 	return true;
 }
 
+/**
+ * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
+ * @dc: Display core control structure.
+ * @stream: Display core stream state.
+ * @dwb_pipe_inst: Display writeback pipe.
+ *
+ * Return: returns true on success, false otherwise.
+ */
 bool dc_stream_remove_writeback(struct dc *dc,
 		struct dc_stream_state *stream,
 		uint32_t dwb_pipe_inst)
Signature · 1 line
2.49.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 28 lines · James Flowers

Adds kernel-doc for externally linked dc_stream_remove_writeback function.

---
V1 -> V2: Corrected checkpatch warnings and errors

  drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
  1 file changed, 8 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_stream.c +8 -0
index e6e41678525f..b883fb24fa12 100644
@@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
  	return true;
  }
 
+/**
+ * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
+ * @dc: Display core control structure.
+ * @stream: Display core stream state.
+ * @dwb_pipe_inst: Display writeback pipe.
+ *
+ * Return: returns true on success, false otherwise.
+ */
  bool dc_stream_remove_writeback(struct dc *dc,
  		struct dc_stream_state *stream,
  		uint32_t dwb_pipe_inst)
author
#2 lore raw
Quoted 20 lines · Alex Hung
Quoted 17 lines · James Flowers

Adds kernel-doc for externally linked dc_stream_remove_writeback function.

---
V1 -> V2: Corrected checkpatch warnings and errors

  drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
  1 file changed, 8 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_stream.c +0 -0
index e6e41678525f..b883fb24fa12 100644
@@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
  	return true;
  }
 
Quoted 11 lines

drivers/gpu/drm/amd/display/dc/core/dc_stream.c bool dc_stream_fc_disable_writeback(struct dc *dc, · line 582

Quoted 11 lines
drivers/gpu/drm/amd/display/dc/core/dc_stream.c +8 -0
+/**
+ * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
+ * @dc: Display core control structure.
+ * @stream: Display core stream state.
+ * @dwb_pipe_inst: Display writeback pipe.
+ *
+ * Return: returns true on success, false otherwise.
+ */
  bool dc_stream_remove_writeback(struct dc *dc,
  		struct dc_stream_state *stream,
  		uint32_t dwb_pipe_inst)

Hi,

I am just following up on this to see if it’s been applied, or if any adjustments are still needed.

Best regards,
James Flowers

#3 lore raw
Quoted 37 lines · James
Quoted 20 lines · Alex Hung
Quoted 17 lines · James Flowers

Adds kernel-doc for externally linked dc_stream_remove_writeback function.

---
V1 -> V2: Corrected checkpatch warnings and errors

   drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
   1 file changed, 8 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_stream.c +0 -0
index e6e41678525f..b883fb24fa12 100644
@@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
   	return true;
   }
 
Quoted 11 lines

drivers/gpu/drm/amd/display/dc/core/dc_stream.c bool dc_stream_fc_disable_writeback(struct dc *dc, · line 582

Quoted 11 lines
drivers/gpu/drm/amd/display/dc/core/dc_stream.c +8 -0
+/**
+ * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
+ * @dc: Display core control structure.
+ * @stream: Display core stream state.
+ * @dwb_pipe_inst: Display writeback pipe.
+ *
+ * Return: returns true on success, false otherwise.
+ */
   bool dc_stream_remove_writeback(struct dc *dc,
   		struct dc_stream_state *stream,
   		uint32_t dwb_pipe_inst)

Hi,

Quoted 1 line

I am just following up on this to see if it’s been applied, or if any adjustments are still needed.

It's in amd-staging-drm-next: https://gitlab.freedesktop.org/agd5f/linux/-/commit/04abe7201d51a094d0edd3e00399a8afa2cd2d4f

Quoted 3 lines

Best regards,
James Flowers