Skip to contentSkip to conversation

drm/amdgpu/display: disable eDP fast boot optimization on DCE8

PATCH In review Alex Deucher 2 participants 5 messages Aug 16, 2018 – Aug 21, 2018 3 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/display: disable eDP fast boot optimization on DCE8

Seems to cause blank screens.

---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +7 -1
index 350ee3e3e34d..2e3f85ceeaa9 100644
@@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
 	bool can_eDP_fast_boot_optimize = false;
 
 	if (edp_link) {
-		can_eDP_fast_boot_optimize =
+		/* this seems to cause blank screens on DCE8 */
+		if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
+		    (dc->ctx->dce_version == DCE_VERSION_8_1) ||
+		    (dc->ctx->dce_version == DCE_VERSION_8_3))
+			can_eDP_fast_boot_optimize = false;
+		else
+			can_eDP_fast_boot_optimize =
 				edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
 	}
 
Signature · 6 lines
2.13.6

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20180816203826.29959-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 4 lines · Alex Deucher

Seems to cause blank screens.

Harry

Quoted 14 lines
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +0 -1
index 350ee3e3e34d..2e3f85ceeaa9 100644
@@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
 	bool can_eDP_fast_boot_optimize = false;
 
 	if (edp_link) {
-		can_eDP_fast_boot_optimize =

drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context) · line 1574

Quoted 10 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +7 -0
+		/* this seems to cause blank screens on DCE8 */
+		if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
+		    (dc->ctx->dce_version == DCE_VERSION_8_1) ||
+		    (dc->ctx->dce_version == DCE_VERSION_8_3))
+			can_eDP_fast_boot_optimize = false;
+		else
+			can_eDP_fast_boot_optimize =
 				edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
 	}
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to a message not in the archive
Quoted 4 lines · Alex Deucher

Seems to cause blank screens.

Your SOB is using a different email from the author. Mind if I change it to your gmail?

Harry

Quoted 14 lines
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +0 -1
index 350ee3e3e34d..2e3f85ceeaa9 100644
@@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
 	bool can_eDP_fast_boot_optimize = false;
 
 	if (edp_link) {
-		can_eDP_fast_boot_optimize =

drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context) · line 1574

Quoted 10 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +7 -0
+		/* this seems to cause blank screens on DCE8 */
+		if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
+		    (dc->ctx->dce_version == DCE_VERSION_8_1) ||
+		    (dc->ctx->dce_version == DCE_VERSION_8_3))
+			can_eDP_fast_boot_optimize = false;
+		else
+			can_eDP_fast_boot_optimize =
 				edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
 	}
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 53f3c4fb-355c-76f4-7356-ac68845cb271-5C7GfCeVMHo@public.gmane.org

#5 lore raw
Quoted 8 lines · Harry Wentland
Quoted 4 lines · Alex Deucher

Seems to cause blank screens.

Your SOB is using a different email from the author. Mind if I change it to your gmail?

Weird. not sure what happened there. I'd prefer you just override the author to my amd address.

Alex

Quoted 14 lines

Harry

Quoted 11 lines
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +0 -0
index 350ee3e3e34d..2e3f85ceeaa9 100644
@@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
      bool can_eDP_fast_boot_optimize = false;
 
Quoted 13 lines

drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context) · line 1574

Quoted 13 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +7 -1
      if (edp_link) {
-             can_eDP_fast_boot_optimize =
+             /* this seems to cause blank screens on DCE8 */
+             if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
+                 (dc->ctx->dce_version == DCE_VERSION_8_1) ||
+                 (dc->ctx->dce_version == DCE_VERSION_8_3))
+                     can_eDP_fast_boot_optimize = false;
+             else
+                     can_eDP_fast_boot_optimize =
                              edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
      }
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CADnq5_Or+PMFUWHD31xM6Qxbi2B_ACcPeMRjBp6rgRwK3k-4gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#7 lore raw
Quoted 5 lines · Alex Deucher
Quoted 4 lines · Harry Wentland
Quoted 2 lines · Alex Deucher

Seems to cause blank screens.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Your SOB is using a different email from the author. Mind if I change it to your gmail?

Weird. not sure what happened there. I'd prefer you just override the author to my amd address.

Done and pushed.

It looks like you sent the patch from your gmail, which is why that's shown as author.

Harry

Quoted 16 lines

Alex

Quoted 14 lines

Harry

Quoted 11 lines
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +0 -0
index 350ee3e3e34d..2e3f85ceeaa9 100644
@@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
      bool can_eDP_fast_boot_optimize = false;
 
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +3 -1
      if (edp_link) {
-             can_eDP_fast_boot_optimize =
+             /* this seems to cause blank screens on DCE8 */
+             if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
+                 (dc->ctx->dce_version == DCE_VERSION_8_1) ||
Quoted 8 lines

drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context) · line 1574

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +4 -0
+                 (dc->ctx->dce_version == DCE_VERSION_8_3))
+                     can_eDP_fast_boot_optimize = false;
+             else
+                     can_eDP_fast_boot_optimize =
                              edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
      }
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx