libarchive: avoid some tools to build statically on shared builds

PATCH New Vicente Olivert Riera 4 participants 5 messages Aug 29, 2014 – Sep 11, 2014

Share & tools

Vicente Olivert Riera

author

2014-08-29 13:39 UTC #0 lore raw

PATCH 1/1 libarchive: avoid some tools to build statically on shared builds

Some libarchive tools, like bsdtar, builds statically by default although libarchive itself is being built dynamically. We can force those tools to build the same way as libarchive by using the right configure options.

Fixes:
http://autobuild.buildroot.net/results/b8f/b8f7a29787ea1cc5c98e4cbd5f47f257f9b306f2/

Signed-off-by Vicente Olivert Riera <[email protected]>

---
 package/libarchive/libarchive.mk |   24 +++++++++++++++++++++---
 1 files changed, 21 insertions(+), 3 deletions(-)

package/libarchive/libarchive.mk +21 -3

index 8c6951d..979e65c 100644
@@ -9,9 +9,27 @@ LIBARCHIVE_SITE = http://www.libarchive.org/downloads
 LIBARCHIVE_INSTALL_STAGING = YES
 LIBARCHIVE_LICENSE = BSD-2c, BSD-3c
 LIBARCHIVE_LICENSE_FILES = COPYING
-LIBARCHIVE_CONF_OPT = --without-lzma \
-	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDTAR),--enable-bsdtar,--disable-bsdtar) \
-	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),--enable-bsdcpio,--disable-bsdcpio)
+LIBARCHIVE_CONF_OPT = --without-lzma
+
+ifeq ($(BR2_PACKAGE_LIBARCHIVE_BSDTAR),y)
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+LIBARCHIVE_CONF_OPT += --enable-bsdtar=static
+else
+LIBARCHIVE_CONF_OPT += --enable-bsdtar=shared
+endif
+else
+LIBARCHIVE_CONF_OPT += --disable-bsdtar
+endif
+
+ifeq ($(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),y)
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+LIBARCHIVE_CONF_OPT += --enable-bsdcpio=static
+else
+LIBARCHIVE_CONF_OPT += --enable-bsdcpio=shared
+endif
+else
+LIBARCHIVE_CONF_OPT += --disable-bsdcpio
+endif
 
 ifeq ($(BR2_PACKAGE_ACL),y)
 LIBARCHIVE_DEPENDENCIES += acl

Signature · 1 line

1.7.1

Thomas Petazzoni

2014-08-29 15:42 UTC #1 lore raw

PATCH 1/1 libarchive: avoid some tools to build statically on shared builds

Dear Vicente Olivert Riera,

Quoted 38 lines · Vicente Olivert Riera

Fixes:
http://autobuild.buildroot.net/results/b8f/b8f7a29787ea1cc5c98e4cbd5f47f257f9b306f2/

Signed-off-by Vicente Olivert Riera <[email protected]>

---
 package/libarchive/libarchive.mk |   24 +++++++++++++++++++++---
 1 files changed, 21 insertions(+), 3 deletions(-)

package/libarchive/libarchive.mk +14 -3

index 8c6951d..979e65c 100644
@@ -9,9 +9,27 @@ LIBARCHIVE_SITE = http://www.libarchive.org/downloads
 LIBARCHIVE_INSTALL_STAGING = YES
 LIBARCHIVE_LICENSE = BSD-2c, BSD-3c
 LIBARCHIVE_LICENSE_FILES = COPYING
-LIBARCHIVE_CONF_OPT = --without-lzma \
-	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDTAR),--enable-bsdtar,--disable-bsdtar) \
-	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),--enable-bsdcpio,--disable-bsdcpio)
+LIBARCHIVE_CONF_OPT = --without-lzma
+
+ifeq ($(BR2_PACKAGE_LIBARCHIVE_BSDTAR),y)
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+LIBARCHIVE_CONF_OPT += --enable-bsdtar=static
+else
+LIBARCHIVE_CONF_OPT += --enable-bsdtar=shared
+endif
+else
+LIBARCHIVE_CONF_OPT += --disable-bsdtar
+endif
+
+ifeq ($(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),y)
+ifeq ($(BR2_PREFER_STATIC_LIB),y)

package/libarchive/libarchive.mk LIBARCHIVE_SITE = http://www.libarchive.org/downloads · line 35

Quoted 10 lines

package/libarchive/libarchive.mk +7 -0

+LIBARCHIVE_CONF_OPT += --enable-bsdcpio=static
+else
+LIBARCHIVE_CONF_OPT += --enable-bsdcpio=shared
+endif
+else
+LIBARCHIVE_CONF_OPT += --disable-bsdcpio
+endif
 
 ifeq ($(BR2_PACKAGE_ACL),y)
 LIBARCHIVE_DEPENDENCIES += acl

Could you check if it fixes
http://autobuild.buildroot.org/results/068/068febe05909af15f6620d7925f375c5da154bda/build-end.log ?

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Vicente Olivert Riera

author

2014-08-29 15:59 UTC #2 lore raw

PATCH 1/1 libarchive: avoid some tools to build statically on shared builds

Quoted 55 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,
Quoted 38 lines · Vicente Olivert Riera
Some libarchive tools, like bsdtar, builds statically by default although libarchive itself is being built dynamically. We can force those tools to build the same way as libarchive by using the right configure options.
Fixes:
   http://autobuild.buildroot.net/results/b8f/b8f7a29787ea1cc5c98e4cbd5f47f257f9b306f2/
Signed-off-by Vicente Olivert Riera <[email protected]>
---
  package/libarchive/libarchive.mk |   24 +++++++++++++++++++++---
  1 files changed, 21 insertions(+), 3 deletions(-)
package/libarchive/libarchive.mk +14 -3
index 8c6951d..979e65c 100644
@@ -9,9 +9,27 @@ LIBARCHIVE_SITE = http://www.libarchive.org/downloads
  LIBARCHIVE_INSTALL_STAGING = YES
  LIBARCHIVE_LICENSE = BSD-2c, BSD-3c
  LIBARCHIVE_LICENSE_FILES = COPYING
-LIBARCHIVE_CONF_OPT = --without-lzma \
-	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDTAR),--enable-bsdtar,--disable-bsdtar) \
-	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),--enable-bsdcpio,--disable-bsdcpio)
+LIBARCHIVE_CONF_OPT = --without-lzma
+
+ifeq ($(BR2_PACKAGE_LIBARCHIVE_BSDTAR),y)
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+LIBARCHIVE_CONF_OPT += --enable-bsdtar=static
+else
+LIBARCHIVE_CONF_OPT += --enable-bsdtar=shared
+endif
+else
+LIBARCHIVE_CONF_OPT += --disable-bsdtar
+endif
+
+ifeq ($(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),y)
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
package/libarchive/libarchive.mk LIBARCHIVE_SITE = http://www.libarchive.org/downloads · line 35
Quoted 10 lines
package/libarchive/libarchive.mk +7 -0
+LIBARCHIVE_CONF_OPT += --enable-bsdcpio=static
+else
+LIBARCHIVE_CONF_OPT += --enable-bsdcpio=shared
+endif
+else
+LIBARCHIVE_CONF_OPT += --disable-bsdcpio
+endif
 
  ifeq ($(BR2_PACKAGE_ACL),y)
  LIBARCHIVE_DEPENDENCIES += acl
Could you check if it fixes
http://autobuild.buildroot.org/results/068/068febe05909af15f6620d7925f375c5da154bda/build-end.log ?

Quoted 3 lines

Thanks!
Thomas

Confirmed, it also fixes that problem in ARM.

For MIPS, the real problem is this one:

http://git.uclibc.org/uClibc/patch/?id=b57e9640db53166c88cdac66b79a046e46b8d728

So we have two options. Apply that patch for uClibc ( another one :-( ), or just fix the libarchive package as I did.

For ARM, I don't know what the problem is, because that toolchain (the one used in the build log you told me) is not uClibc.

Signature · 1 line

Vincent

Romain Naour

2014-08-30 17:34 UTC #3 lore raw

PATCH 1/1 libarchive: avoid some tools to build statically on shared builds

Hi Thomas, Vicente

Le 29/08/2014 17:59, Vicente Olivert Riera a ?crit :

Quoted 67 lines · Thomas Petazzoni

Quoted 58 lines
Dear Vicente Olivert Riera,
Quoted 40 lines · Vicente Olivert Riera
Some libarchive tools, like bsdtar, builds statically by default although libarchive itself is being built dynamically. We can force those tools to build the same way as libarchive by using the right configure options.
Fixes:
http://autobuild.buildroot.net/results/b8f/b8f7a29787ea1cc5c98e4cbd5f47f257f9b306f2/
Signed-off-by Vicente Olivert Riera <[email protected]>
---
  package/libarchive/libarchive.mk |   24 +++++++++++++++++++++---
  1 files changed, 21 insertions(+), 3 deletions(-)
package/libarchive/libarchive.mk +14 -3
index 8c6951d..979e65c 100644
@@ -9,9 +9,27 @@ LIBARCHIVE_SITE = http://www.libarchive.org/downloads
  LIBARCHIVE_INSTALL_STAGING = YES
  LIBARCHIVE_LICENSE = BSD-2c, BSD-3c
  LIBARCHIVE_LICENSE_FILES = COPYING
-LIBARCHIVE_CONF_OPT = --without-lzma \
-    $(if $(BR2_PACKAGE_LIBARCHIVE_BSDTAR),--enable-bsdtar,--disable-bsdtar) \
-    $(if $(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),--enable-bsdcpio,--disable-bsdcpio)
+LIBARCHIVE_CONF_OPT = --without-lzma
+
+ifeq ($(BR2_PACKAGE_LIBARCHIVE_BSDTAR),y)
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+LIBARCHIVE_CONF_OPT += --enable-bsdtar=static
+else
+LIBARCHIVE_CONF_OPT += --enable-bsdtar=shared
+endif
+else
+LIBARCHIVE_CONF_OPT += --disable-bsdtar
+endif
+
+ifeq ($(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),y)
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
package/libarchive/libarchive.mk LIBARCHIVE_SITE = http://www.libarchive.org/downloads · line 35
Quoted 10 lines
package/libarchive/libarchive.mk +7 -0
+LIBARCHIVE_CONF_OPT += --enable-bsdcpio=static
+else
+LIBARCHIVE_CONF_OPT += --enable-bsdcpio=shared
+endif
+else
+LIBARCHIVE_CONF_OPT += --disable-bsdcpio
+endif
 
  ifeq ($(BR2_PACKAGE_ACL),y)
  LIBARCHIVE_DEPENDENCIES += acl
Could you check if it fixes
http://autobuild.buildroot.org/results/068/068febe05909af15f6620d7925f375c5da154bda/build-end.log
?
Quoted 3 lines
Thanks!
Thomas
Confirmed, it also fixes that problem in ARM.
For MIPS, the real problem is this one:

Quoted 8 lines

http://git.uclibc.org/uClibc/patch/?id=b57e9640db53166c88cdac66b79a046e46b8d728
So we have two options. Apply that patch for uClibc ( another one :-( ), or just fix the libarchive package as I did.
For ARM, I don't know what the problem is, because that toolchain (the one used in the build log you told me) is not uClibc.

For ARM the problem is that libarchive build system use the same variable $(LIBS) to link the shared library and link statically bsdtar and bsdcpio.

When BR2_PREFER_STATIC_LIB is disabled, $(LIBS) contains "-lcrypto -lexpat -llzo2 -lz"

So, when bsdtar and bsdcpio are linked "-ldl" is missing due to a dependency of OpenSSL on libdl.

# pkg-config --libs-only-l -static openssl
-lssl -lcrypto -ldl

# pkg-config --libs-only-l openssl
-lssl -lcrypto

If there is no particular reason to build statically bsdtar and bsdcpio when BR2_PREFER_STATIC_LIB is disabled, then I'm ok with your patch.

Tested-by Romain Naour <[email protected]>

Build tested with a custom uClibc 0.9.33 toolchain for mipsel Build tested with the ARM glibc toolchain used by autobuilder.

Best regards,
Romain

Peter Korsgaard

2014-09-11 20:52 UTC #4 lore raw

PATCH 1/1 libarchive: avoid some tools to build statically on shared builds

In reply to Vicente Olivert Riera

Quoted 11 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Vicente" == Vicente Olivert Riera <[email protected]> writes:
Some libarchive tools, like bsdtar, builds statically by default although libarchive itself is being built dynamically. We can force those tools to build the same way as libarchive by using the right configure options.
Fixes:
http://autobuild.buildroot.net/results/b8f/b8f7a29787ea1cc5c98e4cbd5f47f257f9b306f2/
Signed-off-by Vicente Olivert Riera <[email protected]>

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard