libphidget: needs dynamic library support
PATCH 1/1 libphidget: needs dynamic library support
Fixes:
http://autobuild.buildroot.net/results/932/9322c930a545bb500b5193a84b26895a03a6b7f7/
--- package/libphidget/Config.in | 4 +++- package/phidgetwebservice/Config.in | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
package/libphidget/Config.in +3 -1
@@ -1,6 +1,7 @@ config BR2_PACKAGE_LIBPHIDGET bool "libphidget" depends on BR2_TOOLCHAIN_HAS_THREADS # libusb + depends on !BR2_PREFER_STATIC_LIB select BR2_PACKAGE_LIBUSB help The libphidget library provides an API for controlling Phidgets
@@ -20,5 +21,6 @@ config BR2_PACKAGE_LIBPHIDGET http://phidgets.com/ -comment "libphidget needs a toolchain w/ threads" +comment "libphidget needs a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_PREFER_STATIC_LIB
package/phidgetwebservice/Config.in +3 -1
@@ -1,6 +1,7 @@ config BR2_PACKAGE_PHIDGETWEBSERVICE bool "phidgetwebservice" depends on BR2_TOOLCHAIN_HAS_THREADS # libusb, libphidget + depends on !BR2_PREFER_STATIC_LIB # libphidget select BR2_PACKAGE_LIBPHIDGET help phidgetwebservice (the Phidget WebService) provides an HTTP
@@ -15,5 +16,6 @@ config BR2_PACKAGE_PHIDGETWEBSERVICE http://phidgets.com/ -comment "phidgetwebservice needs a toolchain w/ threads" +comment "phidgetwebservice needs a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_PREFER_STATIC_LIB
Signature · 1 line
1.8.5.5
PATCH 1/1 libphidget: needs dynamic library support
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gustavo" == Gustavo Zacarias <[email protected]> writes:
Fixes:
http://autobuild.buildroot.net/results/932/9322c930a545bb500b5193a84b26895a03a6b7f7/Signed-off-by Gustavo Zacarias <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 libphidget: needs dynamic library support
In reply to Gustavo ZacariasHi Gustavo,
Thanks for the fix.
What should I have known or tested to find this myself at the time that I added the package?
- yba
Quoted 55 lines · Gustavo Zacarias
Date: Mon, 1 Sep 2014 21:16:51 -0300
From: Gustavo Zacarias <[email protected]>
To: buildroot at busybox.net
Subject: [Buildroot] [PATCH] libphidget: needs dynamic library supportFixes:
http://autobuild.buildroot.net/results/932/9322c930a545bb500b5193a84b26895a03a6b7f7/Signed-off-by Gustavo Zacarias <[email protected]>---
package/libphidget/Config.in | 4 +++-
package/phidgetwebservice/Config.in | 4 +++-2 files changed, 6 insertions(+), 2 deletions(-)package/libphidget/Config.in +0
-0@@ -1,6 +1,7 @@config
BR2_PACKAGE_LIBPHIDGET
bool "libphidget"
depends onBR2_TOOLCHAIN_HAS_THREADS# libusbpackage/libphidget/Config.in +1
-0+ depends on !BR2_PREFER_STATIC_LIBselect
BR2_PACKAGE_LIBUSB
help
The libphidget library provides an API for controlling Phidgetspackage/libphidget/Config.in +2
-1@@ -20,5 +21,6 @@ config BR2_PACKAGE_LIBPHIDGET http://phidgets.com/ -comment "libphidget needs a toolchain w/ threads" +comment "libphidget needs a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_PREFER_STATIC_LIBpackage/phidgetwebservice/Config.in +0
-0@@ -1,6 +1,7 @@config
BR2_PACKAGE_PHIDGETWEBSERVICE
bool "phidgetwebservice"
depends onBR2_TOOLCHAIN_HAS_THREADS# libusb, libphidgetpackage/phidgetwebservice/Config.in +1
-0+ depends on !BR2_PREFER_STATIC_LIB # libphidgetselect
BR2_PACKAGE_LIBPHIDGET
help
phidgetwebservice (the Phidget WebService) provides an HTTPpackage/phidgetwebservice/Config.in +2
-1@@ -15,5 +16,6 @@ config BR2_PACKAGE_PHIDGETWEBSERVICE http://phidgets.com/ -comment "phidgetwebservice needs a toolchain w/ threads" +comment "phidgetwebservice needs a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_PREFER_STATIC_LIB
Signature · 3 lines
9590 8E58 D30D 1660 C349 673D B205 4FC4 B8F5 B7F9 ~. .~ Tk Open Systems
=}-------- Jonathan Ben-Avraham ("yba") ----------ooO--U--Ooo------------{=
mailto:yba at tkos.co.il tel:+972.52.486.3386 http://tkos.co.il skype:benavrhmPATCH 1/1 libphidget: needs dynamic library support
Quoted 6 lines · Jonathan Ben Avraham
Hi Gustavo,
Thanks for the fix.
What should I have known or tested to find this myself at the time that I added the package?- yba
Hi Jonathan.
Usually when i add a new package i have a couple of prebuilt external toolchains to test against with just the basic toolchain options:
* Lowest possible version of linux headers for latest git buildroot, to find minimal requirements (rarely needed).
* Static & Dynamic
* Uclibc barebones (no rpc/wchar/lfs/ipv6)
* C++ and not.
There's no bulletproof formula to get all the options right, rather a set of hints to look at.
For example extensive use of mbstowcs/mblen/wctomb functions in the source usually indicates it needs wchar support (unless it's conditional). Non-conditional usage of in6* / IN6* for IPv6.
RPC functions (pmap_* xdr_*) for RPC.
Mandatory usage of dlopen, creation of shared libraries (plugins) or linking to libdl is usually a good hint that static-only isn't an option. And so on.
In the end the autobuilders were doing their job, there are many combinations that can slip under the radar: missing X syscall in some architecture, some assembly optimization that doesn't consider architecture variants which needs disabling and so on (example: can't handle ARM thumb-only mode).
Regards.