mdadm patch Monitor.c
Neil,
Hopefully, you are still the maintainer of mdadm.
I would like to request the following trivial patch... pretty please!
Monitor.c.new renamed from Monitor.c +1 -3
@@ -402,14 +402,12 @@ if (disc && disc[0] == ' ') fprintf(mp, "Extra information:%s.\n\n", disc); - fprintf(mp, "Faithfully yours, etc.\n"); - mdstat = fopen("/proc/mdstat", "r"); if (mdstat) { char buf[8192]; int n; fprintf(mp, - "\nP.S. The /proc/mdstat file" + "\nThe /proc/mdstat file" " currently contains the following:\n\n"); while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0) n=fwrite(buf, 1, n, mp);
The words removed above are superfluous and add no value to the message. In addition, they imply that the message is from a person, which is obviously not the case.
Cheers,
Phil
Signature · 6 lines
Phil Kauffman Systems Admin Dept. of Computer Science University of Chicago [email protected] 773-702-3913
Monitor.c.new renamed from Monitor.c +1 -3
@@ -402,14 +402,12 @@ if (disc && disc[0] == ' ') fprintf(mp, "Extra information:%s.\n\n", disc); - fprintf(mp, "Faithfully yours, etc.\n"); - mdstat = fopen("/proc/mdstat", "r"); if (mdstat) { char buf[8192]; int n; fprintf(mp, - "\nP.S. The /proc/mdstat file" + "\nThe /proc/mdstat file" " currently contains the following:\n\n"); while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0) n=fwrite(buf, 1, n, mp);