ARM: shmobile: lager: correct memory map
Subsystems (2)
PATCH 1/1 ARM: shmobile: lager: correct memory map
The base address of the second memory region on the lager board is 0x140000000. Update the tag used in the dts file accordingly.
This is a documentation fix and should have no run-time affect.
This problem was introduced when the second memory region was added to the lager dts file by 62bc32a2573c4219 ("ARM: shmobile: Include all 4 GiB of memory on Lager)" in v3.14.
--- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I am reposting this as Olof originally requested a syntax change, which I followed up on, however that change no longer seems appropriate. This this patch seems to be correct.
arch/arm/boot/dts/r8a7790-lager.dts +1 -1
@@ -32,7 +32,7 @@ reg = <0 0x40000000 0 0x40000000>; }; - memory at 180000000 { + memory at 140000000 { device_type = "memory"; reg = <1 0x40000000 0 0xc0000000>; };
Signature · 1 line
2.0.1
PATCH 1/1 ARM: shmobile: lager: correct memory map
Dear Simon-san, Shiiba-san,
Thanks for the patch.
Quoted 19 lines · Simon Horman
The base address of the second memory region on the lager board is
0x140000000. Update the tag used in the dts file accordingly.This is a documentation fix and should have no run-time affect.
This problem was introduced when the second memory region was added to the lager dts file by
62bc32a2573c4219("ARM: shmobile: Include all 4 GiB of memory on Lager)" in v3.14.Reported-by NAOYA SHIIBA <[email protected]>Signed-off-by Simon Horman <[email protected]>--- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)I am reposting this as Olof originally requested a syntax change, which I followed up on, however that change no longer seems appropriate. This this patch seems to be correct.
[...]
arch/arm/boot/dts/r8a7790-lager.dts line 35
Quoted 2 lines
arch/arm/boot/dts/r8a7790-lager.dts +1
-1- memory at 180000000 { + memory at 140000000 {
Could you give more information about not using new syntax ?
I checked memblock information in both 2 ways (i.e memory at 140000000 and memory at 1,40000000) and I got same result.
root at lager:~# cat /sys/kernel/debug/memblock/memory
0: 0x0000000040000000..0x000000007fffffff 1: 0x0000000140000000..0x00000001ffffffff
So, what does 'no longer seems appropriate" mean ?
arch/arm/boot/dts/r8a7790-lager.dts line 38
Quoted 4 lines
arch/arm/boot/dts/r8a7790-lager.dts +0
-0device_type = "memory"; reg = <1 0x40000000 0 0xc0000000>; };
Thanks.
Signature · 2 lines
Best regards, KHIEM Nguyen
PATCH 1/1 ARM: shmobile: lager: correct memory map
Hi Khiem-san,
Quoted 30 lines · Khiem Nguyen
Dear Simon-san, Shiiba-san,
Thanks for the patch.
Quoted 19 lines · Simon Horman
The base address of the second memory region on the lager board is
0x140000000. Update the tag used in the dts file accordingly.This is a documentation fix and should have no run-time affect.
This problem was introduced when the second memory region was added to the lager dts file by
62bc32a2573c4219("ARM: shmobile: Include all 4 GiB of memory on Lager)" in v3.14.Reported-by NAOYA SHIIBA <[email protected]>Signed-off-by Simon Horman <[email protected]>--- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)I am reposting this as Olof originally requested a syntax change, which I followed up on, however that change no longer seems appropriate. This this patch seems to be correct.
[...]
arch/arm/boot/dts/r8a7790-lager.dts line 35
Quoted 2 lines
arch/arm/boot/dts/r8a7790-lager.dts +1
-1- memory at 180000000 { + memory at 140000000 {Could you give more information about not using new syntax ?
Quoted 8 lines
I checked memblock information in both 2 ways (i.e memory at 140000000 and memory at 1,40000000) and I got same result.
root at lager:~# cat/sys/kernel/debug/memblock/memory
0: 0x0000000040000000..0x000000007fffffff 1: 0x0000000140000000..0x00000001ffffffffSo, what does 'no longer seems appropriate" mean ?
Sorry for being vague.
I am specifically referring to the conversation in
the thread "[PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7" and in particular the following contribution to that discussion by Olof:
"Ok, I'm happily proven wrong here, also by confirming how this is
done on "real" OF.
According to benh:
15:20 <benh> ojn: 0,0 is not quite right, it's supposed to be used when the two numbers are different things, like device,fn on PCI
The same is true for >2^32 unit addresses, they just use the one integer instead of x,y.
So, I take back all I've said on this in the last 72 hours. :) It looks like we might need to revisit some of the 32-bit DTs. Simon, drop the series you had. :)"
An archive of the message in question is available at:
https://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg36123.html
PATCH 1/1 ARM: shmobile: lager: correct memory map
Dear Simon-san,
Quoted 60 lines · Simon Horman
Hi Khiem-san,
Quoted 30 lines · Khiem Nguyen
Dear Simon-san, Shiiba-san,
Thanks for the patch.
Quoted 19 lines · Simon Horman
The base address of the second memory region on the lager board is
0x140000000. Update the tag used in the dts file accordingly.This is a documentation fix and should have no run-time affect.
This problem was introduced when the second memory region was added to the lager dts file by
62bc32a2573c4219("ARM: shmobile: Include all 4 GiB of memory on Lager)" in v3.14.Reported-by NAOYA SHIIBA <[email protected]>Signed-off-by Simon Horman <[email protected]>--- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)I am reposting this as Olof originally requested a syntax change, which I followed up on, however that change no longer seems appropriate. This this patch seems to be correct.
[...]
arch/arm/boot/dts/r8a7790-lager.dts line 35
Quoted 2 lines
arch/arm/boot/dts/r8a7790-lager.dts +1
-1- memory at 180000000 { + memory at 140000000 {Could you give more information about not using new syntax ?
Quoted 8 lines
I checked memblock information in both 2 ways (i.e memory at 140000000 and memory at 1,40000000) and I got same result.
root at lager:~# cat/sys/kernel/debug/memblock/memory
0: 0x0000000040000000..0x000000007fffffff 1: 0x0000000140000000..0x00000001ffffffffSo, what does 'no longer seems appropriate" mean ?
Sorry for being vague.
I am specifically referring to the conversation in
the thread "[PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7" and in particular the following contribution to that discussion by Olof:"Ok, I'm happily proven wrong here, also by confirming how this is
done on "real" OF.According to benh:
15:20 <benh> ojn: 0,0 is not quite right, it's supposed to be used when the two numbers are different things, like device,fn on PCI
The same is true for >2^32 unit addresses, they just use the one integer instead of x,y.
Quoted 6 lines
So, I take back all I've said on this in the last 72 hours. :) It looks like we might need to revisit some of the 32-bit DTs. Simon, drop the series you had. :)"
An archive of the message in question is available at:
https://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg36123.html
OK. I understood.
Let's follow the right way. :)
Signature · 2 lines
Best regards, KHIEM Nguyen
PATCH 1/1 ARM: shmobile: lager: correct memory map
Quoted 67 lines · Khiem Nguyen
Dear Simon-san,
Quoted 64 lines · Simon Horman
Hi Khiem-san,
Quoted 30 lines · Khiem Nguyen
Dear Simon-san, Shiiba-san,
Thanks for the patch.
Quoted 19 lines · Simon Horman
The base address of the second memory region on the lager board is
0x140000000. Update the tag used in the dts file accordingly.This is a documentation fix and should have no run-time affect.
This problem was introduced when the second memory region was added to the lager dts file by
62bc32a2573c4219("ARM: shmobile: Include all 4 GiB of memory on Lager)" in v3.14.Reported-by NAOYA SHIIBA <[email protected]>Signed-off-by Simon Horman <[email protected]>--- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)I am reposting this as Olof originally requested a syntax change, which I followed up on, however that change no longer seems appropriate. This this patch seems to be correct.
[...]
arch/arm/boot/dts/r8a7790-lager.dts line 35
Quoted 2 lines
arch/arm/boot/dts/r8a7790-lager.dts +1
-1- memory at 180000000 { + memory at 140000000 {Could you give more information about not using new syntax ?
Quoted 8 lines
I checked memblock information in both 2 ways (i.e memory at 140000000 and memory at 1,40000000) and I got same result.
root at lager:~# cat/sys/kernel/debug/memblock/memory
0: 0x0000000040000000..0x000000007fffffff 1: 0x0000000140000000..0x00000001ffffffffSo, what does 'no longer seems appropriate" mean ?
Sorry for being vague.
I am specifically referring to the conversation in
the thread "[PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7" and in particular the following contribution to that discussion by Olof:"Ok, I'm happily proven wrong here, also by confirming how this is
done on "real" OF.According to benh:
15:20 <benh> ojn: 0,0 is not quite right, it's supposed to be used when the two numbers are different things, like device,fn on PCI
The same is true for >2^32 unit addresses, they just use the one integer instead of x,y.
So, I take back all I've said on this in the last 72 hours. :) It looks like we might need to revisit some of the 32-bit DTs. Simon, drop the series you had. :)"
Quoted 5 lines
Quoted 2 lines
An archive of the message in question is available at:
https://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg36123.htmlOK. I understood.
Let's follow the right way. :)
Thanks. I have queued up this patch.