Skip to contentSkip to conversation

x86/HVM: restore parentheses lost by 3d4d4f9336

PATCH In review Jan Beulich 4 participants 5 messages Sep 3, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/HVM: restore parentheses lost by 3d4d4f9336

("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")

Coverity-ID: 1234366

xen/arch/x86/hvm/hvm.c +1 -1
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
 
     p2m = p2m_get_hostp2m(v->domain);
     mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, 
-                              P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
+                              P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
                               NULL);
 
     /* Check access permissions first, then handle faults */

x86/HVM: restore parentheses lost by 3d4d4f9336

("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")

Coverity-ID: 1234366

xen/arch/x86/hvm/hvm.c +1 -1
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
 
     p2m = p2m_get_hostp2m(v->domain);
     mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, 
-                              P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
+                              P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
                               NULL);
 
     /* Check access permissions first, then handle faults */

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#1 lore raw
Quoted 5 lines · Jan Beulich

("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")

Coverity-ID: 1234366

Ah - I had already posted a patch for this, but as the the change is identical, Reviewed-by: Andrew Cooper <[email protected]>

Quoted 17 lines
xen/arch/x86/hvm/hvm.c +1 -1
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
 
     p2m = p2m_get_hostp2m(v->domain);
     mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, 
-                              P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
+                              P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
                               NULL);
 
     /* Check access permissions first, then handle faults */
Quoted 4 lines

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#2 lore raw
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 03.09.14 at 14:53, <[email protected]> wrote:
Quoted 5 lines · Jan Beulich

("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")

Coverity-ID: 1234366

Ah - I had already posted a patch for this, but as the the change is identical, Reviewed-by: Andrew Cooper <[email protected]>

Yeah, I should probably have checked before sending.

Jan

Reviewed-by on v1 1/1
#3 lore raw
In reply to Jan Beulich
Quoted 5 lines · Jan Beulich

("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")

Coverity-ID: 1234366

Looks good.

Quoted 20 lines
xen/arch/x86/hvm/hvm.c +1 -1
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
 
      p2m = p2m_get_hostp2m(v->domain);
      mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
-                              P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
+                              P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
                                NULL);
 
      /* Check access permissions first, then handle faults */

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#4 lore raw
In reply to Jan Beulich
Quoted 3 lines · Jan Beulich

("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")

Coverity-ID: 1234366

Quoted 15 lines
xen/arch/x86/hvm/hvm.c +1 -1
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
 
     p2m = p2m_get_hostp2m(v->domain);
     mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
-                              P2M_ALLOC | npfec.write_access ?
 P2M_UNSHARE : 0,
+                              P2M_ALLOC | (npfec.write_access ?
 P2M_UNSHARE : 0),
                               NULL);
Quoted 3 lines
     /* Check access permissions first, then handle faults */

Whops, that's my mistake. Sorry about that.

Tamas

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel